Skip to content

NPA-5305: Add GET /Consent and GET /Consent/{id} ProposedConsent Component#239

Closed
JackPlowman wants to merge 2 commits into
masterfrom
bug/NPA-5305_proposed_proxy_roles
Closed

NPA-5305: Add GET /Consent and GET /Consent/{id} ProposedConsent Component#239
JackPlowman wants to merge 2 commits into
masterfrom
bug/NPA-5305_proposed_proxy_roles

Conversation

@JackPlowman

@JackPlowman JackPlowman commented Jul 18, 2025

Copy link
Copy Markdown
Contributor

Pull Request

🧾 Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-5305


📄 Description/Summary of Changes

  • Add ProposedConsent Component to GET /Consent and GET /Consent/[id}
  • Fixed an extra closing bracket in spec

🧪 Developer Testing Carried Out

  • NA

🧪 Reviewer Testing Required

  • NA

✅ Developer Checklist

  • PR title follows the format: NPA-XXXX: <short-description>
  • Branch name follows the convention: <type>/NPA-XXXX-<short-description>
  • Commit messages follow the template: NPA-XXXX: <short-description>
  • All acceptance criteria from the Jira ticket are addressed
  • Automated tests (unit/integration/API/infrastructure etc. tests) are added or updated
  • The traceability matrix is updated
    with
    new tests or requirements
  • Assignees and appropriate labels (e.g. terraform, documentation) are added

👀 Reviewer Checklist

  • Changes meet the acceptance criteria of the Jira ticket
  • Code is able to be merged (no conflicts and adheres to coding standards)
  • Sufficient test evidence is provided (manual and/or automated)
  • Infrastructure/operational/build changes are validated (if applicable)

🚀 Post-merge

After merging and deploying changes to the sandbox, Postman collection or spec examples please run the Run Postman
collection workflow.

This will run the tests within the collection to check that the sandbox is working as expected once deployed.

@github-actions

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5305

@JackPlowman JackPlowman self-assigned this Jul 18, 2025
@JackPlowman JackPlowman added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 18, 2025
@JackPlowman JackPlowman changed the title NPA-5305: Add ProposedConsent Component NPA-5305: Add GET /Consent and GET /Consent/{id} ProposedConsent Component Jul 18, 2025
@JackPlowman JackPlowman marked this pull request as ready for review July 18, 2025 10:56
@github-actions

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5305

@JackPlowman JackPlowman added the bug Something isn't working label Jul 18, 2025
@JackPlowman JackPlowman deleted the bug/NPA-5305_proposed_proxy_roles branch August 28, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant