Skip to content

NPA-5212: Update GP emails for consent and comprehension changes#244

Merged
ClarksonAdam merged 1 commit into
masterfrom
task/NPA-5212/update-access-level-codes
Aug 28, 2025
Merged

NPA-5212: Update GP emails for consent and comprehension changes#244
ClarksonAdam merged 1 commit into
masterfrom
task/NPA-5212/update-access-level-codes

Conversation

@ClarksonAdam

@ClarksonAdam ClarksonAdam commented Aug 28, 2025

Copy link
Copy Markdown
Contributor

Pull Request

🧾 Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-5212


📄 Description/Summary of Changes

  • Added new access levels (RECRD, COND, CONSULT, DOCS)
  • Removed contacting GP surgery (CNTCT)
  • Updated CODE descriptions
  • Updated examples
  • Updated Postman collection

🧪 Developer Testing Carried Out

  • Run Postman collection
  • Review OAS

🧪 Reviewer Testing Required

  • Run postman collection
  • Review OAS

✅ Developer Checklist

  • PR title follows the format: NPA-XXXX: <short-description>
  • Branch name follows the convention: <type>/NPA-XXXX-<short-description>
  • Commit messages follow the template: NPA-XXXX: <short-description>
  • All acceptance criteria from the Jira ticket are addressed
  • Automated tests (unit/integration/API/infrastructure etc. tests) are added or updated
  • Assignees and appropriate labels (e.g. terraform, documentation) are added

👀 Reviewer Checklist

  • Changes meet the acceptance criteria of the Jira ticket
  • Code is able to be merged (no conflicts and adheres to coding standards)
  • Sufficient test evidence is provided (manual and/or automated)
  • Infrastructure/operational/build changes are validated (if applicable)

🚀 Post-merge

After merging and deploying changes to the sandbox, Postman collection or spec examples please run the Run Postman
collection workflow.

This will run the tests within the collection to check that the sandbox is working as expected once deployed.

@ClarksonAdam ClarksonAdam self-assigned this Aug 28, 2025
@ClarksonAdam ClarksonAdam added documentation Improvements or additions to documentation enhancement New feature or request postman Changes to the postman collection endpoints labels Aug 28, 2025
@github-actions

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5212

@JackPlowman JackPlowman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ClarksonAdam ClarksonAdam merged commit 04744ba into master Aug 28, 2025
17 checks passed
@ClarksonAdam ClarksonAdam deleted the task/NPA-5212/update-access-level-codes branch August 28, 2025 15:17
ClarksonAdam added a commit that referenced this pull request Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation endpoints enhancement New feature or request postman Changes to the postman collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants