Skip to content

NPA-5357: Migrate GET /QuestionnaireResponse to accept an ID parameter#245

Merged
lelliott-hippo merged 17 commits into
masterfrom
task/NPA-5357/questionnaireresponse-replace-referencecode-with-id
Sep 12, 2025
Merged

NPA-5357: Migrate GET /QuestionnaireResponse to accept an ID parameter#245
lelliott-hippo merged 17 commits into
masterfrom
task/NPA-5357/questionnaireresponse-replace-referencecode-with-id

Conversation

@lelliott-hippo

@lelliott-hippo lelliott-hippo commented Sep 3, 2025 •
edited by JackPlowman
Loading

Copy link
Copy Markdown
Contributor

Pull Request

🧾 Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-5357

📄 Description/Summary of Changes

  • Updated Specification, Sandbox and Postman for GET /QuestionnaireResponse to accept an ID parameter.
    • Fixed Postman collection existing broken tests
  • Removed link to test matrix in PR template

🧪 Developer Testing Carried Out

  • Run postman tests against local flask server, all tests passed

🧪 Reviewer Testing Required

  • NA

✅ Developer Checklist

  • PR title follows the format: NPA-XXXX: <short-description>
  • Branch name follows the convention: <type>/NPA-XXXX-<short-description>
  • Commit messages follow the template: NPA-XXXX: <short-description>
  • All acceptance criteria from the Jira ticket are addressed
  • Automated tests (unit/integration/API/infrastructure etc. tests) are added or updated
  • The traceability matrix is updated
    with
    new tests or requirements
  • Assignees and appropriate labels (e.g. terraform, documentation) are added

👀 Reviewer Checklist

  • Changes meet the acceptance criteria of the Jira ticket
  • Code is able to be merged (no conflicts and adheres to coding standards)
  • Sufficient test evidence is provided (manual and/or automated)
  • Infrastructure/operational/build changes are validated (if applicable)

🚀 Post-merge

After merging and deploying changes to the sandbox, Postman collection or spec examples please run the Run Postman
collection workflow.

This will run the tests within the collection to check that the sandbox is working as expected once deployed.

@github-actions

github-actions Bot commented Sep 3, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5357

@JackPlowman JackPlowman self-assigned this Sep 3, 2025
@github-actions

github-actions Bot commented Sep 3, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5357

@github-actions

github-actions Bot commented Sep 3, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5357

@JackPlowman JackPlowman added documentation Improvements or additions to documentation enhancement New feature or request python Pull requests that update Python code postman Changes to the postman collection endpoints labels Sep 3, 2025
@JackPlowman JackPlowman changed the title NPA-5357: Implement QuestionnaireResponse UUID NPA-5357: Migrate GET /QuestionnaireResponse to accept an ID parameter Sep 3, 2025
@github-actions

github-actions Bot commented Sep 3, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5357

@JackPlowman JackPlowman force-pushed the task/NPA-5357/questionnaireresponse-replace-referencecode-with-id branch from 070d499 to 8f42b90 Compare September 3, 2025 14:22
@github-actions

github-actions Bot commented Sep 3, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5357

@JackPlowman JackPlowman force-pushed the task/NPA-5357/questionnaireresponse-replace-referencecode-with-id branch from 8f42b90 to bf8ceec Compare September 3, 2025 14:30
@github-actions

github-actions Bot commented Sep 3, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5357

2 similar comments
@github-actions

github-actions Bot commented Sep 4, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5357

@github-actions

github-actions Bot commented Sep 8, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5357

@lelliott-hippo lelliott-hippo force-pushed the task/NPA-5357/questionnaireresponse-replace-referencecode-with-id branch from 7047cfe to d1d0890 Compare September 8, 2025 09:45
@github-actions

github-actions Bot commented Sep 8, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5357

2 similar comments
@github-actions

github-actions Bot commented Sep 8, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5357

@github-actions

github-actions Bot commented Sep 9, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5357

@lelliott-hippo lelliott-hippo force-pushed the task/NPA-5357/questionnaireresponse-replace-referencecode-with-id branch from ce3d044 to 65de166 Compare September 9, 2025 09:22
@github-actions

github-actions Bot commented Sep 9, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5357

@lelliott-hippo lelliott-hippo force-pushed the task/NPA-5357/questionnaireresponse-replace-referencecode-with-id branch from 65de166 to ed0e8cf Compare September 9, 2025 12:19
@github-actions

github-actions Bot commented Sep 9, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5357

@lelliott-hippo lelliott-hippo force-pushed the task/NPA-5357/questionnaireresponse-replace-referencecode-with-id branch from ed0e8cf to 2ae692d Compare September 9, 2025 12:21
@github-actions

github-actions Bot commented Sep 9, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5357

@lelliott-hippo lelliott-hippo force-pushed the task/NPA-5357/questionnaireresponse-replace-referencecode-with-id branch from 2ae692d to a7da883 Compare September 9, 2025 12:24
@github-actions

github-actions Bot commented Sep 9, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5357

lelliott-hippo and others added 16 commits September 10, 2025 10:06
@lelliott-hippo
NPA-5357: Replaced referenceCode with accessRequestUUID and updated r…
27ba21c 
…esponses
@lelliott-hippo
NPA-5357: Update test GET/QuestionnaireResponse to use UUID
c031769
@lelliott-hippo
NPA-5357: Update sandbox response examples
bb0b642
@lelliott-hippo
NPA-5357: Update Postman collection
9eaef1e
@lelliott-hippo
NPA-5357: Update sandbox README to clarify updating examples
a5f9b70
@lelliott-hippo
NPA-5357: Update Postman collection
0817197
@lelliott-hippo
NPA-5357: Update Postman collection
4263c22
@lelliott-hippo
NPA-5357: Update GET /QuestionnaireResponse id
a81658b
@lelliott-hippo
NPA-5357: Update OAS for error returns
ab72758
@JackPlowman @lelliott-hippo
NPA-5357: Fix GET /QuestionnaireResponse Spec Reference Errors
0b99d9f
@JackPlowman @lelliott-hippo
NPA-5357: Fix Postman Collection
7ebab1c
@JackPlowman @lelliott-hippo
NPA-5357: Improve Specification Definitions and Formatting
8f158c1
@JackPlowman @lelliott-hippo
NPA-5357: Update Postman Collection and Sandbox for ID
91196f5
@lelliott-hippo
NPA-5357: Revert POST /QuestionnaireResponse to use ReferenceCode
48965e9
@lelliott-hippo
NPA-5357: Add UUID to location header for POST
3f579df
@lelliott-hippo
NPA-5357: Postman update
55d55af
@lelliott-hippo lelliott-hippo force-pushed the task/NPA-5357/questionnaireresponse-replace-referencecode-with-id branch from a7da883 to 580d2ed Compare September 10, 2025 11:07
@github-actions

github-actions Bot commented Sep 10, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5357

JackPlowman
JackPlowman reviewed Sep 11, 2025
View reviewed changes

@JackPlowman JackPlowman left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty happy with the PR. I've have left a few tiny comments, happy to discuss if you disagree with them

Comment thread specification/validated-relationships-service-api.yaml Outdated
Comment thread specification/validated-relationships-service-api.yaml Outdated
Comment thread ...on/examples/responses/GET_QuestionnaireResponse/errors/questionnaire_response_not_found.yaml Outdated
@lelliott-hippo lelliott-hippo force-pushed the task/NPA-5357/questionnaireresponse-replace-referencecode-with-id branch from 580d2ed to 906a5da Compare September 11, 2025 09:10
@github-actions

github-actions Bot commented Sep 11, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5357

JackPlowman
JackPlowman approved these changes Sep 11, 2025
View reviewed changes

@JackPlowman JackPlowman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lelliott-hippo lelliott-hippo merged commit e88bebd into master Sep 12, 2025
17 checks passed
@lelliott-hippo lelliott-hippo deleted the task/NPA-5357/questionnaireresponse-replace-referencecode-with-id branch September 12, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JackPlowman JackPlowman JackPlowman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JackPlowman JackPlowman

@lelliott-hippo lelliott-hippo

Labels

documentation Improvements or additions to documentation endpoints enhancement New feature or request postman Changes to the postman collection python Pull requests that update Python code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lelliott-hippo @JackPlowman