Skip to content

NPA-5559: IOPS Amendments to GET RelatedPerson#252

Merged
ellie-bound1-NHSD merged 7 commits into
masterfrom
task/NPA-5559/iops-amendments-to-GET-related-person
Sep 19, 2025
Merged

NPA-5559: IOPS Amendments to GET RelatedPerson#252
ellie-bound1-NHSD merged 7 commits into
masterfrom
task/NPA-5559/iops-amendments-to-GET-related-person

Conversation

@ellie-bound1-NHSD

@ellie-bound1-NHSD ellie-bound1-NHSD commented Sep 16, 2025

Copy link
Copy Markdown
Contributor

Pull Request

🧾 Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-5559

📄 Description/Summary of Changes

  • Update to GET /RelatedPerson example response by removing id property from the name object for both Patient and RelatedPerson resources, plus removing type: Patient property from the patient object in the RelatedPerson resources
  • Updates have been reflected in the postman collection

🧪 Developer Testing Carried Out

🧪 Reviewer Testing Required

✅ Developer Checklist

  • PR title follows the format: NPA-XXXX: <short-description>
  • Branch name follows the convention: <type>/NPA-XXXX-<short-description>
  • Commit messages follow the template: NPA-XXXX: <short-description>
  • All acceptance criteria from the Jira ticket are addressed
  • Automated tests (unit/integration/API/infrastructure etc. tests) are added or updated
  • Assignees and appropriate labels (e.g. terraform, documentation) are added

👀 Reviewer Checklist

  • Changes meet the acceptance criteria of the Jira ticket
  • Code is able to be merged (no conflicts and adheres to coding standards)
  • Sufficient test evidence is provided (manual and/or automated)
  • Infrastructure/operational/build changes are validated (if applicable)

🚀 Post-merge

After merging and deploying changes to the sandbox, Postman collection or spec examples please run the Run Postman
collection workflow.

This will run the tests within the collection to check that the sandbox is working as expected once deployed.

@ellie-bound1-NHSD ellie-bound1-NHSD self-assigned this Sep 16, 2025
@ellie-bound1-NHSD ellie-bound1-NHSD added documentation Improvements or additions to documentation postman Changes to the postman collection labels Sep 16, 2025
@github-actions

github-actions Bot commented Sep 16, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5559

2 similar comments
@github-actions

github-actions Bot commented Sep 16, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5559

@github-actions

github-actions Bot commented Sep 17, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5559

@ellie-bound1-NHSD ellie-bound1-NHSD force-pushed the task/NPA-5559/iops-amendments-to-GET-related-person branch from 7b4939a to 6c8c53e Compare September 18, 2025 14:19
@github-actions

github-actions Bot commented Sep 18, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5559

@github-actions

github-actions Bot commented Sep 18, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5559

@github-actions

github-actions Bot commented Sep 18, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5559

@ellie-bound1-NHSD ellie-bound1-NHSD changed the title NPA-5559/: IOPS Amendments to GET RelatedPerson NPA-5559: IOPS Amendments to GET RelatedPerson Sep 18, 2025
JackPlowman
JackPlowman approved these changes Sep 19, 2025
View reviewed changes

@JackPlowman JackPlowman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ellie-bound1-NHSD ellie-bound1-NHSD merged commit 75e70f7 into master Sep 19, 2025
17 checks passed
@ellie-bound1-NHSD ellie-bound1-NHSD deleted the task/NPA-5559/iops-amendments-to-GET-related-person branch September 19, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JackPlowman JackPlowman JackPlowman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ellie-bound1-NHSD ellie-bound1-NHSD

Labels

documentation Improvements or additions to documentation postman Changes to the postman collection

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ellie-bound1-NHSD @JackPlowman