Skip to content

NPA-5629: OperationOutcome Update#254

Merged
lelliott-hippo merged 1 commit into
masterfrom
task/NPA-5629/OperationOutcome-update
Sep 18, 2025
Merged

NPA-5629: OperationOutcome Update#254
lelliott-hippo merged 1 commit into
masterfrom
task/NPA-5629/OperationOutcome-update

Conversation

@lelliott-hippo

@lelliott-hippo lelliott-hippo commented Sep 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Pull Request

🧾 Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-5629

📄 Description/Summary of Changes

  • OperationOutcome errors updated to correctly display diagnostics
  • AccessDeniedError updated to correctly display code: forbidden (in line with backend)
  • Postman collection updated with changes

🧪 Developer Testing Carried Out

  • Updated Postman tests all passing

🧪 Reviewer Testing Required

✅ Developer Checklist

  • PR title follows the format: NPA-XXXX: <short-description>
  • Branch name follows the convention: <type>/NPA-XXXX-<short-description>
  • Commit messages follow the template: NPA-XXXX: <short-description>
  • All acceptance criteria from the Jira ticket are addressed
  • Automated tests (unit/integration/API/infrastructure etc. tests) are added or updated
  • Assignees and appropriate labels (e.g. terraform, documentation) are added

👀 Reviewer Checklist

  • Changes meet the acceptance criteria of the Jira ticket
  • Code is able to be merged (no conflicts and adheres to coding standards)
  • Sufficient test evidence is provided (manual and/or automated)
  • Infrastructure/operational/build changes are validated (if applicable)

🚀 Post-merge

After merging and deploying changes to the sandbox, Postman collection or spec examples please run the Run Postman
collection workflow.

This will run the tests within the collection to check that the sandbox is working as expected once deployed.

@lelliott-hippo lelliott-hippo added enhancement New feature or request postman Changes to the postman collection labels Sep 17, 2025
@github-actions

github-actions Bot commented Sep 17, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5629

@lelliott-hippo lelliott-hippo changed the title Task/npa 5629/operation outcome update NPA-5629: OperationOutcome Update Sep 17, 2025
@github-actions

github-actions Bot commented Sep 17, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5629

@lelliott-hippo lelliott-hippo force-pushed the task/NPA-5629/OperationOutcome-update branch from fbd90bd to abdff2c Compare September 17, 2025 13:59
@github-actions

github-actions Bot commented Sep 17, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5629

@lelliott-hippo lelliott-hippo force-pushed the task/NPA-5629/OperationOutcome-update branch from abdff2c to 1482ca3 Compare September 18, 2025 10:29
@github-actions

github-actions Bot commented Sep 18, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5629

@lelliott-hippo lelliott-hippo force-pushed the task/NPA-5629/OperationOutcome-update branch from 1482ca3 to 101187e Compare September 18, 2025 10:31
@github-actions

github-actions Bot commented Sep 18, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5629

@lelliott-hippo lelliott-hippo force-pushed the task/NPA-5629/OperationOutcome-update branch from 101187e to d6926e2 Compare September 18, 2025 13:28
@github-actions

github-actions Bot commented Sep 18, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5629

1 similar comment
@github-actions

github-actions Bot commented Sep 18, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5629

@lelliott-hippo lelliott-hippo force-pushed the task/NPA-5629/OperationOutcome-update branch from 20acd16 to 21b6285 Compare September 18, 2025 13:38
@github-actions

github-actions Bot commented Sep 18, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5629

JackPlowman
JackPlowman approved these changes Sep 18, 2025
View reviewed changes

@JackPlowman JackPlowman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lelliott-hippo lelliott-hippo force-pushed the task/NPA-5629/OperationOutcome-update branch from 21b6285 to 9890f76 Compare September 18, 2025 13:52
@github-actions

github-actions Bot commented Sep 18, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5629

@lelliott-hippo lelliott-hippo force-pushed the task/NPA-5629/OperationOutcome-update branch from 9890f76 to 7280c5a Compare September 18, 2025 13:56
@github-actions

github-actions Bot commented Sep 18, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5629

@lelliott-hippo
NPA-5629: OperationOutcome IOPS
62bb425 
Signed-off-by: lelliott-hippo <luke.elliott@hippodigital.co.uk>
@lelliott-hippo lelliott-hippo force-pushed the task/NPA-5629/OperationOutcome-update branch from 7280c5a to 62bb425 Compare September 18, 2025 14:08
@github-actions

github-actions Bot commented Sep 18, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5629

@lelliott-hippo lelliott-hippo merged commit e3f2d52 into master Sep 18, 2025
16 of 17 checks passed
@lelliott-hippo lelliott-hippo deleted the task/NPA-5629/OperationOutcome-update branch September 18, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JackPlowman JackPlowman JackPlowman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request postman Changes to the postman collection

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lelliott-hippo @JackPlowman