Skip to content

NPA-5565: Update the Sandbox test scenarios table#257

Merged
ChristopherBacon merged 4 commits into
masterfrom
task/NPA-5565/amend-sandbox-test-scenarios
Sep 25, 2025
Merged

NPA-5565: Update the Sandbox test scenarios table#257
ChristopherBacon merged 4 commits into
masterfrom
task/NPA-5565/amend-sandbox-test-scenarios

Conversation

@ChristopherBacon

@ChristopherBacon ChristopherBacon commented Sep 25, 2025

Copy link
Copy Markdown
Contributor

Pull Request

🧾 Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-5565


📄 Description/Summary of Changes

  • Updated the 'Sandbox test scenarios' table in the OAS Spec for all endpoints

🧪 Developer Testing Carried Out

  • Ran the sandbox/api/tests all are passing.
image
  • Visual inspected the changes on: Swagger editor, as an example see below for Consent ID endpoint:
image

🧪 Reviewer Testing Required

  • Check the 'Sandbox test scenarios' tables for each endpoint in the OAS
  • Run the sandbox/api tests to check existing endpoints are working as required

✅ Developer Checklist

  • PR title follows the format: NPA-XXXX: <short-description>
  • Branch name follows the convention: <type>/NPA-XXXX-<short-description>
  • Commit messages follow the template: NPA-XXXX: <short-description>
  • All acceptance criteria from the Jira ticket are addressed
  • Automated tests (unit/integration/API/infrastructure etc. tests) are added or updated
  • Assignees and appropriate labels (e.g. terraform, documentation) are added

👀 Reviewer Checklist

  • Changes meet the acceptance criteria of the Jira ticket
  • Code is able to be merged (no conflicts and adheres to coding standards)
  • Sufficient test evidence is provided (manual and/or automated)
  • Infrastructure/operational/build changes are validated (if applicable)

🚀 Post-merge

After merging and deploying changes to the sandbox, Postman collection or spec examples please run the Run Postman
collection workflow.

This will run the tests within the collection to check that the sandbox is working as expected once deployed.

@github-actions

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5565

@ChristopherBacon ChristopherBacon added the OAS Updated the OpenAPI Specification (OAS) label Sep 25, 2025
@ChristopherBacon ChristopherBacon self-assigned this Sep 25, 2025
@ChristopherBacon ChristopherBacon added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 25, 2025
@github-actions

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5565

@github-actions

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5565

@JackPlowman JackPlowman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ChristopherBacon ChristopherBacon merged commit 272d012 into master Sep 25, 2025
17 checks passed
@ChristopherBacon ChristopherBacon deleted the task/NPA-5565/amend-sandbox-test-scenarios branch September 25, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request OAS Updated the OpenAPI Specification (OAS)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants