Skip to content

NPA-5608: IOPS amendments for get consent and get consent ID #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LeoKHoward merged 24 commits into from
Nov 3, 2025
Merged

NPA-5608: IOPS amendments for get consent and get consent ID #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
e7b37e6
NPA-5608: mandatory fixes - remove id and patient see mandatory changes
ChristopherBacon Sep 26, 2025
ff21bec
NPA-5608: example changes and spec changes and postman changes
ChristopherBacon Sep 29, 2025
431a5f3
NPA-5608: postman change and spec update and examples update
ChristopherBacon Sep 29, 2025
a4d3f47
Merge branch 'master' into task/NPA-5608/consent-id-spec-fixes
ChristopherBacon Sep 29, 2025
6765c5d
Update specification/examples/responses/GET_Consent/single-mother-chi…
ChristopherBacon Oct 1, 2025
54a63c1
Update specification/examples/responses/GET_Consent/filtered-relation…
ChristopherBacon Oct 1, 2025
93c63b0
Update specification/examples/responses/GET_Consent/filtered-relation…
ChristopherBacon Oct 1, 2025
3338085
Update specification/examples/responses/GET_Consent/multiple-relation…
ChristopherBacon Oct 1, 2025
5930b1f
Update specification/examples/responses/GET_Consent/multiple-relation…
ChristopherBacon Oct 1, 2025
9b816a9
Update specification/examples/responses/GET_Consent/multiple-relation…
ChristopherBacon Oct 1, 2025
14c43fc
Update specification/examples/responses/GET_Consent/multiple-relation…
ChristopherBacon Oct 1, 2025
5be9d8b
Update specification/examples/responses/GET_Consent/multiple-relation…
ChristopherBacon Oct 1, 2025
99d52ef
Update specification/examples/responses/GET_Consent/multiple-relation…
ChristopherBacon Oct 1, 2025
f28a9eb
Update specification/examples/responses/GET_Consent/multiple-relation…
ChristopherBacon Oct 1, 2025
cc27962
Update specification/examples/responses/GET_Consent/multiple-relation…
ChristopherBacon Oct 1, 2025
cb9bc88
Update specification/examples/responses/GET_Consent/single-consenting…
ChristopherBacon Oct 1, 2025
a4855c4
NPA-5608: remove spacing from examples data
ChristopherBacon Oct 1, 2025
f7bc425
Merge branch 'task/NPA-5608/consent-id-spec-fixes' of https://github.…
ChristopherBacon Oct 1, 2025
82a2e83
NPA-5608: updated specs from commit recommendations
ChristopherBacon Oct 1, 2025
39bd841
NPA-5608: minor schema tweaks
ChristopherBacon Oct 1, 2025
c302cf6
NPA-6508: minor generalPractitioner schema fix
ChristopherBacon Oct 1, 2025
d9d26e5
Merge branch 'master' into task/NPA-5608/consent-id-spec-fixes
ChristopherBacon Oct 1, 2025
9808541
Merge branch 'master' into task/NPA-5608/consent-id-spec-fixes
ellie-bound1-NHSD Nov 3, 2025
5dc8306
NPA-5608: Update postman collection with latest master
ellie-bound1-NHSD Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
228 changes: 84 additions & 144 deletions postman/Validated Relationship Service Sandbox.postman_collection.json
View file
Open in desktop

Large diffs are not rendered by default.

65 changes: 29 additions & 36 deletions .../examples/responses/GET_Consent/filtered-relationships-status-active-include-details.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,18 +22,18 @@ ConsentMultipleRelationshipsStatusActiveIncludeDetailsBundle:
- system: "https://placeholder.fhir.nhs.uk/Id/local-gp-patient-identifier"
value: "ABC0000003"
patient:
type: Patient
identifier:
system: "https://fhir.nhs.uk/Id/nhs-number"
value: "9000000017"
relationship:
- coding:
- system: "http://terminology.hl7.org/CodeSystem/v3-RoleCode"
code: PRN
display: parent
- system: "http://terminology.hl7.org/CodeSystem/v3-RoleCode"
code: MTH
display: mother
- system: "http://terminology.hl7.org/CodeSystem/v3-RoleCode"
code: PRN
display: parent
- coding:

Copilot AI Sep 29, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The role array structure is malformed. This line should be indented to align with the previous coding array entry within the same role object.

Copilot uses AI. Check for mistakes.

@ChristopherBacon ChristopherBacon Oct 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied indentation fixes from line 33

- system: "http://terminology.hl7.org/CodeSystem/v3-RoleCode"
code: MTH
display: mother
search:
mode: include
- fullUrl: "https://api.service.nhs.uk/validated-relationships/FHIR/R4/Patient/A3CC67E2"
Expand All @@ -51,8 +51,7 @@ ConsentMultipleRelationshipsStatusActiveIncludeDetailsBundle:
- system: "https://placeholder.fhir.nhs.uk/Id/local-gp-patient-identifier"
value: "ABC1234567"
name:
- id: "123456"
use: usual
- use: usual
period:
start: "2020-01-01"
end: "2021-12-31"
Expand All @@ -66,8 +65,7 @@ ConsentMultipleRelationshipsStatusActiveIncludeDetailsBundle:
- PhD
birthDate: "2022-10-22"
generalPractitioner:
- type: "Organization"
identifier:
- identifier:
value: "ODS12345"
system: "https://fhir.nhs.uk/Id/ods-organization-code"
search:
Expand Down Expand Up @@ -103,16 +101,15 @@ ConsentMultipleRelationshipsStatusActiveIncludeDetailsBundle:
uri: "REPLACE_WITH_LINK_TO_PUBLISHED_NATIONAL_PROXY_STANDARD"
provision:
actor:
- reference:
identifier:
system: https://fhir.nhs.uk/Id/nhs-number
value: "9000000017"
type: RelatedPerson
role:
coding:
- code: PRN
display: Parent
system: http://terminology.hl7.org/CodeSystem/v3-RoleCode
- reference:
identifier:
system: https://fhir.nhs.uk/Id/nhs-number
value: "9000000017"
role:
coding:
- code: PRN
display: Parent
system: http://terminology.hl7.org/CodeSystem/v3-RoleCode
period:
end: "2026-02-11"
start: "2025-02-11"
Expand All @@ -128,7 +125,6 @@ ConsentMultipleRelationshipsStatusActiveIncludeDetailsBundle:
- system: "https://placeholder.fhir.nhs.uk/Id/local-gp-patient-identifier"
value: "ABC0000003"
patient:
type: Patient
identifier:
system: "https://fhir.nhs.uk/Id/nhs-number"
value: "9000000005"
Expand All @@ -154,8 +150,7 @@ ConsentMultipleRelationshipsStatusActiveIncludeDetailsBundle:
- system: "https://placeholder.fhir.nhs.uk/Id/local-gp-patient-identifier"
value: "ABC9999999"
name:
- id: "123456"
use: usual
- use: usual
period:
start: "2020-01-01"
end: "2021-12-31"
Expand All @@ -166,8 +161,7 @@ ConsentMultipleRelationshipsStatusActiveIncludeDetailsBundle:
- Mrs
birthDate: "1995-10-22"
generalPractitioner:
- type: "Organization"
identifier:
- identifier:
value: "ODS12345"
system: "https://fhir.nhs.uk/Id/ods-organization-code"
search:
Expand Down Expand Up @@ -203,16 +197,15 @@ ConsentMultipleRelationshipsStatusActiveIncludeDetailsBundle:
uri: "REPLACE_WITH_LINK_TO_PUBLISHED_NATIONAL_PROXY_STANDARD"
provision:
actor:
- reference:
identifier:
system: https://fhir.nhs.uk/Id/nhs-number
value: "9000000017"
type: RelatedPerson
role:
coding:
- code: PRN
display: Parent
system: http://terminology.hl7.org/CodeSystem/v3-RoleCode
- reference:
identifier:
system: https://fhir.nhs.uk/Id/nhs-number
value: "9000000017"
role:
coding:
- code: PRN
display: Parent
system: http://terminology.hl7.org/CodeSystem/v3-RoleCode
period:
end: "2026-02-11"
start: "2025-02-11"
Expand Down
2 changes: 0 additions & 2 deletions specification/examples/responses/GET_Consent/filtered-relationships-status-inactive.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ ConsentMultipleRelationshipsStatusInactiveBundle:
identifier:
system: https://fhir.nhs.uk/Id/nhs-number
value: '9000000017'
type: RelatedPerson
role:
coding:
- code: PRN
Expand Down Expand Up @@ -91,7 +90,6 @@ ConsentMultipleRelationshipsStatusInactiveBundle:
identifier:
system: https://fhir.nhs.uk/Id/nhs-number
value: '9000000017'
type: RelatedPerson
role:
coding:
- code: PRN
Expand Down
4 changes: 0 additions & 4 deletions ...ication/examples/responses/GET_Consent/filtered-relationships-status-proposed-active.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ ConsentMultipleRelationshipsStatusProposedActiveBundle:
identifier:
system: https://fhir.nhs.uk/Id/nhs-number
value: '9000000017'
type: RelatedPerson
role:
coding:
- code: PRN
Expand Down Expand Up @@ -92,7 +91,6 @@ ConsentMultipleRelationshipsStatusProposedActiveBundle:
identifier:
system: https://fhir.nhs.uk/Id/nhs-number
value: '9000000017'
type: RelatedPerson
role:
coding:
- code: PRN
Expand Down Expand Up @@ -139,7 +137,6 @@ ConsentMultipleRelationshipsStatusProposedActiveBundle:
identifier:
system: https://fhir.nhs.uk/Id/nhs-number
value: '9000000017'
type: RelatedPerson
role:
coding:
- code: PRN
Expand Down Expand Up @@ -186,7 +183,6 @@ ConsentMultipleRelationshipsStatusProposedActiveBundle:
identifier:
system: https://fhir.nhs.uk/Id/nhs-number
value: '9000000017'
type: RelatedPerson
role:
coding:
- code: PRN
Expand Down
75 changes: 33 additions & 42 deletions specification/examples/responses/GET_Consent/multiple-relationships-include-patient.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@ ConsentMultipleRelationshipsIncludePatientBundle:
- system: "https://placeholder.fhir.nhs.uk/Id/local-gp-patient-identifier"
value: ABC1234567
name:
- id: "123456"
use: usual
- use: usual
period:
start: "2020-01-01"
end: "2021-12-31"
Expand All @@ -40,8 +39,7 @@ ConsentMultipleRelationshipsIncludePatientBundle:
- PhD
birthDate: "2022-10-22"
generalPractitioner:
- type: Organization
identifier:
- identifier:
value: ODS12345
system: "https://fhir.nhs.uk/Id/ods-organization-code"
search:
Expand Down Expand Up @@ -77,16 +75,15 @@ ConsentMultipleRelationshipsIncludePatientBundle:
uri: REPLACE_WITH_LINK_TO_PUBLISHED_NATIONAL_PROXY_STANDARD
provision:
actor:
- reference:
identifier:
system: https://fhir.nhs.uk/Id/nhs-number
value: "9000000022"
type: RelatedPerson
role:
coding:
- code: PRN
display: Parent
system: http://terminology.hl7.org/CodeSystem/v3-RoleCode
- reference:
identifier:
system: https://fhir.nhs.uk/Id/nhs-number
value: '9000000022'
role:
coding:
- code: PRN
display: Parent
system: http://terminology.hl7.org/CodeSystem/v3-RoleCode
period:
end: "2026-02-11"
start: "2025-02-11"
Expand All @@ -107,8 +104,7 @@ ConsentMultipleRelationshipsIncludePatientBundle:
- system: "https://placeholder.fhir.nhs.uk/Id/local-gp-patient-identifier"
value: ABC9999999
name:
- id: "123456"
use: usual
- use: usual
period:
start: "2020-01-01"
end: "2021-12-31"
Expand All @@ -119,8 +115,7 @@ ConsentMultipleRelationshipsIncludePatientBundle:
- Mrs
birthDate: "1995-10-22"
generalPractitioner:
- type: Organization
identifier:
- identifier:
value: ODS12345
system: "https://fhir.nhs.uk/Id/ods-organization-code"
search:
Expand Down Expand Up @@ -156,16 +151,15 @@ ConsentMultipleRelationshipsIncludePatientBundle:
uri: REPLACE_WITH_LINK_TO_PUBLISHED_NATIONAL_PROXY_STANDARD
provision:
actor:
- reference:
identifier:
system: https://fhir.nhs.uk/Id/nhs-number
value: "9000000022"
type: RelatedPerson
role:
coding:
- code: PRN
display: Parent
system: http://terminology.hl7.org/CodeSystem/v3-RoleCode
- reference:
identifier:
system: https://fhir.nhs.uk/Id/nhs-number
value: '9000000022'
role:
coding:
- code: PRN
display: Parent
system: http://terminology.hl7.org/CodeSystem/v3-RoleCode
period:
end: "2026-02-11"
start: "2025-02-11"
Expand All @@ -186,8 +180,7 @@ ConsentMultipleRelationshipsIncludePatientBundle:
- system: "https://placeholder.fhir.nhs.uk/Id/local-gp-patient-identifier"
value: ABC9999999
name:
- id: "123456"
use: usual
- use: usual
period:
start: "2020-01-01"
end: "2021-12-31"
Expand All @@ -198,8 +191,7 @@ ConsentMultipleRelationshipsIncludePatientBundle:
- Mr
birthDate: 1991-1-13
generalPractitioner:
- type: Organization
identifier:
- identifier:
value: ODS12345
system: "https://fhir.nhs.uk/Id/ods-organization-code"
search:
Expand Down Expand Up @@ -235,16 +227,15 @@ ConsentMultipleRelationshipsIncludePatientBundle:
uri: REPLACE_WITH_LINK_TO_PUBLISHED_NATIONAL_PROXY_STANDARD
provision:
actor:
- reference:
identifier:
system: https://fhir.nhs.uk/Id/nhs-number
value: "9000000022"
type: RelatedPerson
role:
coding:
- code: PRN
display: Parent
system: http://terminology.hl7.org/CodeSystem/v3-RoleCode
- reference:
identifier:
system: https://fhir.nhs.uk/Id/nhs-number
value: '9000000022'
role:
coding:
- code: PRN
display: Parent
system: http://terminology.hl7.org/CodeSystem/v3-RoleCode
period:
end: "2026-02-11"
start: "2025-02-11"
Expand Down
Loading