Skip to content

NPA-5534: OAS, Sandbox, and Postman updates for GET Questionnaire Response routing#262

Merged
ClarksonAdam merged 9 commits into
masterfrom
task/NPA-5534/update-get-questionnaire-response-path
Oct 15, 2025
Merged

NPA-5534: OAS, Sandbox, and Postman updates for GET Questionnaire Response routing#262
ClarksonAdam merged 9 commits into
masterfrom
task/NPA-5534/update-get-questionnaire-response-path

Conversation

@ClarksonAdam

Copy link
Copy Markdown
Contributor

Pull Request

🧾 Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-5534


📄 Description/Summary of Changes

  • Updated OAS to use path parameter instead of query parameter for GET Questionnaire Response
  • Update routing of GET Questionnaire Response in sandbox
  • Updated sandbox and postman tests to use new routing
  • Updated examples for OAS

🧪 Developer Testing Carried Out

  • Ran Postman collection and sandbox tests
  • Reviewed OAS following changes

🧪 Reviewer Testing Required

  • Review OAS
  • Run Postman and sandbox tests

✅ Developer Checklist

  • PR title follows the format: NPA-XXXX: <short-description>
  • Branch name follows the convention: <type>/NPA-XXXX/<short-description>
  • Commit messages follow the template: NPA-XXXX: <short-description>
  • All acceptance criteria from the Jira ticket are addressed
  • Automated tests (unit/integration/API/infrastructure etc. tests) are added or updated
  • Assignees and appropriate labels (e.g. terraform, documentation) are added

👀 Reviewer Checklist

  • Changes meet the acceptance criteria of the Jira ticket
  • Code is able to be merged (no conflicts and adheres to coding standards)
  • Sufficient test evidence is provided (manual and/or automated)
  • Infrastructure/operational/build changes are validated (if applicable)

🚀 Post-merge

After merging and deploying changes to the sandbox, Postman collection or spec examples please run the Run Postman
collection workflow.

This will run the tests within the collection to check that the sandbox is working as expected once deployed.

@ClarksonAdam ClarksonAdam self-assigned this Oct 10, 2025
@ClarksonAdam ClarksonAdam added bug Something isn't working postman Changes to the postman collection OAS Updated the OpenAPI Specification (OAS) labels Oct 10, 2025
@github-actions

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5534

@github-actions

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5534

@github-actions

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5534

Signed-off-by: adamclarkson <adam.clarkson1@nhs.net>
@github-actions

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5534

@github-actions

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5534

@ClarksonAdam ClarksonAdam marked this pull request as ready for review October 14, 2025 14:15
@github-actions

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5534

@github-actions

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5534

@github-actions

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5534

@ClarksonAdam

Copy link
Copy Markdown
Contributor Author

Had a call with @lelliott-hippo in which he provided the following feedback:

sandbox/api/app.py

  • get_questionnaire_response_id name might want the clarification
  • get_questionnaire_response_response unclear naming

@github-actions

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5534

@ClarksonAdam ClarksonAdam merged commit cab6ad1 into master Oct 15, 2025
17 checks passed
@ClarksonAdam ClarksonAdam deleted the task/NPA-5534/update-get-questionnaire-response-path branch October 15, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working OAS Updated the OpenAPI Specification (OAS) postman Changes to the postman collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants