Skip to content

NPA-5537: Add Default Legal Basis#264

Merged
LeoKHoward merged 15 commits into
masterfrom
task/NPA-5537/default-legal-basis
Nov 4, 2025
Merged

NPA-5537: Add Default Legal Basis#264
LeoKHoward merged 15 commits into
masterfrom
task/NPA-5537/default-legal-basis

Conversation

@LeoKHoward

@LeoKHoward LeoKHoward commented Oct 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Pull Request

🧾 Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-5537

📄 Description/Summary of Changes

  • New spec for unknown legal basis
  • Updated tests
  • Updated get_consent.py
  • Updated postman spec

🧪 Developer Testing Carried Out

  • Ran new test in postman

🧪 Reviewer Testing Required

✅ Developer Checklist

  • PR title follows the format: NPA-XXXX: <short-description>
  • Branch name follows the convention: <type>/NPA-XXXX/<short-description>
  • Commit messages follow the template: NPA-XXXX: <short-description>
  • All acceptance criteria from the Jira ticket are addressed
  • Automated tests (unit/integration/API/infrastructure etc. tests) are added or updated
  • Assignees and appropriate labels (e.g. terraform, documentation) are added

👀 Reviewer Checklist

  • Changes meet the acceptance criteria of the Jira ticket
  • Code is able to be merged (no conflicts and adheres to coding standards)
  • Sufficient test evidence is provided (manual and/or automated)
  • Infrastructure/operational/build changes are validated (if applicable)

🚀 Post-merge

After merging and deploying changes to the sandbox, Postman collection or spec examples please run the Run Postman
collection workflow.

This will run the tests within the collection to check that the sandbox is working as expected once deployed.

@LeoKHoward LeoKHoward self-assigned this Oct 30, 2025
@github-actions

github-actions Bot commented Oct 30, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5537

@github-actions

github-actions Bot commented Nov 3, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5537

@github-actions

github-actions Bot commented Nov 3, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5537

@github-actions

github-actions Bot commented Nov 3, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5537

@github-actions

github-actions Bot commented Nov 3, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5537

@github-actions

github-actions Bot commented Nov 3, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5537

@github-actions

github-actions Bot commented Nov 3, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5537

@github-actions

github-actions Bot commented Nov 4, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5537

@github-actions

github-actions Bot commented Nov 4, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5537

@LeoKHoward LeoKHoward added postman Changes to the postman collection OAS Updated the OpenAPI Specification (OAS) labels Nov 4, 2025
ellie-bound1-NHSD
ellie-bound1-NHSD reviewed Nov 4, 2025
View reviewed changes
Comment thread postman/Validated Relationship Service Sandbox.postman_collection.json
Comment thread sandbox/api/utils.py
Comment thread specification/validated-relationships-service-api.yaml Outdated
@github-actions

github-actions Bot commented Nov 4, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5537

@github-actions

github-actions Bot commented Nov 4, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5537

@github-actions

github-actions Bot commented Nov 4, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5537

ellie-bound1-NHSD
ellie-bound1-NHSD reviewed Nov 4, 2025
View reviewed changes
Comment thread specification/validated-relationships-service-api.yaml Outdated
@github-actions

github-actions Bot commented Nov 4, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5537

@github-actions

github-actions Bot commented Nov 4, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5537

@github-actions

github-actions Bot commented Nov 4, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5537

ellie-bound1-NHSD
ellie-bound1-NHSD approved these changes Nov 4, 2025
View reviewed changes

@ellie-bound1-NHSD ellie-bound1-NHSD left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@LeoKHoward LeoKHoward merged commit 54055c4 into master Nov 4, 2025
17 checks passed
@LeoKHoward LeoKHoward deleted the task/NPA-5537/default-legal-basis branch November 4, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ellie-bound1-NHSD ellie-bound1-NHSD ellie-bound1-NHSD approved these changes

Assignees

@LeoKHoward LeoKHoward

Labels

OAS Updated the OpenAPI Specification (OAS) postman Changes to the postman collection

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LeoKHoward @ellie-bound1-NHSD