Skip to content

NPA-5757: update schema for status and status reason description#266

Merged
ellie-bound1-NHSD merged 4 commits into
masterfrom
task/NPA-5757/update-schema-for-status-reason-and-status-examples
Nov 28, 2025
Merged

NPA-5757: update schema for status and status reason description#266
ellie-bound1-NHSD merged 4 commits into
masterfrom
task/NPA-5757/update-schema-for-status-reason-and-status-examples

Conversation

@ChristopherBacon

@ChristopherBacon ChristopherBacon commented Nov 18, 2025

Copy link
Copy Markdown
Contributor

Pull Request

🧾 Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-5757


📄 Description/Summary of Changes

  • Updated the examples and description for the PATCH /Consent/{id} endpoint to specify to supply statusReason along with status

🧪 Developer Testing Carried Out

  • Checked Swagger editor as docs changed

🧪 Reviewer Testing Required


✅ Developer Checklist

  • PR title follows the format: NPA-XXXX: <short-description>
  • Branch name follows the convention: <type>/NPA-XXXX/<short-description>
  • Commit messages follow the template: NPA-XXXX: <short-description>
  • All acceptance criteria from the Jira ticket are addressed
  • Automated tests (unit/integration/API/infrastructure etc. tests) are added or updated
  • Assignees and appropriate labels (e.g. terraform, documentation) are added

👀 Reviewer Checklist

  • Changes meet the acceptance criteria of the Jira ticket
  • Code is able to be merged (no conflicts and adheres to coding standards)
  • Sufficient test evidence is provided (manual and/or automated)
  • Infrastructure/operational/build changes are validated (if applicable)

🚀 Post-merge

After merging and deploying changes to the sandbox, Postman collection or spec examples please run the Run Postman
collection workflow.

This will run the tests within the collection to check that the sandbox is working as expected once deployed.

@github-actions

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5757

@ChristopherBacon

Copy link
Copy Markdown
Contributor Author

Image from Swagger editor for description:

image

@ChristopherBacon ChristopherBacon added the OAS Updated the OpenAPI Specification (OAS) label Nov 18, 2025
@ChristopherBacon ChristopherBacon changed the title NPA-5757: update schema for status and status reason description DRAFT NPA-5757: update schema for status and status reason description Nov 18, 2025
@ChristopherBacon ChristopherBacon changed the title DRAFT NPA-5757: update schema for status and status reason description NPA-5757: update schema for status and status reason description Nov 18, 2025

@ellie-bound1-NHSD ellie-bound1-NHSD left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good
Thinking we should update the example for postman collection as at mo status reason is TBC
https://github.com/NHSDigital/validated-relationships-service-api/blob/master/specification/examples/requests/PATCH_Consent/replace_status.yaml

@ChristopherBacon ChristopherBacon force-pushed the task/NPA-5757/update-schema-for-status-reason-and-status-examples branch from c8dc0fe to aa591d4 Compare November 27, 2025 15:26
@github-actions

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5757

@github-actions

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5757

@github-actions

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5757

@github-actions

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5757

@ellie-bound1-NHSD ellie-bound1-NHSD merged commit acd6564 into master Nov 28, 2025
17 checks passed
@ellie-bound1-NHSD ellie-bound1-NHSD deleted the task/NPA-5757/update-schema-for-status-reason-and-status-examples branch November 28, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OAS Updated the OpenAPI Specification (OAS)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants