Skip to content

NPA-6124: Add Free Text For Status Change#284

Merged
ChristopherBacon merged 17 commits into
masterfrom
story/NPA-6124/add-free-text-for-status-change-two
Jan 18, 2026
Merged

NPA-6124: Add Free Text For Status Change#284
ChristopherBacon merged 17 commits into
masterfrom
story/NPA-6124/add-free-text-for-status-change-two

Conversation

@LeoKHoward

@LeoKHoward LeoKHoward commented Jan 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Pull Request

🧾 Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-6124

📄 Description/Summary of Changes

  • Added grantor validation logic to ensure active proxy roles contain a valid ODS code in the grantor extension with correct FHIR structure and identifier system
  • Updated spec files
  • Updated sandbox code for relevant endpoints and added unit test scenarios

🧪 Developer Testing Carried Out

🧪 Reviewer Testing Required

✅ Developer Checklist

  • PR title follows the format: NPA-XXXX: <short-description>
  • Branch name follows the convention: <type>/NPA-XXXX/<short-description>
  • Commit messages follow the template: NPA-XXXX: <short-description>
  • All acceptance criteria from the Jira ticket are addressed
  • Automated tests (unit/integration/API/infrastructure etc. tests) are added or updated
  • Assignees and appropriate labels (e.g. terraform, documentation) are added

👀 Reviewer Checklist

  • Changes meet the acceptance criteria of the Jira ticket
  • Code is able to be merged (no conflicts and adheres to coding standards)
  • Sufficient test evidence is provided (manual and/or automated)
  • Infrastructure/operational/build changes are validated (if applicable)

🚀 Post-merge

After merging and deploying changes to the sandbox, Postman collection or spec examples please run the Run Postman
collection workflow.

This will run the tests within the collection to check that the sandbox is working as expected once deployed.

@LeoKHoward LeoKHoward self-assigned this Jan 7, 2026
@github-actions

github-actions Bot commented Jan 7, 2026

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6124

@github-actions

github-actions Bot commented Jan 7, 2026

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6124

@github-actions

github-actions Bot commented Jan 7, 2026

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6124

@github-actions

github-actions Bot commented Jan 7, 2026

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6124

@github-actions

github-actions Bot commented Jan 8, 2026

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6124

@github-actions

github-actions Bot commented Jan 8, 2026

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6124

@github-actions

github-actions Bot commented Jan 8, 2026

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6124

@LeoKHoward LeoKHoward added enhancement New feature or request python Pull requests that update Python code postman Changes to the postman collection endpoints labels Jan 9, 2026
@github-actions

github-actions Bot commented Jan 12, 2026

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6124

ellie-bound1-NHSD
ellie-bound1-NHSD reviewed Jan 13, 2026
View reviewed changes
Comment thread specification/examples/responses/GET_Consent/filtered-relationships-status-inactive.yaml
Comment thread specification/examples/responses/GET_Consent/multiple-relationships-include-patient.yaml Outdated
Comment thread ...ication/examples/responses/GET_Consent/multiple-relationships-include-performer-patient.yaml Outdated
Comment thread specification/examples/responses/GET_Consent/multiple-relationships-include-performer.yaml Outdated
Comment thread ...on/examples/responses/GET_Consent/multiple-relationships-single-patient-include-patient.yaml Outdated
Comment thread ...s/responses/GET_Consent/multiple-relationships-single-patient-include-performer-patient.yaml Outdated
Comment thread .../examples/responses/GET_Consent/multiple-relationships-single-patient-include-performer.yaml Outdated
Comment thread specification/examples/responses/GET_Consent/multiple-relationships-single-patient.yaml Outdated
Comment thread specification/examples/responses/GET_Consent/multiple-relationships.yaml Outdated
Comment thread specification/validated-relationships-service-api.yaml
@github-actions

github-actions Bot commented Jan 15, 2026

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6124

@github-actions

github-actions Bot commented Jan 16, 2026

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6124

@github-actions

github-actions Bot commented Jan 16, 2026

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6124

@github-actions

github-actions Bot commented Jan 16, 2026

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6124

@github-actions

github-actions Bot commented Jan 16, 2026

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6124

@github-actions

github-actions Bot commented Jan 16, 2026

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6124

@github-actions

github-actions Bot commented Jan 16, 2026

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6124

@ChristopherBacon ChristopherBacon merged commit 841314e into master Jan 18, 2026
17 checks passed
@ChristopherBacon ChristopherBacon deleted the story/NPA-6124/add-free-text-for-status-change-two branch January 18, 2026 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ellie-bound1-NHSD ellie-bound1-NHSD Awaiting requested review from ellie-bound1-NHSD

1 more reviewer

@ChristopherBacon ChristopherBacon ChristopherBacon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@LeoKHoward LeoKHoward

Labels

endpoints enhancement New feature or request postman Changes to the postman collection python Pull requests that update Python code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LeoKHoward @ChristopherBacon @ellie-bound1-NHSD @ClarksonAdam