Skip to content

NPA-6130: post consent IOPS changes#292

Merged
ChristopherBacon merged 26 commits into
masterfrom
task/NPA-6130/post-consent-iops-changes
Jan 26, 2026
Merged

NPA-6130: post consent IOPS changes#292
ChristopherBacon merged 26 commits into
masterfrom
task/NPA-6130/post-consent-iops-changes

Conversation

@ChristopherBacon

@ChristopherBacon ChristopherBacon commented Jan 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Pull Request

🧾 Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-6130

📄 Description/Summary of Changes

  • Postman changes
  • Specification examples updates

🧪 Developer Testing Carried Out

🧪 Reviewer Testing Required

  • Postman collection Sandbox
  • Postman collection Integration
  • Check Spec works

✅ Developer Checklist

  • PR title follows the format: NPA-XXXX: <short-description>
  • Branch name follows the convention: <type>/NPA-XXXX/<short-description>
  • Commit messages follow the template: NPA-XXXX: <short-description>
  • All acceptance criteria from the Jira ticket are addressed
  • Automated tests (unit/integration/API/infrastructure etc. tests) are added or updated
  • Assignees and appropriate labels (e.g. terraform, documentation) are added

👀 Reviewer Checklist

  • Changes meet the acceptance criteria of the Jira ticket
  • Code is able to be merged (no conflicts and adheres to coding standards)
  • Sufficient test evidence is provided (manual and/or automated)
  • Infrastructure/operational/build changes are validated (if applicable)

🚀 Post-merge

After merging and deploying changes to the sandbox, Postman collection or spec examples please run the Run Postman
collection workflow.

This will run the tests within the collection to check that the sandbox is working as expected once deployed.

@github-actions

github-actions Bot commented Jan 13, 2026

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6130

@github-actions

github-actions Bot commented Jan 13, 2026

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6130

@ChristopherBacon ChristopherBacon changed the title DRAFT NPA-6130: post consent iops changes DRAFT NPA-6130: post consent IOPS changes Jan 13, 2026
@ChristopherBacon ChristopherBacon self-assigned this Jan 13, 2026
@ChristopherBacon ChristopherBacon added the OAS Updated the OpenAPI Specification (OAS) label Jan 13, 2026
@github-actions

github-actions Bot commented Jan 16, 2026

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6130

@github-actions

github-actions Bot commented Jan 16, 2026

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6130

@github-actions

github-actions Bot commented Jan 16, 2026

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6130

@ChristopherBacon ChristopherBacon added the postman Changes to the postman collection label Jan 16, 2026
@github-actions

github-actions Bot commented Jan 16, 2026

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6130

@github-actions

github-actions Bot commented Jan 16, 2026

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6130

@github-actions

github-actions Bot commented Jan 16, 2026

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6130

@github-actions

github-actions Bot commented Jan 16, 2026

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6130

@github-actions

github-actions Bot commented Jan 16, 2026

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6130

@github-actions

github-actions Bot commented Jan 18, 2026

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6130

@ChristopherBacon ChristopherBacon force-pushed the task/NPA-6130/post-consent-iops-changes branch from 565cf99 to b669a9b Compare January 18, 2026 23:07
@ChristopherBacon ChristopherBacon force-pushed the task/NPA-6130/post-consent-iops-changes branch from 3f240f3 to 462616e Compare January 20, 2026 17:23
@ClarksonAdam ClarksonAdam changed the title DRAFT NPA-6130: post consent IOPS changes NPA-6130: post consent IOPS changes Jan 22, 2026
ClarksonAdam
ClarksonAdam requested changes Jan 22, 2026
View reviewed changes

@ClarksonAdam ClarksonAdam left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got a couple of questions that I've added on here.

I haven't yet reviewed the files with merge conflicts. However, I can help you to resolve them.

Comment thread specification/examples/requests/POST_Consent/adult_to_adult_proxy_creation.yaml Outdated
Comment thread ...n/examples/responses/GET_Consent/single-consenting-adult-relationship-include-performer.yaml Outdated
@github-actions

github-actions Bot commented Jan 23, 2026

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6130

@github-actions

github-actions Bot commented Jan 23, 2026

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6130

@github-actions

github-actions Bot commented Jan 23, 2026

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6130

ClarksonAdam
ClarksonAdam approved these changes Jan 23, 2026
View reviewed changes

@ClarksonAdam ClarksonAdam left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some minor fixes to the Postman collections.

I would like @ellie-bound1-NHSD to give this a once over on Monday given that I've now contributed to this PR

@ChristopherBacon ChristopherBacon merged commit 9322d93 into master Jan 26, 2026
14 of 15 checks passed
@ChristopherBacon ChristopherBacon deleted the task/NPA-6130/post-consent-iops-changes branch January 26, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ClarksonAdam ClarksonAdam ClarksonAdam approved these changes

@ellie-bound1-NHSD ellie-bound1-NHSD ellie-bound1-NHSD approved these changes

Assignees

@ChristopherBacon ChristopherBacon

Labels

OAS Updated the OpenAPI Specification (OAS) postman Changes to the postman collection

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ChristopherBacon @ClarksonAdam @ellie-bound1-NHSD