Skip to content

Added drop-down for selecting environment map#37

Open
stymbhrdwj wants to merge 1 commit intoNJU-3DV:mainfrom
stymbhrdwj:stymbhrdwj-gui_relighting
Open

Added drop-down for selecting environment map#37
stymbhrdwj wants to merge 1 commit intoNJU-3DV:mainfrom
stymbhrdwj:stymbhrdwj-gui_relighting

Conversation

@stymbhrdwj
Copy link
Copy Markdown

Modified gui.py by adding a drop-down for changing environment map lighting. This allows us to visualize the relighting results on-the-fly in real-time. While global_light is correctly changed, there is no change to local_light when changing the environment map. Is this the desired behaviour?

Modified `gui.py` by adding a drop-down for changing environment map lighting. This allows us to visualize the relighting results on-the-fly in real-time. While `global_light` is correctly changed, there is no change to `local_light` when changing the environment map. Is this the desired behaviour?
@HarryPeverell
Copy link
Copy Markdown

Thanks for your great work!

I am reaching out with a question regarding the implementation of real-time ray tracing. Is it feasible to perform real-time rendering of ray tracing and display the results within the GUI? I am particularly interested in understanding the current limitations and potential solutions that might enable this technology to be more accessible and interactive.

Thank you for your time and consideration.

@ArisPan
Copy link
Copy Markdown

ArisPan commented Mar 19, 2025

Hello and thanks for your contribution!

I tried running gui_relighting.py for both DTU and NeRF Synthetic. I am getting two errors:

  1. NameError: name 'env_light' is not defined
C:\Users\user\miniconda3\envs\r3dg\lib
Rendering output/NeRF_Syn/chair/3dgs
cannot find env_light_checkpoint at output/NeRF_Syn/chair/3dgs\env_light_chkpnt30000.pth, and env light will be ignore.
Update visibility with raytracing.: 100%|████████████████████████████████████████████████| 4/4 [00:03<00:00,  1.25it/s]
Traceback (most recent call last):
  File "gui_relighting.py", line 434, in <module>
    "env_light": env_light,
NameError: name 'env_light' is not defined
  1. TypeError: render() got an unexpected keyword argument 'bake'
    The following error occurs with the offending line 434 from the previous error removed.
C:\Users\user\miniconda3\envs\r3dg\lib
Rendering output/NeRF_Syn/chair/3dgs
cannot find env_light_checkpoint at output/NeRF_Syn/chair/3dgs\env_light_chkpnt30000.pth, and env light will be ignore.
Update visibility with raytracing.: 100%|████████████████████████████████████████████████| 4/4 [00:07<00:00,  1.76s/it]
Traceback (most recent call last):
  File "gui_relighting.py", line 443, in <module>
    mode='pbr')
  File "gui_relighting.py", line 132, in __init__
    self.step()
  File "gui_relighting.py", line 185, in step
    render_pkg = self.render_fn(viewpoint_camera=self.custom_cam, **self.render_kwargs)
TypeError: render() got an unexpected keyword argument 'bake'

I have tried running with and without the -t flag and as mentioned, with both DTU and Nerf Synthetic. The cannot find env_light_checkpoint warning is also observed with gui.py which runs as expected. Do you have any recommendations on these issues? Could you add an example of running gui_relighting.py?

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants