Implement a fix_convolution method
#368
Open
+560
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Felix Hekhorn <felixhekhorn@users.noreply.github.com>
cschwan
requested changes
Jan 21, 2026
| self.channels = new_channels; | ||
| } | ||
|
|
||
| /// Fix one of the convolutions in the Grid and return a new Grid with lower convolution dimension. |
Contributor
There was a problem hiding this comment.
We should document that any scale part of the fixed convolution will not be varied anymore, only if it's part of any scale-logs; this might make scale-variations useless if one doesn't completely fix all convolutions dependent on that scale.
pineappl/src/grid.rs
Outdated
|
|
||
| let mut new_grid = Self::new( | ||
| self.bwfl.clone(), | ||
| self.orders.clone(), |
Contributor
There was a problem hiding this comment.
If we fix a FF and have logs dependent on a fragmentation scale, we should probably throw the corresponding orders (see the comment above).
Member
Author
There was a problem hiding this comment.
That's right! The orders should be re-arranged and/or merged if this is the case. I implemented to logic to do so in a69c3c0 and added a detailed documentation.
(Also addresses the point above)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR allows fixing one of the convolutions and return a new Grid with lower dimension. For eg. it can be used to convert a SIDIS grid into DIS. The method is tested (in pineappl/tests/drell_yan_lo.rs) and works.
TODO:
cc @vbertone