Skip to content

add to jcb-base.yaml.j2 #2036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nicholasesposito wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

add to jcb-base.yaml.j2 #2036

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98097db
add to jcb-base.yaml.j2
Jan 12, 2026
40fcf52
remove outer loop change
Jan 12, 2026
c98539a
Merge branch 'develop' into feature/aircraft_varbc_add
CoryMartin-NOAA Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions parm/atm/jcb-base.yaml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ atmosphere_obsdataout_suffix: "_{{ current_cycle | to_YMDH }}.nc"
atmosphere_obsbiasin_path: "{{DATA}}/obs/"
atmosphere_obsbiasin_prefix: "{{GPREFIX}}"
atmosphere_obsbiasin_suffix: ".satbias.nc"
atmosphere_obsbiasin_acft_suffix: ".acftbias.nc"
Copy link
Copy Markdown
Contributor

@RussTreadon-NOAA RussTreadon-NOAA Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parm/atm/jcb-base.yaml.j2 which I successfully tested on Hercules includes additional changes.

@@ -101,16 +101,20 @@ atmosphere_obsdataout_suffix: "_{{ current_cycle | to_YMDH
 }}.nc"
 atmosphere_obsbiasin_path: "{{DATA}}/obs/"
 atmosphere_obsbiasin_prefix: "{{GPREFIX}}"
 atmosphere_obsbiasin_suffix: ".satbias.nc"
+atmosphere_obsbiasin_acft_suffix: ".acftbias.nc"
 atmosphere_obstlapsein_prefix: "{{GPREFIX}}"
 atmosphere_obstlapsein_suffix: ".tlapse.txt"
 atmosphere_obsbiascovin_prefix: "{{GPREFIX}}"
 atmosphere_obsbiascovin_suffix: ".satbias_cov.nc"
+atmosphere_obsbiascovin_acft_suffix: ".acftbias_cov.nc"

 atmosphere_obsbiasout_path: "{{DATA}}/bc/"
 atmosphere_obsbiasout_prefix: "{{APREFIX}}"
 atmosphere_obsbiasout_suffix: ".satbias.nc"
+atmosphere_obsbiasout_acft_suffix: ".acftbias.nc"
 atmosphere_obsbiascovout_prefix: "{{APREFIX}}"
 atmosphere_obsbiascovout_suffix: ".satbias_cov.nc"
+atmosphere_obsbiascovout_acft_suffix: ".acftbias_cov.nc"

 bias_files_dict:
     radiance_atms_n20: rad_varbc_params.tar
@@ -122,6 +126,7 @@ bias_files_dict:
     radiance_ssmis_f18: rad_varbc_params.tar
     radiance_cris-fsr_n20: rad_varbc_params.tar
     radiance_cris-fsr_npp: rad_varbc_params.tar
+    aircraft_temperature: acft_varbc_params.tar

 # Local Ensemble DA (LETKF)
 # -------------------------

The additional changes are

  1. define atmosphere_obsbiasout_acft_suffix for the output aircraft bias correction file
  2. define input and output suffixes for the aircraft bias correction covariance files. If JEDI can read and write aircraft bias correction coefficients and covariances from the same file, these additions are not necessary.
  3. add aircraft_temperature to point at the tarball containing aircraft bias correction files. For my tests the tarball contains two files: atmosphere_obsbiasin_acft and atmosphere_obsbiascovin_acft. If we only need a single files for both quantities, we don't need a tarball. However, in this case we will need to modify the python scripting which stages the bias correction data. It assumes it's working with tarballs.

Copy link
Copy Markdown
Collaborator Author

@nicholasesposito nicholasesposito Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. This makes sense.
  2. There are no acft covariance files but the code still requires there be a covariance file, so couldn't we just re-use the atmosphere_obsbiasin_acft and atmosphere_obsbiasout_acft ?
  3. Because we are merging all three aircraft yamls into one, we do not need aircraft_temperature anymore. They could just be called atmosphere. However if the point is to mention that it is specifically temperature correction, then sure we can keep "aircraft_temperature"

atmosphere_obstlapsein_prefix: "{{GPREFIX}}"
atmosphere_obstlapsein_suffix: ".tlapse.txt"
atmosphere_obsbiascovin_prefix: "{{GPREFIX}}"
Expand Down