Skip to content

Two combine-static updates#237

Merged
ceblanton merged 7 commits into
NOAA-GFDL:mainfrom
ceblanton:236.combine-statics
May 22, 2026
Merged

Two combine-static updates#237
ceblanton merged 7 commits into
NOAA-GFDL:mainfrom
ceblanton:236.combine-statics

Conversation

@ceblanton

@ceblanton ceblanton commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

Describe your changes

  1. For non-regridded cubed-sphere output, static pp file should be tiled
  2. Remove unneeded and problematic coordinates variable attribute from split-out static files before merging them into the static pp file.

Issue ticket number and link (if applicable)

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback
  • No print statements; all user-facing info uses logging module

Manual Pipeline Run Details

Was the manual pipeline (test_cloud_runner) triggered for this PR?

  • Yes
  • No

Result of manual pipeline run:

(Paste relevant logs, output, or a link to the workflow run here)

How to trigger the manual pipeline:

The test_cloud_runner pipeline is not automatically associated as a required check with the PR; it must be triggered to test changes in a full post-processing run.

To trigger the manual pipeline:

  1. Follow the link to the test_cloud_runner actions tab here

    • you should see "This workflow has a workflow_dispatch event trigger"
  2. Click the dropdown "Run workflow":

    a. If trying to merge from a branch on fre-workflows: choose branch from the first drop down, leave the next 2 inputs blank, and choose the fre-cli branch to test

    b. If trying to merge from a fre-workflows fork: can skip first branch selection, input the fork name (ex: [user]/fre-workflows), input the fork's branch name, and choose the fre-cli branch to test

  3. Click "Run workflow"

Note: you may need to reload the page to see your running workflow.

Also: remove coordinates variable attributes that prevent
'cdo merge' from working.
@singhd789 singhd789 linked an issue May 7, 2026 that may be closed by this pull request
Comment thread app/combine-statics/bin/combine-statics

@singhd789 singhd789 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you said mentioned a while ago that you were working on adding to a test, so I'll just comment for now. Other than that, I think this looks good to go!

ceblanton added 3 commits May 18, 2026 16:53
- combine-statics requires both nco and cdo
- synchronize ppan.cylc and ppan_test.cylc except for the epmt bits
@ceblanton ceblanton requested a review from singhd789 May 21, 2026 22:08
Comment thread site/ppan.cylc
Comment thread site/ppan_test.cylc
Comment thread site/ppan.cylc
@ceblanton ceblanton requested a review from singhd789 May 21, 2026 23:01

@singhd789 singhd789 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good!

@ceblanton ceblanton merged commit 553b7c1 into NOAA-GFDL:main May 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

two updates for combine-statics

2 participants