Skip to content

NGWPC PI 6 Delivery: Replace and Route#1146

Open
taddyb wants to merge 13 commits intoNOAA-OWP:tifrom
NGWPC:pi_6
Open

NGWPC PI 6 Delivery: Replace and Route#1146
taddyb wants to merge 13 commits intoNOAA-OWP:tifrom
NGWPC:pi_6

Conversation

@taddyb
Copy link
Copy Markdown

@taddyb taddyb commented Jul 9, 2025

Note: This PR coincides with NOAA-OWP/t-route#857 and is directly linked through the docker container in
hydrovis/Source/RnR/docker

It also enhances the features delivered from #1013

Details about this delivery can be found in the NGWPC delivery slides and the PR history

Additions

Adds support for the following items with Hydrovis to support RnR

  • ./start.sh
    • Starts all docker containers associated with RnR
  • ./run_ingest.sh
    • Pulls all weather.api forecasts into a RabbitMQ Queue
  • ./run_rnr.sh
    • Runs the troute-rnr module to calculate the flow
  • ./run_post_process.sh
    • generates the output.csv file

Removals

Changes

Testing

Screenshots

image

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

taddyb and others added 12 commits April 9, 2025 16:59
* moved message queue from hml_reader/ to Ingest/

* updating to reflect PR review from Quercus
#27)

* adding new docker development tools for RnR

* patch: error with the .venv file location

* patching error with volume mounts and venv paths

* fixed container warnings
* initial commit

* added notebook to explore geopackage and outputs

* updated output text

* added more notebooks

* updated mock data

* updating saved test data

* patch: adding missing dirs and a README.md
* adding test_rnr to test and removing venv from git update

* adding test_rnr to test

* removed traceback for cleaner github view

---------

Co-authored-by: root <root@U-1BVT2XY7DCIBM.nextgenwaterprediction.com>
Co-authored-by: taddyb <tkb5476@psu.edu>
* initial commit: updating wheels

* added docs for explaining RnR
@taddyb taddyb marked this pull request as ready for review July 10, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants