[DB] Update treasure index

[NORPG]

Summary by CodeRabbit

• Chores
  • Updated display names for treasure chests and quest references in the Highmountain zone with numeric identifiers to distinguish between duplicate items.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Numeric suffixes are appended to display names of treasure objects and quest entries in Highmountain zone data. Additionally, a previously commented quest entry is enabled with an updated annotation. No functional data or IDs are modified.

Changes

Cohort / File(s)	Change Summary
Quest Activation .contrib/Parser/DATAS/02 - Outdoor Zones/08 Broken Isles/Highmountain/Quests.lua	Quest entry q(40610) under HiddenQuestTriggers uncommented and comment updated with hint suffix "(25)"
Display Name Updates .contrib/Parser/DATAS/02 - Outdoor Zones/08 Broken Isles/Highmountain/Treasure Chests.lua	Numeric suffixes (e.g., "(19)", "(28)", "(37)") appended to 42 treasure object display names including Steamy Jewelry Box, Floating Treasure, Glimmering/Small/Standard Treasure Chests, and Highmountain Clan Chest
Metadata Annotations .contrib/Parser/DATAS/02 - Outdoor Zones/08 Broken Isles/Highmountain/Achievements.lua, .contrib/Parser/DATAS/17 - NYI/NYI Quests.lua	Trailing comments updated with numeric suffixes: quest 40612 comment annotated "(5)" in Achievements; quest 39507 name updated to include suffix "(34)" in NYI Quests

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• Large volume of homogeneous changes (42+ nearly identical display name updates with numeric suffixes)
• One simple quest activation (uncomment and update)
• Cosmetic/metadata-only modifications; no logic, IDs, coordinates, or functional data altered
• Repetitive pattern minimizes complexity despite file count

Poem

🐰 Numbered treasures, now they shine so bright,
Forty-two chests tagged with guiding light,
From "(19)" to "(43)" they're numbered neat,
Highmountain's bounty, organized so sweet! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title '[DB] Update treasure index' directly corresponds to the changeset, which updates treasure object names and quest data with numeric suffixes across multiple files in the Highmountain zone.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Docstrings were successfully generated.

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch index

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 53ad596 and ae2caa8.

📒 Files selected for processing (4)

• .contrib/Parser/DATAS/02 - Outdoor Zones/08 Broken Isles/Highmountain/Achievements.lua (1 hunks)
• .contrib/Parser/DATAS/02 - Outdoor Zones/08 Broken Isles/Highmountain/Quests.lua (1 hunks)
• .contrib/Parser/DATAS/02 - Outdoor Zones/08 Broken Isles/Highmountain/Treasure Chests.lua (4 hunks)
• .contrib/Parser/DATAS/17 - NYI/NYI Quests.lua (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (2)

.contrib/Parser/DATAS/02 - Outdoor Zones/08 Broken Isles/Highmountain/Quests.lua (2)

.contrib/Source Code/Parser/Framework/Framework.Processing.cs (2)

• Validate_Quest (1941-2027)
• Assign_QuestProviderFromData (3305-3343)

src/Classes/Quests.lua (1)

• QuestCompletionHelper (1066-1102)

.contrib/Parser/DATAS/02 - Outdoor Zones/08 Broken Isles/Highmountain/Treasure Chests.lua (1)

.contrib/Parser/DATAS/00 - Item DB/Classic Item Filter Overrides.lua (1)

• i (8-11)

🔇 Additional comments (4)

.contrib/Parser/DATAS/17 - NYI/NYI Quests.lua (1)

2062-2066: Highmountain treasure quest label update is safe and consistent.

The adjustment to the display text/comment for q(39507) is purely metadata under ROOTS.NeverImplemented, with no ID or structural changes, and matches the treasure indexing pattern used elsewhere. No issues from a data or runtime perspective.

.contrib/Parser/DATAS/02 - Outdoor Zones/08 Broken Isles/Highmountain/Quests.lua (1)

1172-1172: LGTM! Quest trigger enabled appropriately.

Enabling this hidden quest trigger for the treasure collection achievement tracking is consistent with the broader treasure indexing updates in this PR.

.contrib/Parser/DATAS/02 - Outdoor Zones/08 Broken Isles/Highmountain/Achievements.lua (1)

36-36: LGTM! Annotation update is consistent.

The numeric suffix addition aligns with the treasure indexing pattern applied throughout this PR.

.contrib/Parser/DATAS/02 - Outdoor Zones/08 Broken Isles/Highmountain/Treasure Chests.lua (1)

17-211: LGTM! Systematic treasure indexing applied correctly.

The numeric suffixes added to treasure display names are consistent and appear to implement a coordinated indexing system across 44 treasure-related objectives. The gaps in numbering (5, 25, 34) align with quest triggers referenced in the other files, indicating these positions correspond to non-treasure achievement criteria.

All functional data (IDs, coordinates, questIDs, rewards) remains unchanged—only display names are modified.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Caution

Docstrings generation - FAILED

No docstrings were generated.