fix: use .connected/.running from health output - #36
Open
NOVA-Openclaw wants to merge 1 commit into
Open
Conversation
openclaw health --json now exposes channel state via .connected and .running rather than .probe.ok. Update update_system() to map connected -> online, running -> idle, otherwise offline (with legacy .probe.ok fallback). Also update bot/team/latency field paths to the new channel-level structure while preserving legacy .probe.* fallbacks. Added redacted health fixture and test for the mapping behavior (including legacy probe fallback).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #35
Problem
openclaw health --jsonno longer returns channel state under.probe.ok. As of v2026.4 the channel objects expose:{ "channels": { "discord": { "connected": true, "running": true, "bot": { "username": "NOVA" } }, "signal": { "connected": null, "running": true }, "agent_chat": { "connected": null, "running": true } } }Because
update-dashboard.shstill looked for.probe.ok, every channel was rendered asoffline.Fix
Updated the jq transform in
update_system()to map:.connected == true→online.running == true(but not connected) →idleofflineBot/team/latency paths were also moved to the new channel-level structure (
.bot.username/.team.name). Legacy.probe.*fields are still honored as fallbacks so older health output formats continue to work.Verification
tests/fixtures/health-sample.jsoncovering online / idle / offline states.tests/test-issue-35.sh; all 13 assertions pass.openclaw health --jsonoutput; generatedsystem.jsonnow shows:discord/slack/telegram→onlinesignal/agent_chat→idletests/test-update-dashboard.shstill passes.Note: this deliberately does not address #27 (the agent_chat plugin probe); it simply prevents
agent_chatfrom being misreported as offline while that issue is worked separately.