NSEvent · NSEvent · Jul 4, 2026 · Jul 4, 2026 · Jul 4, 2026 · Jul 4, 2026
diff --git a/.Jules/palette.md b/.Jules/palette.md
@@ -25,3 +25,7 @@
 ## 2026-06-23 - [SwiftUI Button Accessibility]
 **Learning:** Found a pattern where SwiftUI icon-only buttons or minimal UI elements were given `.help()` modifiers for hover tooltips but lacked `.accessibilityLabel()` modifiers for screen readers.
 **Action:** When adding `.help()` to buttons, always pair it with a corresponding `.accessibilityLabel()` to ensure full accessibility.
+
+## 2026-07-04 - Dynamic Accessibility Labels in Lists
+**Learning:** In repeated lists with icon-only buttons (like Edit/Delete in `MacroListView` and `ScriptListView`), generic accessibility labels like "Edit" create a poor experience for screen reader users as they lack context of *what* is being edited.
+**Action:** When implementing lists with interactive actions, always ensure `accessibilityLabel` and `help` tooltips dynamically include the context (e.g., `item.name`) to disambiguate the action (e.g., "Edit My Macro").
diff --git a/XboxControllerMapper/XboxControllerMapper/Views/Macros/MacroListView.swift b/XboxControllerMapper/XboxControllerMapper/Views/Macros/MacroListView.swift
@@ -155,8 +155,8 @@ struct SharedMacroRow: View {
                     .foregroundColor(.accentColor)
             }
             .buttonStyle(.borderless)
-            .help("Edit in shared library")
-            .accessibilityLabel("Edit in shared library")
+            .help("Edit \(macro.name.isEmpty ? "Unnamed Macro" : macro.name) in shared library")
+            .accessibilityLabel("Edit \(macro.name.isEmpty ? "Unnamed Macro" : macro.name) in shared library")
         }
         .padding(.horizontal, 12)
         .padding(.vertical, 8)
@@ -206,16 +206,16 @@ struct MacroRow: View {
                         .foregroundColor(.accentColor)
                 }
                 .buttonStyle(.borderless)
-                .help("Edit")
-                .accessibilityLabel("Edit")
+                .help("Edit \(macro.name.isEmpty ? "Unnamed Macro" : macro.name)")
+                .accessibilityLabel("Edit \(macro.name.isEmpty ? "Unnamed Macro" : macro.name)")
 
                 Button(action: onDelete) {
                     Image(systemName: "trash")
                         .foregroundColor(.red.opacity(0.8))
                 }
                 .buttonStyle(.borderless)
-                .help("Delete")
-                .accessibilityLabel("Delete")
+                .help("Delete \(macro.name.isEmpty ? "Unnamed Macro" : macro.name)")
+                .accessibilityLabel("Delete \(macro.name.isEmpty ? "Unnamed Macro" : macro.name)")
             }
         }
         .padding(.horizontal, 12)

diff --git a/XboxControllerMapper/XboxControllerMapper/Views/Scripts/ScriptListView.swift b/XboxControllerMapper/XboxControllerMapper/Views/Scripts/ScriptListView.swift
@@ -222,16 +222,16 @@ struct ScriptRow: View {
                         .foregroundColor(.accentColor)
                 }
                 .buttonStyle(.borderless)
-                .help("Edit")
-                .accessibilityLabel("Edit")
+                .help("Edit \(script.name.isEmpty ? "Untitled Script" : script.name)")
+                .accessibilityLabel("Edit \(script.name.isEmpty ? "Untitled Script" : script.name)")
 
                 Button(action: onDelete) {
                     Image(systemName: "trash")
                         .foregroundColor(.red.opacity(0.8))
                 }
                 .buttonStyle(.borderless)
-                .help("Delete")
-                .accessibilityLabel("Delete")
+                .help("Delete \(script.name.isEmpty ? "Untitled Script" : script.name)")
+                .accessibilityLabel("Delete \(script.name.isEmpty ? "Untitled Script" : script.name)")
             }
         }
         .padding(.horizontal, 12)

diff --git a/patch_workflow.sh b/patch_workflow.sh
@@ -0,0 +1 @@
+sed -i.bak 's/tail -200/grep -E -A 5 -B 5 "XCTFail|failed|Failed|error:|Error:"/' .github/workflows/test.yml
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		sed -i.bak 's/tail -200/grep -E -A 5 -B 5 "XCTFail\|failed\|Failed\|error:\|Error:"/' .github/workflows/test.yml
coderabbitai Bot Jul 4, 2026 Copy link Copy Markdown Contributor Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. 🩺 Stability & Availability \| 🔴 Critical \| ⚡ Quick win 🧩 Analysis chain 🏁 Script executed: #!/bin/bash set -euo pipefail printf '\n== Files ==\n' git ls-files '.github/workflows/test.yml' 'patch_workflow.sh' printf '\n== patch_workflow.sh ==\n' cat -n patch_workflow.sh printf '\n== workflow excerpt ==\n' nl -ba .github/workflows/test.yml \| sed -n '1,120p' Repository: NSEvent/xbox-controller-mapper Length of output: 432 🏁 Script executed: #!/bin/bash set -euo pipefail printf '\n== workflow excerpt ==\n' sed -n '1,140p' .github/workflows/test.yml \| cat -n Repository: NSEvent/xbox-controller-mapper Length of output: 1365 Preserve the pipeline exit status here `grep -E -A 5 -B 5 "XCTFail\|failed\|Failed\|error:\|Error:"` exits `1` when there are no matches, and under `set -o pipefail` that makes a successful test run fail the whole `Run tests` step. Keep the last command returning `0` on the no-match path. 🤖 Prompt for AI Agents Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@patch_workflow.sh` at line 1, The test log filtering in patch_workflow.sh can return a nonzero status when no matches are found, which breaks the pipeline under pipefail. Update the grep-based replacement used for the Run tests output handling so the last command in that path still returns 0 when there are no matches, while preserving the existing XCTFail/failed/Error context filtering behavior.