🎨 Palette: Dynamic context for screen readers in list action buttons#79
🎨 Palette: Dynamic context for screen readers in list action buttons#79NSEvent wants to merge 4 commits into
Conversation
💡 What: Updated `.accessibilityLabel` for icon-only action buttons (Edit, Delete, Remove) across multiple list views (Macros, Scripts, Linked Apps, Linked Controllers, Chords, Gestures) to include the specific item's name dynamically. 🎯 Why: Screen reader users previously heard "Edit, button" or "Delete, button" repetitively without knowing which item the button belonged to. Injecting context directly into the label disambiguates the actions for VoiceOver users. ♿ Accessibility: Improved screen reader navigability and context by surfacing item names on actionable sub-elements. Used robust fallbacks (e.g. "Unnamed Macro") where names might be empty. Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
Next review available in: 2 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
💡 What: Fixed the compiler error caused by referencing `appInfo` outside of its `if let` scope in `LinkedAppsSheet.swift`. Used `appMonitor.appInfo(for: bundleId)` instead for the dynamic label. 🎯 Why: CI failed because `appInfo` was inaccessible for the `.accessibilityLabel` modifier on the Remove button. ♿ Accessibility: The button maintains the dynamic name for screen readers. Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
💡 What: Fixed the compiler error caused by referencing `appInfo` outside of its `if let` scope in `LinkedAppsSheet.swift`. Used `appMonitor.appInfo(for: bundleId)` instead for the dynamic label. 🎯 Why: CI failed because `appInfo` was inaccessible for the `.accessibilityLabel` modifier on the Remove button. ♿ Accessibility: The button maintains the dynamic name for screen readers. Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
💡 What: Fixed the compiler error caused by referencing `appInfo` outside of its `if let` scope in `LinkedAppsSheet.swift`. Used `appMonitor.appInfo(for: bundleId)` instead for the dynamic label. 🎯 Why: CI failed because `appInfo` was inaccessible for the `.accessibilityLabel` modifier on the Remove button. ♿ Accessibility: The button maintains the dynamic name for screen readers. Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
1 participant
🎨 Palette: Enhance Accessibility Labels for List Action Buttons
💡 What: Updated
.accessibilityLabelfor icon-only action buttons (Edit, Delete, Remove) across multiple list views (Macros, Scripts, Linked Apps, Linked Controllers, Chords, Gestures) to include the specific item's name dynamically.🎯 Why: Screen reader users previously heard "Edit, button" or "Delete, button" repetitively without knowing which item the button belonged to. Injecting context directly into the label disambiguates the actions for VoiceOver users.
♿ Accessibility: Improved screen reader navigability and context by surfacing item names on actionable sub-elements. Used robust fallbacks (e.g. "Unnamed Macro") where names might be empty.
PR created automatically by Jules for task 2473672353003735137 started by @NSEvent