[fix]開発中の機能を一番下に集約#2002
Merged
hikahana merged 2 commits intogm3/developfrom Mar 17, 2026
Merged
Conversation
hikahana
reviewed
Feb 9, 2026
| display: flex; | ||
| letter-spacing: 1px; | ||
| } | ||
| .dev-header { |
Contributor
There was a problem hiding this comment.
[must]
ここ間に一行改行して欲しい！
のと、dev-headerだとちょっと命名が悪いかも。開発中っていうのを示したいのは分かるけどdevだけだと開発用、本番用で分けているのかな？とかになりそう。で、おそらくこの命名ってヘッダーではなくてアコーディオンメニューであることを明記した方が良い気がするので↓みたいな命名とか？？これは一例だから何でも～
.sidebar-accordion
| { title: "会場割り当て", icon: "event_seat", click: "/assign_places" }, | ||
| { title: "ステージ割り当て", icon: "stadium", click: "/assign_stages" }, | ||
| ], | ||
| devOpen: false |
Contributor
There was a problem hiding this comment.
devOpenあまり好ましくないかも
フラグとしての管理を明記したいからisOpenedとか？devっていう単語はできるだけ避けたい開発用なのかと混合しちゃいそうだから！
| </li> | ||
| </ul> | ||
| </nav> | ||
| <!-- 開発中メニュー --> |
Comment on lines
+51
to
+66
| <nav class="menu"> | ||
| <ul> | ||
| <!-- 開発中メニュー（子） --> | ||
| <li | ||
| v-for="item in development_items" | ||
| :key="item.title" | ||
| v-show="devOpen" | ||
| class="dev-child" | ||
| > | ||
| <nuxt-link :to="item.click"> | ||
| <span class="material-icons">{{ item.icon }}</span> | ||
| {{ item.title }} | ||
| </nuxt-link> | ||
| </li> | ||
| </ul> | ||
| </nav> |
Contributor
There was a problem hiding this comment.
ちなみにvscodeでctrl + sの保存の際にlintかける設定とかしてる？
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
対応Issue
resolve #2000
概要
実装詳細
画面スクリーンショット等
テスト項目
備考