Conversation
Contributor
Author
|
表の上に出てきちゃうんですけどこれどこが悪いんですかね？
|
kkoike03
requested changes
May 6, 2018
| <td>メールアドレス</td> | ||
| </tr> | ||
| </tbody> | ||
| <%= @groups.each do |group| %> |
Contributor
There was a problem hiding this comment.
<%= は値をhtmlに埋め込むので，rubyコードを走らせたいだけのときは <% を使いましょう．
Contributor
Author
|
これでできてると思います |
kkoike03
approved these changes
May 7, 2018
kkoike03
reviewed
May 7, 2018
| </tr> | ||
| </tbody> | ||
| <% @groups.each do |group| %> | ||
| <% row_span = get_subrep_by_group(group.id).try(:length) %> |
Contributor
There was a problem hiding this comment.
get_subrep_by_group(group.id) や get_user_detail_by_group(group.user_id) で取得したデータを変数に格納してはどうでしょうか．
何回か同じメソッドを呼んでいますが引数が同じなので，一回取得して後はそれを使いまわすのが良いと思います．データベースに問い合わせする回数が減るので．
| <td>代表者</td> | ||
| <td><%= get_user_detail_by_group(group.user_id).first.name_ja %></td> | ||
| <td><%= get_user_detail_by_group(group.user_id).first.tel %></td> | ||
| <td><%= User.where(id:group.user_id).first.email %></td> |
Contributor
There was a problem hiding this comment.
アソシエーションを設定しているのでUserレコードはUserDetailレコードから引いてこれます．
user_detail = get_user_detail_by_group(group.user_id)
user = user_detail.user.email # これで参照できる
Contributor
There was a problem hiding this comment.
そもそも group から取ってこれますね
group.user.email
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
関連 #92
自分のローカルで既存のものも含めpdf出力ができません．