This repository was archived by the owner on Jul 3, 2023. It is now read-only.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intention of this PR is to harness the inbuilt backpressure feature of node streams, such that a slower browser connection would also slow down the websocket, such that we can simply pipe a
NUClearNetStreamto aWebSocketStreamand compose them with whatever other streams we might find useful.Currently broken because this line prevents any other messages being sent until an ack is received.
At this point I think we cannot rely on node as much as I would have liked, and need
WebSocketStreamto have its own adaptive throttling mechanism.