This repository was archived by the owner on Jul 3, 2023. It is now read-only.
Merged
Conversation
4d59557 to
fc74baa
Compare
BrendanAnnable
approved these changes
Mar 2, 2019
Member
There was a problem hiding this comment.
I had a bunch of tiny feedback items that would take a while to communicate via text, so I've just submitted a commit. It does:
- Remove the
divwrapper. - Simplify the styles to avoid relative/absolute positioning.
- Set the width/height on the SVG itself.
- Make the component a
PureComponentinstead of anobserver(since it doesn't take any observable values) - Remove the classname prop, and inline the props type
- Rename
style.csstostyles.css(and its local import variable)
If that LGTY then this PR LGTM 😄
Member
Author
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an an animated loading icon. Extracted from #234.
Stories:
https://nusight-pr-236.herokuapp.com/storybook/?selectedKind=components.loading_icon&selectedStory=renders%20animated&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybook%2Factions%2Factions-panel