This repository was archived by the owner on Jul 3, 2023. It is now read-only.
Merged
Conversation
BrendanAnnable
approved these changes
Mar 2, 2019
Member
BrendanAnnable
left a comment
BrendanAnnable
left a comment
There was a problem hiding this comment.
Feedback as a commit:
- Refactored to be a PureComponent
- Remove className prop
- Changed classNames usage to use
{ [styles.class]: boolean }syntax - Removed event from onClick callback
- Autoformatted
select/view.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a button component, with two styles: normal and primary.
Extracted from #234, for use in the Script Tuner, also update Select to use it.
Stories:
https://nusight-pr-237.herokuapp.com/storybook/?selectedKind=components.button&selectedStory=renders%20basic&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybook%2Factions%2Factions-panel