You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jul 3, 2023. It is now read-only.
The reason will be displayed to describe this comment to others. Learn more.
I'd like to kill the notion of view models for anything that isn't a complex tree (such as a three.js scene). For simple components like this we should be able to just use simple props like regular react.
This means the state should live outside the component and controlled by a parent store, which can be shared with the rest of the application 🙂
I'd like to kill the notion of view models for anything that isn't a complex tree (such as a three.js scene). For simple components like this we should be able to just use simple props like regular react.
This means the state should live outside the component and controlled by a parent store, which can be shared with the rest of the application
Makes sense 👍, will keep that in mind going forward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a component to select a single robot, using the Select component.
Extracted from #234, for use in the Script Tuner.
Stories:
https://nusight-pr-238.herokuapp.com/storybook/?selectedKind=components.robot_selector_single&selectedStory=renders%20empty&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybook%2Factions%2Factions-panel