Skip to content
This repository was archived by the owner on Jul 3, 2023. It is now read-only.

Add single robot selector#238

Merged
JosephusPaye merged 6 commits intomasterfrom
paye/robot_selector_single
Jun 17, 2019
Merged

Add single robot selector#238
JosephusPaye merged 6 commits intomasterfrom
paye/robot_selector_single

Conversation

@JosephusPaye
Copy link
Member

@JosephusPaye JosephusPaye commented Feb 20, 2019

@BrendanAnnable BrendanAnnable temporarily deployed to nusight-pr-238 February 20, 2019 09:07 Inactive
@BrendanAnnable BrendanAnnable temporarily deployed to nusight-pr-238 March 2, 2019 03:50 Inactive
BrendanAnnable
BrendanAnnable previously approved these changes Mar 2, 2019
Copy link
Member

@BrendanAnnable BrendanAnnable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to kill the notion of view models for anything that isn't a complex tree (such as a three.js scene). For simple components like this we should be able to just use simple props like regular react.

This means the state should live outside the component and controlled by a parent store, which can be shared with the rest of the application 🙂

@BrendanAnnable BrendanAnnable requested a deployment to nusight-pr-238 June 17, 2019 05:21 Abandoned
@JosephusPaye
Copy link
Member Author

I'd like to kill the notion of view models for anything that isn't a complex tree (such as a three.js scene). For simple components like this we should be able to just use simple props like regular react.

This means the state should live outside the component and controlled by a parent store, which can be shared with the rest of the application

Makes sense 👍, will keep that in mind going forward.

@JosephusPaye JosephusPaye merged commit 0b371a4 into master Jun 17, 2019
@BrendanAnnable BrendanAnnable deleted the paye/robot_selector_single branch January 15, 2020 22:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants