Skip to content

Fix security vuls - #741

Open
oyilmaz-nvidia wants to merge 3 commits into
mainfrom
onur/fix-sec-vul-multimodal
Open

Fix security vuls#741
oyilmaz-nvidia wants to merge 3 commits into
mainfrom
onur/fix-sec-vul-multimodal

Conversation

@oyilmaz-nvidia

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@oyilmaz-nvidia

Copy link
Copy Markdown
Contributor Author

/ok to test 4069c58

Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
@oyilmaz-nvidia

Copy link
Copy Markdown
Contributor Author

/ok to test 93cb8ce

Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
@oyilmaz-nvidia

Copy link
Copy Markdown
Contributor Author

/ok to test 0dd42e9

@chtruong814

Copy link
Copy Markdown
Contributor

This does not fully close the SSRF yet. validate_image_url() checks one IPv4 resolution before the fetch, but both downstream requests.get() calls re-resolve the hostname and follow redirects. A public URL that redirects to 169.254.169.254/loopback, or DNS rebinding/mixed DNS answers, can therefore bypass the check. Please make validation part of the fetch: resolve and reject all A/AAAA non-global addresses, pin the connection to the validated destination, and either disable redirects or revalidate every hop. Please add redirect, rebinding/multiple-answer, and IPv6 tests. The file:// oracle is addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants