Flag to disable moving files to run_<idx> directories on resume#15592
Open
Flag to disable moving files to run_<idx> directories on resume#15592
run_<idx> directories on resume#15592Conversation
Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>
nithinraok
reviewed
Apr 9, 2026
| # Move old log files into run_0/, run_1/, etc. subdirectories on resume. | ||
| # Disable on shared filesystems (e.g. Lustre) where moving files while other ranks | ||
| # are starting up can cause FileNotFoundError in Lightning's checkpoint scanner. | ||
| move_files_to_run_dirs: Optional[bool] = True |
Member
There was a problem hiding this comment.
shouldn;t this be handled while exiting the previous run safely?
Collaborator
Author
There was a problem hiding this comment.
no, it's not. the "move to run_X/" logic is triggered on start of new job. It has a race condition - every rank creates nemo_rankX_blabla.txt log file -> some ranks are faster, some are slower -> some rank is first listing the files, and then calling os.stat on them -> between the two calls, rank0 moved the file to run_X -> os.stat fails with FileNotFoundError
Collaborator
There was a problem hiding this comment.
Let's default to False, we can rethink logging at a later date.
Member
|
/claude review |
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Flag to disable moving files to
run_<idx>directories on resume.Set to
Trueby default for backward compatibility.Collection: all
Changelog
run_<idx>directories on resume.Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information