fix(deps): pin NeMo Fabric to ATIF finalization SHA - #1177
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughNeMo Fabric Git references now use commit ChangesNeMo Fabric revision update
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Signed-off-by: Arpit Singh (SW-CLOUD) <arpsingh@nvidia.com>
01190ca to
444fa12
Compare
|
You can also consider upping the lower-bound in the evaluator sdk as well (packages/nemo_evaluator_sdk/pyproject.toml). Current value is |
Keep the uv.lock change fabric-pin-only so unrelated platform wheels are not churned. Signed-off-by: Arpit Singh (SW-CLOUD) <arpsingh@nvidia.com>
|
Addressed Sandy's feedback:
|
mmogallapalli
left a comment
There was a problem hiding this comment.
Like for evaluator could you also update it for the nemo agents plugin
plugins/nemo-agents/pyproject.toml
Propagate the evaluator-sdk nemo-fabric>=0.1.1 floor into the SDK wrapper and nemo-platform package so lint-sdk-vendored / lint-cli stay clean. Signed-off-by: Arpit Singh (SW-CLOUD) <arpsingh@nvidia.com>
Match the evaluator-sdk floor bump so nemo-platform[services] installs resolve. Signed-off-by: Arpit Singh (SW-CLOUD) <arpsingh@nvidia.com>
Summary
Issue: Successful Fabric/Codex runs wrote ATIF on disk but omitted it from
RunResult.artifacts(NVBug 6562649), so Evaluator never gotrelay_atif/trace.Fix: Pin NeMo Fabric to released nemo-fabric 0.1.1 (tag
v0.1.1→ commite735338), which waits for Relay ATIF finalization before collecting artifacts.Fabric MR: NVIDIA/NeMo-Fabric#187
How fixed here: Retarget workspace
uv.sourcesgit pins (and lock /requirements-main.txt) from55450ff→e7353383024523179be6a009ef16dea223bea8c0. Declared floors unchanged.SHA / version verification
nemo-fabric==0.1.1→ GitHubv0.1.1→e735338uv lockresolvesnemo-fabric* v0.1.1 (e7353383)Changes
nemo-fabric*gitrevin rootpyproject.tomluv.lockandthird_party/requirements-main.txtType of Change
Quality Gates
Verification
Signed-off-by:traileruv run pre-commit run -apasses, or any blocked checks are identified belowTargeted validation:
uv lock→ resolvednemo-fabric* v0.1.1 (e7353383)18.23s):fabric_result.json: statussucceeded; artifacts includerelay_atofandrelay_atif(kind=atif, ATIF-v1.7, 2 steps)relay_atof,relay_atif, andtrace(format=atif, same path asrelay_atif); metrichas-trajectory= trueSummary by CodeRabbit