Skip to content

fix(deps): pin NeMo Fabric to ATIF finalization SHA - #1177

Merged
arpitsardhana merged 4 commits into
mainfrom
fix-fabric-relay-atif-pin/arpsingh
Aug 7, 2026
Merged

fix(deps): pin NeMo Fabric to ATIF finalization SHA#1177
arpitsardhana merged 4 commits into
mainfrom
fix-fabric-relay-atif-pin/arpsingh

Conversation

@arpitsardhana

@arpitsardhana arpitsardhana commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Summary

Issue: Successful Fabric/Codex runs wrote ATIF on disk but omitted it from RunResult.artifacts (NVBug 6562649), so Evaluator never got relay_atif / trace.

Fix: Pin NeMo Fabric to released nemo-fabric 0.1.1 (tag v0.1.1 → commit e735338), which waits for Relay ATIF finalization before collecting artifacts.
Fabric MR: NVIDIA/NeMo-Fabric#187

How fixed here: Retarget workspace uv.sources git pins (and lock / requirements-main.txt) from 55450ffe7353383024523179be6a009ef16dea223bea8c0. Declared floors unchanged.

SHA / version verification

Changes

  • Update 7× nemo-fabric* git rev in root pyproject.toml
  • Refresh uv.lock and third_party/requirements-main.txt

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with documentation updates
  • Documentation only
  • Contributor tooling or automation
  • CI, build, or test infrastructure

Quality Gates

  • Tests added or updated for changed behavior
  • Existing tests cover changed behavior — justification:
  • Tests not applicable — justification: dependency pin/lock only; no platform code changes
  • Documentation updated for user-visible behavior
  • Documentation not applicable — justification: pin/lock only

Verification

  • Pull request title follows the repository's Conventional Commit format
  • Every commit includes an appropriate Signed-off-by: trailer
  • uv run pre-commit run -a passes, or any blocked checks are identified below
  • Targeted tests pass, or tests are marked not applicable above
  • No secrets, API keys, or credentials are included

Targeted validation:

  • uv lock → resolved nemo-fabric* v0.1.1 (e7353383)
  • Live ATIF contract test PASSED (18.23s):
    packages/nemo_evaluator_sdk/tests/agent_eval/test_fabric_integration.py::test_fabric_codex_live_eval_captures_atif_trajectory
    
  • Inspected trial fabric_result.json: status succeeded; artifacts include relay_atof and relay_atif (kind=atif, ATIF-v1.7, 2 steps)
  • Evaluator evidence exposes relay_atof, relay_atif, and trace (format=atif, same path as relay_atif); metric has-trajectory = true

Summary by CodeRabbit

  • Updates
    • Updated NeMo Fabric integrations to a newer revision across supported workspace components.
    • Raised the minimum supported NeMo Fabric version to 0.1.1.
    • Included compatibility fixes for ATIF finalization and workspace source overrides.
    • Updated SDK, platform, and installation requirements to keep related components aligned.
    • Refreshed integrations for the core package and supported runtime and adapter components.

@arpitsardhana
arpitsardhana requested review from a team as code owners August 7, 2026 18:35
@github-actions github-actions Bot added the fix label Aug 7, 2026
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c89b1c49-5c3f-4dd7-beb2-c17d23558fb5

📥 Commits

Reviewing files that changed from the base of the PR and between c7ed699 and 865bb11.

📒 Files selected for processing (1)
  • .github/wheel-constraints/nemo-platform-services.txt

📝 Walkthrough

Walkthrough

NeMo Fabric Git references now use commit e7353383024523179be6a009ef16dea223bea8c0. SDK, platform, and wheel constraints now require NeMo Fabric 0.1.1.

Changes

NeMo Fabric revision update

Layer / File(s) Summary
Update NeMo Fabric revisions and requirements
pyproject.toml, third_party/requirements-main.txt, packages/nemo_evaluator_sdk/pyproject.toml, packages/nemo_platform/pyproject.toml, .github/wheel-constraints/nemo-platform-services.txt
Git references now use commit e7353383024523179be6a009ef16dea223bea8c0. Package requirements and wheel constraints now require NeMo Fabric 0.1.1. Existing package names, repositories, subdirectories, markers, and upper bounds remain unchanged.

Possibly related PRs

Suggested reviewers: gabwow, ajaythorve, anuradhakaruppiah

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main dependency pinning change and its ATIF finalization purpose.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-fabric-relay-atif-pin/arpsingh

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 31626/40251 78.6% 63.2%
Integration Tests 18380/38186 48.1% 20.8%

Signed-off-by: Arpit Singh (SW-CLOUD) <arpsingh@nvidia.com>
Comment thread uv.lock
@SandyChapman

Copy link
Copy Markdown
Contributor

You can also consider upping the lower-bound in the evaluator sdk as well (packages/nemo_evaluator_sdk/pyproject.toml). Current value is "nemo-fabric>=0.1.0,<0.3.0"

Keep the uv.lock change fabric-pin-only so unrelated platform wheels are not churned.

Signed-off-by: Arpit Singh (SW-CLOUD) <arpsingh@nvidia.com>
@arpitsardhana

Copy link
Copy Markdown
Contributor Author

Addressed Sandy's feedback:

  • Raised packages/nemo_evaluator_sdk floors to nemo-fabric>=0.1.1,<0.3.0 (and matching fabric extra / hermes adapter).
  • Restored unrelated armv7l/ppc64le/s390x wheel churn out of uv.lock so the lock diff is fabric-pin-only.

@mmogallapalli mmogallapalli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like for evaluator could you also update it for the nemo agents plugin
plugins/nemo-agents/pyproject.toml

Propagate the evaluator-sdk nemo-fabric>=0.1.1 floor into the SDK wrapper
and nemo-platform package so lint-sdk-vendored / lint-cli stay clean.

Signed-off-by: Arpit Singh (SW-CLOUD) <arpsingh@nvidia.com>
Match the evaluator-sdk floor bump so nemo-platform[services] installs resolve.

Signed-off-by: Arpit Singh (SW-CLOUD) <arpsingh@nvidia.com>
@arpitsardhana
arpitsardhana requested a review from a team as a code owner August 7, 2026 20:21

@svvarom svvarom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arpitsardhana
arpitsardhana added this pull request to the merge queue Aug 7, 2026
Merged via the queue into main with commit f3d4a4f Aug 7, 2026
58 checks passed
@arpitsardhana
arpitsardhana deleted the fix-fabric-relay-atif-pin/arpsingh branch August 7, 2026 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants