chore: remove hardcoded parameters from nooa client - #1249
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe OpenAI model client no longer queries LiteLLM for reasoning capabilities or passes ChangesOpenAI reasoning configuration
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/run-inference/about.mdx`:
- Around line 316-318: Update the provider requirements guidance near the
`--default-extra-body` explanation to explicitly state that function-tool
requests may override `reasoning_effort` only with `"none"`, preventing
per-request non-`none` values that are rejected by the validation described near
line 303.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: aa95c11b-1042-402a-9cea-5131892890b5
📒 Files selected for processing (1)
docs/run-inference/about.mdx
Signed-off-by: Gaia Di Lorenzo <gdilorenzo@ethz.ch>
Signed-off-by: Gaia Di Lorenzo <gdilorenzo@ethz.ch>
Signed-off-by: Gaia Di Lorenzo <gdilorenzo@ethz.ch>
Signed-off-by: Gaia Di Lorenzo <gdilorenzo@ethz.ch>
b10cfb4 to
99932b4
Compare
Signed-off-by: Gaia Di Lorenzo <gdilorenzo@ethz.ch>
Summary
Remove hardcoded parameters from nooa client.
Why? Parameter "none" in reasoning was refused and raised an error.
Related Issue
There is currently no way to pass parameters configurations to the client model.
Changes
Type of Change
Quality Gates
Verification
Signed-off-by:traileruv run pre-commit run -apasses, or any blocked checks are identified belowTargeted validation:
Summary by CodeRabbit
Bug Fixes
Documentation
reasoning_effort.reasoning_efforttononefor a provider and how request-level settings interact with provider defaults.Tests