chore(studio): route cleanup, getNavItems - #1254
Open
nakolean wants to merge 1 commit into
Open
Conversation
Signed-off-by: Nicholas Kolean <nakolean@gmail.com>
Contributor
📝 WalkthroughWalkthroughSide-navigation construction moves from ChangesSide-navigation centralization
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
web/packages/studio/src/routes/groups/anonymizerRoutes.tsx (1)
53-63: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAdd focused tests for side navigation feature flags.
No direct tests cover the eight
get*SideNavItemsfactories. Cover enabled and disabled states, including dashboard/Copilot combinations.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@web/packages/studio/src/routes/groups/anonymizerRoutes.tsx` around lines 53 - 63, Add focused tests for all eight get*SideNavItems factories, covering enabled and disabled feature-flag states and the dashboard/Copilot combinations. Update tests for web/packages/studio/src/routes/groups/anonymizerRoutes.tsx:53-63, customizationRoutes.tsx:60-70, dashboardRoutes.tsx:48-58, dataDesignerRoutes.tsx:77-87, safeSynthesizerRoutes.tsx:65-75, jobRoutes.tsx:37-47, settingsRoutes.tsx:27-37, and virtualModelsRoutes.tsx:27-37; verify each factory returns the expected navigation item when enabled and an empty result when disabled, including the dashboard/Copilot-specific behavior.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@web/packages/studio/src/routes/groups/anonymizerRoutes.tsx`:
- Around line 53-63: Add focused tests for all eight get*SideNavItems factories,
covering enabled and disabled feature-flag states and the dashboard/Copilot
combinations. Update tests for
web/packages/studio/src/routes/groups/anonymizerRoutes.tsx:53-63,
customizationRoutes.tsx:60-70, dashboardRoutes.tsx:48-58,
dataDesignerRoutes.tsx:77-87, safeSynthesizerRoutes.tsx:65-75,
jobRoutes.tsx:37-47, settingsRoutes.tsx:27-37, and
virtualModelsRoutes.tsx:27-37; verify each factory returns the expected
navigation item when enabled and an empty result when disabled, including the
dashboard/Copilot-specific behavior.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 14550d62-2663-4a44-9b3d-2ca6959559fb
📒 Files selected for processing (18)
web/packages/studio/src/routes/WorkspaceLayout/WorkspaceSideNav.tsxweb/packages/studio/src/routes/groups/anonymizerRoutes.tsxweb/packages/studio/src/routes/groups/customizationRoutes.tsxweb/packages/studio/src/routes/groups/dashboardRoutes.tsxweb/packages/studio/src/routes/groups/dataDesignerRoutes.tsxweb/packages/studio/src/routes/groups/deploymentRoutes.tsxweb/packages/studio/src/routes/groups/evaluationRoutes.tsxweb/packages/studio/src/routes/groups/experimentRoutes.tsxweb/packages/studio/src/routes/groups/filesetRoutes.tsxweb/packages/studio/src/routes/groups/guardrailsRoutes.tsxweb/packages/studio/src/routes/groups/index.tsweb/packages/studio/src/routes/groups/intakeRoutes.tsxweb/packages/studio/src/routes/groups/jobRoutes.tsxweb/packages/studio/src/routes/groups/modelCompareRoutes.tsxweb/packages/studio/src/routes/groups/optimizerRoutes.tsxweb/packages/studio/src/routes/groups/safeSynthesizerRoutes.tsxweb/packages/studio/src/routes/groups/settingsRoutes.tsxweb/packages/studio/src/routes/groups/virtualModelsRoutes.tsx
Contributor
|
steramae-nvidia
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related Issue
Changes
Type of Change
Quality Gates
Verification
Signed-off-by:traileruv run pre-commit run -apasses, or any blocked checks are identified belowTargeted validation:
Summary by CodeRabbit