-
Notifications
You must be signed in to change notification settings - Fork 4
refactor(studio): move getTextWithCount to common #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aray12
wants to merge
10
commits into
main
Choose a base branch
from
refactor-string-util-to-common
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
19c34de
feat(studio): add client-side dataset quality checks on JSONL upload …
aray12 777669d
fix(studio): resolve lint errors in dataset quality validation (ASTD-73)
aray12 6533e28
fix(studio): scroll quality report into view on file validation (ASTD…
aray12 199f239
refactor(studio): move getTextWithCount to common
aray12 9357a5f
Merge remote-tracking branch 'origin/main' into refactor-string-util-…
aray12 a1c4ab3
fix
aray12 ecba934
fix
aray12 e1c5264
feedback
aray12 e4455b5
another one
aray12 9f60e7d
Merge branch 'main' into refactor-string-util-to-common
aray12 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| // SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| import { getTextWithCount } from '@nemo/common/src/utils/formatters'; | ||
|
|
||
| describe('#getTextWithCount', () => { | ||
| it('should return the correct text with count using default suffix', () => { | ||
| expect(getTextWithCount('test', 0)).toBe('0 tests'); | ||
| expect(getTextWithCount('test', 1)).toBe('1 test'); | ||
| expect(getTextWithCount('test', 2)).toBe('2 tests'); | ||
| }); | ||
|
|
||
| it('should return the correct text with count using plural', () => { | ||
| expect(getTextWithCount('entry', 0, 'entries')).toBe('0 entries'); | ||
| expect(getTextWithCount('entry', 1, 'entries')).toBe('1 entry'); | ||
| expect(getTextWithCount('entry', 2, 'entries')).toBe('2 entries'); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.