Skip to content

chore: remove ultimately unused docker build elements#293

Merged
crookedstorm merged 1 commit into
mainfrom
docker-cleanup/crookedstorm
Jun 12, 2026
Merged

chore: remove ultimately unused docker build elements#293
crookedstorm merged 1 commit into
mainfrom
docker-cleanup/crookedstorm

Conversation

@crookedstorm

@crookedstorm crookedstorm commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

I do not believe these items are actually used. Some don't build because source is missing to make them work. Removing.

Summary by CodeRabbit

  • Refactor

    • Removed legacy Customizer and FAISS GPU wheel build configurations from the Docker build system.
    • Consolidated GPU wheel builders and removed unused build groups for streamlined operations.
    • Removed Python 3.11 wheel support for mamba-ssm component.
  • Chores

    • Updated CI/CD workflow and documentation to reference simplified build targets.
    • Removed obsolete Docker build files for discontinued components.

Signed-off-by: Brooke Storm <brookes@nvidia.com>
@crookedstorm crookedstorm requested review from a team as code owners June 12, 2026 01:20
@github-actions github-actions Bot added the chore label Jun 12, 2026
@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 8cfffd55-caeb-46bf-8183-1f4e44ce118b

📥 Commits

Reviewing files that changed from the base of the PR and between 2e8878f and 589aafd.

📒 Files selected for processing (8)
  • .github/workflows/ci.yaml
  • docker-bake.hcl
  • docker/Dockerfile.nmp-customizer
  • docker/Dockerfile.nmp-customizer-tasks
  • docker/README.md
  • docker/base/Dockerfile.faiss-gpu-wheel
  • docker/base/Dockerfile.mamba-wheel
  • docker/base/Dockerfile.nmp-gpu-base-py312
💤 Files with no reviewable changes (4)
  • docker/Dockerfile.nmp-customizer
  • docker/base/Dockerfile.faiss-gpu-wheel
  • docker/base/Dockerfile.nmp-gpu-base-py312
  • docker/Dockerfile.nmp-customizer-tasks

📝 Walkthrough

Walkthrough

This PR removes Customizer training pipeline and FAISS GPU wheel build infrastructure from the Docker orchestration, including build variables, helper functions, groups, targets, and associated Dockerfiles. CI and documentation are updated to reference the consolidated automodel GPU wheel build instead.

Changes

Customizer and FAISS Infrastructure Removal

Layer / File(s) Summary
Bake configuration and helper function updates
docker-bake.hcl
Removes Customizer task and FAISS variables (CUSTOMIZER_TASKS_BASE_CONTEXT, BASE_TAG_CUSTOMIZER_TASKS, FAISS_VERSION, FAISS_CUDA_ARCHS), deletes get_faiss_wheel_image() helper, adds automodel_base_context() function for base-image resolution, clarifies BASE_REGISTRY documentation.
Build groups and target reorganization
docker-bake.hcl
Removes docker-amd64-only, gpu-wheels, and docker-customizer groups; eliminates customizer task base builders, FAISS GPU wheel target, and entire customizer training targets section; consolidates platform membership for amd64/arm64 builds.
Wheel builder adjustments
docker/base/Dockerfile.mamba-wheel, docker/base/Dockerfile.nmp-gpu-base-py312
Removes Python 3.11 wheel builder for mamba-ssm 2.3.0, updates causal-conv1d and mamba-ssm image documentation, removes placeholder example comment.
CI workflow and documentation updates
.github/workflows/ci.yaml, docker/README.md
Updates CI docker-bake-graph to target nmp-automodel-gpu-wheels instead of gpu-wheels; updates README bake example from docker-customizer to nmp-unsloth.

Possibly related PRs

Suggested labels

chore

Suggested reviewers

  • matthewgrossman
  • svvarom
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Title accurately summarizes the main change: removing unused Docker build elements (Customizer targets, FAISS wheel builder, legacy Dockerfiles, variables, and groups).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docker-cleanup/crookedstorm

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 19029/25222 75.4% 61.3%
Integration Tests 11024/23994 45.9% 20.4%

@crookedstorm crookedstorm added this pull request to the merge queue Jun 12, 2026
Merged via the queue into main with commit 5a973b1 Jun 12, 2026
49 checks passed
@crookedstorm crookedstorm deleted the docker-cleanup/crookedstorm branch June 12, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants