feat(release): declare publishable container images in release/assets.yaml#318
Open
a2bondar wants to merge 2 commits into
Open
feat(release): declare publishable container images in release/assets.yaml#318a2bondar wants to merge 2 commits into
a2bondar wants to merge 2 commits into
Conversation
….yaml The container list in release/assets.yaml is the single source of truth for which container images are eligible for release publishing. Platform-Deploy's Release Deploy Artifacts and Release Promote Public workflows read it from this repository at the release ref, so eligibility is version-pinned to the released commit. Declares the four Automodel images. Linear: AIREINF-216 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: abondarenko <abondarenko@nvidia.com>
📝 WalkthroughWalkthroughAdded container image eligibility configuration to ChangesContainer Image Release Eligibility
Release bundle metadata, workflow, and tests
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
|
…fest plan-assets reads the container list from release/assets.yaml (validated for non-empty, unique ids) and appends container-typed entries to the selected artifacts. The bundle metadata writer records them in release-manifest.json as metadata-only entries (type, id, version = release label; no path or checksum, since image bits are staged by Platform-Deploy from its dev registry at the bundle's source SHA). Containers ride along on every release regardless of release_scope. Linear: AIREINF-216 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: abondarenko <abondarenko@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes
release/assets.yamlthe single source of truth for which container images are eligible for release publishing, and records them as typed entries in the release bundle manifest — converging containers onto the existing release flow.container:list inrelease/assets.yaml(mirrors thesdk:list) declaring the four Automodel images:nmp-automodel-base,nmp-automodel-tasks,nmp-automodel-training,nmp-unsloth-training.release-bundle.yamlplan-assetsvalidates the list (non-empty, unique ids) and appends{"type": "container", "id": ...}entries to the selected artifacts. Containers ride along on every release;release_scopegoverns SDK selection only.write_release_bundle_metadata.pyrecords them inrelease-manifest.jsonas metadata-only entries (type, id, version = release label; no path or checksum — image bits are built and staged by Platform-Deploy from its dev registry at the bundle's source SHA). Unit tests extended (18 passing).Consumer side (NVIDIA-NeMo/Platform-Deploy#95):
release-bundle-receivedautomatically stages the declared containers after the SDK publish, reading this list at the release ref — so eligibility is version-pinned to the released commit. Public NGC promotion reads it at the release tag and stays manual.Merge order
Either order is safe: without the consumer PR, the manifest's container entries are recorded but unconsumed (the existing SDK publish plan filters
type == "sdk"); without this PR, the consumer's staging step no-ops with "no containers declared". The full flow activates when both land.Links
🤖 Generated with Claude Code