Skip to content

fix(models): hardcoded adapters sidecar img #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benmccown wants to merge 2 commits into
base: main
Choose a base branch
from
+58 −10
Open

fix(models): hardcoded adapters sidecar img #325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d7fa34
fix(models): hardcoded adapters sidecar img
benmccown Jun 12, 2026
6a39e3f
k8s backend too
benmccown Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions services/core/models/src/nmp/core/models/controllers/backends/docker/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,31 @@ class DockerBackendConfig(BaseModel):
description="BusyBox image tag used for helper containers.",
)

lora_sidecar_image_name: str = Field(
default="nmp-api",
description=(
"Image name (without registry/tag) used for the LoRA adapters sidecar container. "
"Registry and tag are taken from NMP_IMAGE_REGISTRY / NMP_IMAGE_TAG. "
"The sidecar is invoked via the lora_sidecar_command."
),
)

lora_sidecar_command: list[str] = Field(
default=["--sidecars", "adapters", "--port", "60830"],
description=(
"Command passed to the LoRA sidecar container. "
"Default uses the nmp-platform-runner entrypoint present in nmp-api. "
),
)

lora_sidecar_entrypoint: str = Field(
default="",
description=(
"Optional entrypoint override for the LoRA sidecar container. "
"Leave empty to use the image's default entrypoint (correct for nmp-api). "
),
)

# ==========================================================================
# PENDING timeout and crash loop detection
# ==========================================================================
Expand Down
6 changes: 4 additions & 2 deletions services/core/models/src/nmp/core/models/controllers/backends/docker/creation_reconciler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1082,7 +1082,7 @@ async def cleanup_and_error(status_message: str, error_details: dict) -> tuple[D

if view.lora_enabled:
cfg = get_platform_config()
image = get_qualified_image("nmp-api")
image = get_qualified_image(self._backend_config.lora_sidecar_image_name)
sidecar_envs = cfg.to_shared_envvars()
sidecar_envs.update(env_vars)
# The adapters sidecar is engine-agnostic: it downloads enabled LoRA
Expand All @@ -1105,7 +1105,7 @@ async def cleanup_and_error(status_message: str, error_details: dict) -> tuple[D
"image": image,
"name": f"{container_name}-sidecar",
"environment": sidecar_envs,
"command": ["--sidecars", "adapters", "--port", "60830"],
"command": self._backend_config.lora_sidecar_command,
"detach": True,
"volumes": {
state.volume_name: {"bind": "/model-store", "mode": "rw"},
Expand All @@ -1120,6 +1120,8 @@ async def cleanup_and_error(status_message: str, error_details: dict) -> tuple[D
"healthcheck": {"test": ["NONE"]},
"ports": {},
}
if self._backend_config.lora_sidecar_entrypoint:
sidecar_args["entrypoint"] = self._backend_config.lora_sidecar_entrypoint

self._assign_network(sidecar_args)

Expand Down
26 changes: 26 additions & 0 deletions services/core/models/src/nmp/core/models/controllers/backends/k8s_nim_operator/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,32 @@ class K8sNimOperatorConfig(BaseModel):
ge=1,
description="PEFT refresh interval in seconds (only used when lora_enabled is true)",
)
lora_sidecar_image_name: str = Field(
default="nmp-api",
description=(
"Image name (without registry/tag) for the LoRA adapters sidecar container. "
"Registry and tag are taken from the platform config (NMP_IMAGE_REGISTRY / NMP_IMAGE_TAG). "
"Override to 'nmp-automodel-tasks' for local dev when that image is already available "
"but nmp-api is not."
),
)
lora_sidecar_command: list[str] = Field(
default=["nemo", "services", "run", "--sidecars", "adapters"],
description=(
"Kubernetes container command (entrypoint) for the LoRA sidecar. "
"Default uses the nmp-platform-runner entrypoint present in nmp-api. "
"When using nmp-automodel-tasks set to ['python'] and set lora_sidecar_args to "
"['-m', 'nmp.core.models.sidecars.adapters.main']."
),
)
Comment on lines +47 to +55

@coderabbitai coderabbitai Bot Jun 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Add validation to prevent empty command list.

K8s container creation will fail if lora_sidecar_command is empty. Add min_length=1 validation to catch this at config time.

🛡️ Proposed fix 
 lora_sidecar_command: list[str] = Field(
     default=["nemo", "services", "run", "--sidecars", "adapters"],
+    min_length=1,
     description=(
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@services/core/models/src/nmp/core/models/controllers/backends/k8s_nim_operator/config.py`
around lines 47 - 55, The lora_sidecar_command Field allows an empty list which
will cause Kubernetes container creation to fail; update the Field definition
for lora_sidecar_command to add validation by specifying min_length=1 in the
Field call so an empty list is rejected at config validation time (locate the
lora_sidecar_command variable in the config.py and add min_length=1 to its
Field(...) parameters).

lora_sidecar_args: list[str] = Field(
default=[],
description=(
"Kubernetes container args for the LoRA sidecar (appended after lora_sidecar_command). "
"Leave empty for nmp-api. "
"Set to ['-m', 'nmp.core.models.sidecars.adapters.main'] when using nmp-automodel-tasks."
),
)

# Security context
default_user_id: Optional[int] = Field(
Expand Down
11 changes: 3 additions & 8 deletions ...e/models/src/nmp/core/models/controllers/backends/k8s_nim_operator/nimservice_compiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,18 +362,13 @@ def compile_nimservice(
ContainerSpec(
name=_get_k8s_safe_name(resource_name, max_length=63, suffix="-lora-sidecar", name_type="label"),
image=Image(
repository=f"{platform_config.image_registry}/nmp-api",
repository=f"{platform_config.image_registry}/{backend_config.lora_sidecar_image_name}",
tag=platform_config.image_tag,
pullPolicy="IfNotPresent",
pullSecrets=image_pull_secrets if image_pull_secrets else None,
),
command=[
"nemo",
"services",
"run",
"--sidecars",
"adapters",
],
command=backend_config.lora_sidecar_command,
args=backend_config.lora_sidecar_args if backend_config.lora_sidecar_args else None,
env=sidecar_env_vars,
)
]
Expand Down
Loading