fix(studio): Align on a single test suffix pattern#327
Open
steramae-nvidia wants to merge 5 commits into
Open
Conversation
Signed-off-by: Sean Teramae <steramae@nvidia.com>
Signed-off-by: Sean Teramae <steramae@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (76)
💤 Files with no reviewable changes (7)
📝 WalkthroughWalkthroughPR enforces ChangesTest file naming standardization
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@web/packages/common/src/utils/search.spec.ts`:
- Line 4: Change the relative imports to the repository's absolute alias
imports: in search.spec.ts replace "import { buildApiSearchParam,
convertQueryToList, mergeURLSearchParams } from './search';" with the absolute
alias path that points to the same module (use the project's alias root for the
common utils), and in codeSnippet.spec.ts similarly replace the "./codeSnippet"
relative import with its absolute alias; ensure you import the same exported
symbols (buildApiSearchParam, convertQueryToList, mergeURLSearchParams and the
codeSnippet exports) using the correct alias so lint/CI no longer flags relative
paths.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: e208dc9c-89aa-4a98-8c6a-66df90e67be0
📒 Files selected for processing (45)
web/.agents/skills/test-coverage-improvement/SKILL.mdweb/packages/common/src/LabsPOC/dataset-file-utils.spec.tsweb/packages/common/src/components/CodeEditor/util/editor.spec.tsweb/packages/common/src/components/DataView/ColumnFilterPanel.spec.tsxweb/packages/common/src/components/DataView/FilterPanel/CustomFilter.spec.tsxweb/packages/common/src/components/DataView/FilterPanel/DateRangeFilter.spec.tsxweb/packages/common/src/components/DataView/FilterPanelToggle.spec.tsxweb/packages/common/src/components/DataView/StudioAppliedFilters.spec.tsxweb/packages/common/src/components/DataView/StudioDataView.spec.tsxweb/packages/common/src/components/Dial/index.spec.tsxweb/packages/common/src/components/RelativeTime/index.spec.tsxweb/packages/common/src/components/ScrollTable/index.spec.tsxweb/packages/common/src/components/SliderWithTextInput/SliderWithTextInput.spec.tsxweb/packages/common/src/components/StatusBadge/StatusBadge.spec.tsxweb/packages/common/src/components/TableHeaderButton/index.spec.tsxweb/packages/common/src/components/TagOverflowGroup/index.spec.tsxweb/packages/common/src/components/TrainingParameterSlider/TrainingParameterSlider.spec.tsxweb/packages/common/src/hooks/useQueryParams/index.spec.tsxweb/packages/common/src/hooks/useStudioDataViewState/index.spec.tsxweb/packages/common/src/hooks/useTableFilters/index.spec.tsxweb/packages/common/src/namedEntity.spec.tsweb/packages/common/src/utils/TraceQueue.spec.tsweb/packages/common/src/utils/codeSnippet.spec.tsweb/packages/common/src/utils/datasetQuality.spec.tsweb/packages/common/src/utils/file.spec.tsweb/packages/common/src/utils/fileValidation.spec.tsweb/packages/common/src/utils/filesetName.spec.tsweb/packages/common/src/utils/formatDateRange.spec.tsweb/packages/common/src/utils/isDefined.spec.tsweb/packages/common/src/utils/search.spec.tsweb/packages/common/src/utils/search.test.tsweb/packages/common/src/utils/useQueryFromSearchParams.spec.tsweb/packages/sdk/orval/githubTokenHeaders.spec.tsweb/packages/sdk/orval/operationNameOverride.spec.tsweb/packages/studio/src/components/FilterFields/SearchBaseModels.spec.tsxweb/packages/studio/src/components/dataViews/GuardrailsDataView/guardrailUtils.spec.tsweb/packages/studio/src/components/dataViews/SafeSynthesizerJobsDataView/DeleteJobModal.spec.tsxweb/packages/studio/src/components/dataViews/SafeSynthesizerJobsDataView/utils.spec.tsweb/packages/studio/src/constants/featureFlags/utils.spec.tsweb/packages/studio/src/routes/SafeSynthesizerJobDetailsRoute/util.spec.tsweb/packages/studio/src/routes/SafeSynthesizerListRoute/utils.spec.tsweb/packages/studio/src/routes/SafeSynthesizerNewRoute/components/AdvancedParameters.spec.tsxweb/packages/studio/src/routes/SafeSynthesizerNewRoute/index.spec.tsxweb/packages/studio/src/util/__tests__/tablePaginationSort.spec.tsweb/packages/studio/src/util/files.spec.ts
💤 Files with no reviewable changes (2)
- web/packages/common/src/utils/search.test.ts
- web/packages/studio/src/util/files.spec.ts
Contributor
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@web/packages/studio/e2e-tests/evaluation.spec.ts`:
- Line 176: The E2E test description strings currently reference "*.test.ts"
even though the files are named "*.spec.ts" (example: the projectDescription
constant in evaluation.spec.ts); update these description/template strings to
reference the correct ".spec.ts" filenames (or alternatively rename the test
files to use ".test.ts" consistently) so descriptions match actual
filenames—search for description variables like projectDescription in
evaluation.spec.ts and similar description constants in datasets.spec.ts,
customization, model-inference, model, project, and safeSynthesizer test files
and replace ".test.ts" with ".spec.ts" (or rename the files consistently) to
keep names aligned.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: b1f52aab-b4f6-4ece-82d7-237e012551bf
📒 Files selected for processing (236)
web/.agents/skills/test-coverage-improvement/SKILL.mdweb/.agents/skills/unit-test/SKILL.mdweb/AGENTS.mdweb/README.mdweb/packages/studio/e2e-tests/customization.spec.tsweb/packages/studio/e2e-tests/evaluation.spec.tsweb/packages/studio/e2e-tests/projects/datasets.spec.tsweb/packages/studio/e2e-tests/projects/model-inference.spec.tsweb/packages/studio/e2e-tests/projects/model.spec.tsweb/packages/studio/e2e-tests/projects/project.spec.tsweb/packages/studio/e2e-tests/safeSynthesizer.spec.tsweb/packages/studio/src/api/common/utils.test.tsweb/packages/studio/src/api/datasets/useDatasetFileContent.test.tsweb/packages/studio/src/api/evaluation/useEvaluationsWithMetrics.test.tsweb/packages/studio/src/api/evaluation/utils.test.tsweb/packages/studio/src/components/AccessibleTitle/index.test.tsxweb/packages/studio/src/components/BaseModelCard/BaseModelCard.test.tsxweb/packages/studio/src/components/CancelJobButton/index.test.tsxweb/packages/studio/src/components/CopyButton/index.test.tsxweb/packages/studio/src/components/CustomizationDetailsPanel/index.test.tsxweb/packages/studio/src/components/CustomizationFileUpload/index.test.tsxweb/packages/studio/src/components/CustomizationFilesetCreateModal/index.test.tsxweb/packages/studio/src/components/CustomizationFilesetDetailsPanel/index.test.tsxweb/packages/studio/src/components/CustomizationMetrics/index.test.tsxweb/packages/studio/src/components/CustomizeModelModal/index.test.tsxweb/packages/studio/src/components/DatasetCreateModal/index.test.tsxweb/packages/studio/src/components/DatasetFileManagementSidePanel/DatasetBreadcrumbs/index.test.tsxweb/packages/studio/src/components/DatasetFileManagementSidePanel/DatasetFileManagementSidePanelContainer.test.tsxweb/packages/studio/src/components/DatasetFileManagementSidePanel/hooks/useDatasetFileManagementState.test.tsweb/packages/studio/src/components/DatasetFileManagementSidePanel/index.test.tsxweb/packages/studio/src/components/DatasetFileUpload/index.test.tsxweb/packages/studio/src/components/DatasetInfoModal/index.test.tsxweb/packages/studio/src/components/DatasetInfoModal/util.test.tsweb/packages/studio/src/components/DatasetInputFile/DatasetInputFile.test.tsxweb/packages/studio/src/components/DatasetsTable/index.test.tsxweb/packages/studio/src/components/DeleteConfirmationModal/index.test.tsxweb/packages/studio/src/components/DetailRow/index.test.tsxweb/packages/studio/src/components/DocumentationButton/index.test.tsxweb/packages/studio/src/components/ErrorPanel/index.test.tsxweb/packages/studio/src/components/ExpandableMessage/index.test.tsxweb/packages/studio/src/components/FilesTable/FileQuickActions/index.test.tsxweb/packages/studio/src/components/FilesetCreateModal/index.test.tsxweb/packages/studio/src/components/FilesetFilePreviewPanel/FilesetFilePreviewContent/index.test.tsxweb/packages/studio/src/components/FilesetFilePreviewPanel/index.test.tsxweb/packages/studio/src/components/ImportFileContent/validation.test.tsweb/packages/studio/src/components/InfiniteScroll/index.test.tsxweb/packages/studio/src/components/IntakeAnnotationsPanel/index.test.tsxweb/packages/studio/src/components/IntakeSpansTable/index.test.tsxweb/packages/studio/src/components/IntakeTelemetryStatusBadge/index.test.tsxweb/packages/studio/src/components/IntakeTracesTable/index.test.tsxweb/packages/studio/src/components/Layouts/ErrorBoundary/index.test.tsxweb/packages/studio/src/components/Layouts/GlobalNav/index.test.tsxweb/packages/studio/src/components/Layouts/NavigationDrawer/index.test.tsxweb/packages/studio/src/components/Layouts/NotFound/index.test.tsxweb/packages/studio/src/components/Layouts/UnauthorizedWorkspace/index.test.tsxweb/packages/studio/src/components/ModelActionsMenu/index.test.tsxweb/packages/studio/src/components/ModelChat/index.test.tsxweb/packages/studio/src/components/ModelChatPanel/ModelChatPanel.test.tsxweb/packages/studio/src/components/NewCustomizationForm/FormSection.test.tsxweb/packages/studio/src/components/NewCustomizationForm/ModelSelectionSection.test.tsxweb/packages/studio/src/components/NewCustomizationForm/ParameterEfficiency.test.tsxweb/packages/studio/src/components/NewCustomizationForm/TrainingMethodSelect.test.tsxweb/packages/studio/src/components/NewCustomizationForm/utils.test.tsweb/packages/studio/src/components/NewDataDesignerJobForm/index.test.tsxweb/packages/studio/src/components/NewDataDesignerJobForm/previewApi.test.tsweb/packages/studio/src/components/NewDataDesignerJobForm/utils.test.tsweb/packages/studio/src/components/PromptTuningForm/ImportFromSourceActions/index.test.tsxweb/packages/studio/src/components/PromptTuningForm/InContextLearningSection/hooks/useSubmitICLsFile.test.tsweb/packages/studio/src/components/PromptTuningForm/InContextLearningSection/index.test.tsxweb/packages/studio/src/components/PromptTuningForm/ModelDetailsSection/index.test.tsxweb/packages/studio/src/components/PromptTuningForm/PromptTemplateSection/index.test.tsxweb/packages/studio/src/components/PromptTuningForm/ToolsSection/components/ToolMetadataPanel.test.tsxweb/packages/studio/src/components/QuickActionsMenu/QuickActionsMenuDefault/index.test.tsxweb/packages/studio/src/components/QuickActionsMenu/QuickActionsMenuRoot/index.test.tsxweb/packages/studio/src/components/SafeSynthesizerFilesetPreview/FilesetFilePreviewLink.test.tsxweb/packages/studio/src/components/SafeSynthesizerFilesetPreview/index.test.tsxweb/packages/studio/src/components/SafeSynthesizerFilesetPreview/util.test.tsweb/packages/studio/src/components/SafeSynthesizerNavigation/index.test.tsxweb/packages/studio/src/components/UserPopover/index.test.tsxweb/packages/studio/src/components/ValueWithLabel/index.test.tsxweb/packages/studio/src/components/agents/AgentBlockingInput/EvalConfigBlockingInput.test.tsxweb/packages/studio/src/components/agents/AgentBlockingInput/ModelSelectBlockingInput.test.tsxweb/packages/studio/src/components/agents/AgentDecisionInput/index.test.tsxweb/packages/studio/src/components/common/FilterToolbar/index.test.tsxweb/packages/studio/src/components/common/SearchBar/index.test.tsxweb/packages/studio/src/components/customizer/CustomizationFilesetSelect/FileValidationPanel/AutoSplitNotice.test.tsxweb/packages/studio/src/components/customizer/CustomizationFilesetSelect/FileValidationPanel/index.test.tsxweb/packages/studio/src/components/customizer/CustomizationFilesetSelect/index.test.tsxweb/packages/studio/src/components/customizer/CustomizationHyperparameters/ComputeResources.test.tsxweb/packages/studio/src/components/customizer/CustomizationHyperparameters/DpoParameters.test.tsxweb/packages/studio/src/components/customizer/CustomizationHyperparameters/GeneralParameters.test.tsxweb/packages/studio/src/components/customizer/CustomizationHyperparameters/LoraParameters.test.tsxweb/packages/studio/src/components/dataViews/AgentsDataView/index.test.tsxweb/packages/studio/src/components/dataViews/CustomModelsDataView/CustomizeModelButton/index.test.tsxweb/packages/studio/src/components/dataViews/CustomModelsDataView/index.test.tsxweb/packages/studio/src/components/dataViews/DeploymentsDataView/index.test.tsxweb/packages/studio/src/components/dataViews/GuardrailsDataView/GuardrailsDataView.test.tsxweb/packages/studio/src/components/dataViews/InferenceProvidersDataView/index.test.tsxweb/packages/studio/src/components/dataViews/JobsDataView/index.test.tsxweb/packages/studio/src/components/dataViews/SecretsDataView/index.test.tsxweb/packages/studio/src/components/evaluation/ButtonLaunchEvaluation.test.tsxweb/packages/studio/src/components/evaluation/Configurations/form/InputFile.test.tsxweb/packages/studio/src/components/evaluation/Configurations/form/MetricsCheckboxes.test.tsxweb/packages/studio/src/components/evaluation/Configurations/form/StringCheckInput.test.tsxweb/packages/studio/src/components/evaluation/EvalCard/index.test.tsxweb/packages/studio/src/components/evaluation/EvaluationModelSelect.test.tsxweb/packages/studio/src/components/evaluation/Jobs/ActionMenu.test.tsxweb/packages/studio/src/components/evaluation/Jobs/ComparisonPanel.test.tsxweb/packages/studio/src/components/evaluation/Jobs/DetailsPanel.test.tsxweb/packages/studio/src/components/evaluation/Jobs/EvaluationJobBulkDeleteModal.test.tsxweb/packages/studio/src/components/evaluation/Jobs/form/MetricTypeSection.test.tsxweb/packages/studio/src/components/evaluation/Jobs/form/ScoreModal.test.tsxweb/packages/studio/src/components/evaluation/Jobs/form/utils.test.tsweb/packages/studio/src/components/filesets/AddToFolderModal/index.test.tsxweb/packages/studio/src/components/filesets/FilesetFileExplorer/BulkDeleteModal/index.test.tsxweb/packages/studio/src/components/filesets/FilesetFileExplorer/DatasetFileDropzone/index.test.tsxweb/packages/studio/src/components/filesets/FilesetFileExplorer/hooks/useFileActions.test.tsweb/packages/studio/src/components/filesets/FilesetFileExplorer/hooks/useFileSelection.test.tsweb/packages/studio/src/components/filesets/FilesetFileExplorer/hooks/useFileUpload.test.tsweb/packages/studio/src/components/filesets/FilesetFileExplorer/index.test.tsxweb/packages/studio/src/components/filesets/hooks/useBulkDownload.test.tsweb/packages/studio/src/components/filesets/hooks/useBulkDuplicate.test.tsweb/packages/studio/src/components/filesets/hooks/useDownloadFileAsArrayBuffer.test.tsweb/packages/studio/src/components/sidePanels/AgentPanels/AgentPanel/index.test.tsxweb/packages/studio/src/components/sidePanels/AgentPanels/AgentPanel/walkthrough.test.tsweb/packages/studio/src/components/sidePanels/AgentPanels/AgentPanel/walkthroughStorage.test.tsweb/packages/studio/src/components/sidePanels/CustomizationConfigSidePanel/index.test.tsxweb/packages/studio/src/components/sidePanels/MetricRunSidePanel/FileValidationPanel/index.test.tsxweb/packages/studio/src/components/sidePanels/MetricRunSidePanel/FileValidationPanel/utils.test.tsweb/packages/studio/src/components/sidePanels/MetricRunSidePanel/utils.test.tsweb/packages/studio/src/components/sidePanels/ModelPanels/ModelPanel/components.test.tsxweb/packages/studio/src/components/sidePanels/ModelPanels/ModelPanel/index.test.tsxweb/packages/studio/src/components/sidePanels/PromptTuningPanel/index.test.tsxweb/packages/studio/src/constants/sampleDatasets.test.tsweb/packages/studio/src/constants/zod.test.tsweb/packages/studio/src/hooks/useCustomizationDatasetValidation/index.test.tsxweb/packages/studio/src/hooks/useDatasetFileDiscovery/index.test.tsweb/packages/studio/src/hooks/useModelCustomizationEligibility/index.test.tsxweb/packages/studio/src/hooks/useModelIsServed/index.test.tsxweb/packages/studio/src/hooks/useModelLoraEnabled/index.test.tsweb/packages/studio/src/main.test.tsxweb/packages/studio/src/providers/auth/useAuthTokenStatus.test.tsweb/packages/studio/src/routes/CustomizationJobDetailsRoute/DetailActions.test.tsxweb/packages/studio/src/routes/CustomizationJobDetailsRoute/index.test.tsxweb/packages/studio/src/routes/DashboardLandingRoute/index.test.tsxweb/packages/studio/src/routes/DashboardLandingRoute/skillActionTemplates.test.tsweb/packages/studio/src/routes/DashboardLandingRoute/skillDisplayName.test.tsweb/packages/studio/src/routes/DeploymentsListRoute/CreateDeploymentSidePanel/schema.test.tsweb/packages/studio/src/routes/DeploymentsListRoute/CreateDeploymentSidePanel/useCreateDeploymentBySource.test.tsxweb/packages/studio/src/routes/DeploymentsListRoute/useDeleteDeploymentAndConfig.test.tsxweb/packages/studio/src/routes/FilesetDetailRoute/DatasetSchemaEditor/index.test.tsxweb/packages/studio/src/routes/FilesetDetailRoute/FilesTab/schemaColumn.test.tsweb/packages/studio/src/routes/FilesetDetailRoute/FilesetCard/DatasetSamplePanel.test.tsxweb/packages/studio/src/routes/FilesetDetailRoute/FilesetMetadataPanel/utils.test.tsxweb/packages/studio/src/routes/FilesetDetailRoute/index.test.tsxweb/packages/studio/src/routes/FilesetDetailRoute/utils.test.tsweb/packages/studio/src/routes/FilesetListRoute/ActionMenu/index.test.tsxweb/packages/studio/src/routes/FilesetListRoute/DatasetBulkDeleteModal/index.test.tsxweb/packages/studio/src/routes/FilesetListRoute/index.test.tsxweb/packages/studio/src/routes/FilesetNewRoute/index.test.tsxweb/packages/studio/src/routes/InferenceProvidersListRoute/CreateInferenceProviderSidePanel/InferenceModelProviderSelect.test.tsxweb/packages/studio/src/routes/InferenceProvidersListRoute/CreateInferenceProviderSidePanel/index.test.tsxweb/packages/studio/src/routes/InferenceProvidersListRoute/InferenceProviderDetailsSidePanel/index.test.tsxweb/packages/studio/src/routes/IntakeTraceDetailRoute/index.test.tsxweb/packages/studio/src/routes/JobDetailRoute/utils.test.tsweb/packages/studio/src/routes/NewCustomizationRoute/index.test.tsxweb/packages/studio/src/routes/NoMatchRoute/index.test.tsxweb/packages/studio/src/routes/PageLayout/ThemeSwitch.test.tsxweb/packages/studio/src/routes/PromptTuningFormRoute/index.test.tsxweb/packages/studio/src/routes/PromptTuningFormRoute/util.test.tsweb/packages/studio/src/routes/RootLayout/WorkspaceGuard.test.tsxweb/packages/studio/src/routes/RootRedirect/index.test.tsxweb/packages/studio/src/routes/SafeSynthesizerJobDetailsRoute/components/JobConfigDrawer.test.tsxweb/packages/studio/src/routes/SafeSynthesizerJobDetailsRoute/components/JobDetailsPanel.test.tsxweb/packages/studio/src/routes/SafeSynthesizerJobDetailsRoute/components/ProgressSection.test.tsxweb/packages/studio/src/routes/SafeSynthesizerJobDetailsRoute/components/ReportSummaryPanel.test.tsxweb/packages/studio/src/routes/SafeSynthesizerJobDetailsRoute/index.test.tsxweb/packages/studio/src/routes/SafeSynthesizerJobReportRoute/components/OverviewPanel.test.tsxweb/packages/studio/src/routes/SafeSynthesizerJobReportRoute/components/ScorePanels/DataPrivacyPanel.test.tsxweb/packages/studio/src/routes/SafeSynthesizerJobReportRoute/components/ScorePanels/ScoreItem.test.tsxweb/packages/studio/src/routes/SafeSynthesizerJobReportRoute/components/ScorePanels/SyntheticQualityPanel.test.tsxweb/packages/studio/src/routes/SafeSynthesizerJobReportRoute/index.test.tsxweb/packages/studio/src/routes/SafeSynthesizerJobReportRoute/util.test.tsweb/packages/studio/src/routes/SafeSynthesizerListRoute/index.test.tsxweb/packages/studio/src/routes/WorkspaceBaseModelsRoute/index.test.tsxweb/packages/studio/src/routes/WorkspaceDashboardRoute/index.test.tsxweb/packages/studio/src/routes/WorkspaceMembersRoute/WorkspaceMemberModal.test.tsxweb/packages/studio/src/routes/agents/AgentEvaluationsRoute/AgentEvaluationDetailRoute.test.tsxweb/packages/studio/src/routes/agents/AgentEvaluationsRoute/AgentEvaluationsListRoute.test.tsxweb/packages/studio/src/routes/agents/AgentEvaluationsRoute/api.test.tsweb/packages/studio/src/routes/agents/AgentMonitorRoute/telemetry.test.tsweb/packages/studio/src/routes/agents/AgentMonitorRoute/utils.test.tsweb/packages/studio/src/routes/agents/AgentSuggestionsRoute/api.read.test.tsweb/packages/studio/src/routes/agents/AgentSuggestionsRoute/api.test.tsweb/packages/studio/src/routes/agents/AgentSuggestionsRoute/useOptimizerSuggestions.test.tsxweb/packages/studio/src/routes/agents/AgentSuggestionsRoute/utils.test.tsweb/packages/studio/src/routes/agents/AgentsListRoute/index.test.tsxweb/packages/studio/src/routes/agents/ClaudeCodeChatRoute/BlockingInputComposer.test.tsxweb/packages/studio/src/routes/agents/ClaudeCodeChatRoute/ClaudeCodeHistoryPanel.test.tsxweb/packages/studio/src/routes/agents/ClaudeCodeChatRoute/ClaudeCodeStudioLink.test.tsxweb/packages/studio/src/routes/agents/ClaudeCodeChatRoute/ClaudeCodeToolCallPart.test.tsxweb/packages/studio/src/routes/agents/ClaudeCodeChatRoute/JobProgressToolCall.test.tsxweb/packages/studio/src/routes/agents/ClaudeCodeChatRoute/api.test.tsweb/packages/studio/src/routes/agents/ClaudeCodeChatRoute/stream.test.tsweb/packages/studio/src/routes/agents/ClaudeCodeChatRoute/useClaudeCodeChatRuntime.test.tsweb/packages/studio/src/routes/agents/ClaudeCodeChatRoute/useCustomAssistantChatRuntime.test.tsweb/packages/studio/src/routes/agents/ClaudeCodeChatRoute/util.test.tsweb/packages/studio/src/routes/agents/ClaudeCodeChatRoute/utils/jobProgress.test.tsweb/packages/studio/src/routes/guardrails/GuardrailsDetailPanel/index.test.tsxweb/packages/studio/src/routes/index.test.tsxweb/packages/studio/src/routes/utils.test.tsweb/packages/studio/src/selectors/evaluationConfig.test.tsweb/packages/studio/src/telemetry/util.test.tsweb/packages/studio/src/tests/clone-a-model.test.tsxweb/packages/studio/src/tests/create-a-customization.test.tsxweb/packages/studio/src/tests/create-a-model.test.tsxweb/packages/studio/src/tests/title-change.test.tsxweb/packages/studio/src/util/csrf.test.tsweb/packages/studio/src/util/customizations.test.tsweb/packages/studio/src/util/customizerSchema.test.tsweb/packages/studio/src/util/date.test.tsweb/packages/studio/src/util/evaluations.test.tsweb/packages/studio/src/util/files.test.tsweb/packages/studio/src/util/forms/customization.test.tsweb/packages/studio/src/util/forms/error.test.tsweb/packages/studio/src/util/forms/transforms.test.tsweb/packages/studio/src/util/functions.test.tsweb/packages/studio/src/util/hooks/useSessionStorage.test.tsweb/packages/studio/src/util/intakeTelemetry.test.tsweb/packages/studio/src/util/list.test.tsweb/packages/studio/src/util/llm.test.tsweb/packages/studio/src/util/logger.test.tsweb/packages/studio/src/util/models.test.tsweb/packages/studio/src/util/sseStream.test.tsweb/packages/studio/src/util/storageConfigFromUrl.test.tsweb/packages/studio/src/util/strings.test.ts
💤 Files with no reviewable changes (1)
- web/packages/studio/src/util/files.test.ts
✅ Files skipped from review due to trivial changes (9)
- web/packages/studio/e2e-tests/projects/model-inference.spec.ts
- web/packages/studio/e2e-tests/projects/model.spec.ts
- web/packages/studio/src/components/SafeSynthesizerFilesetPreview/index.test.tsx
- web/packages/studio/e2e-tests/projects/project.spec.ts
- web/packages/studio/e2e-tests/safeSynthesizer.spec.ts
- web/.agents/skills/unit-test/SKILL.md
- web/packages/studio/e2e-tests/customization.spec.ts
- web/AGENTS.md
- web/README.md
Signed-off-by: Sean Teramae <steramae@nvidia.com>
Signed-off-by: Sean Teramae <steramae@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
long live
.test.ts, death to.spec.tsSummary by CodeRabbit
Tests
.spec.*to.test.*across the codebase for consistency.Documentation