Skip to content

Trim some codecs from FFmpeg build #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JanuszL merged 1 commit into from
May 25, 2026
Merged

Trim some codecs from FFmpeg build #162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions build_scripts/build_ffmpeg.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,11 @@ if [ ${WITH_FFMPEG} -gt 0 ]; then
--disable-filters \
--disable-bsfs \
--disable-decoder=ipu \
--disable-decoder=hevc \
--disable-decoder=h264 \
Comment on lines +51 to +52

@greptile-apps greptile-apps Bot May 18, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Software H.264/HEVC decoders disabled while BSFs remain enabled

The h264_mp4toannexb and hevc_mp4toannexb BSFs are kept (line 56), which suggests the pipeline routes these bitstreams to a hardware decoder (NVDEC). Disabling the software decoders is therefore intentional for the GPU path. However, if FFmpeg calls avformat_find_stream_info() internally — which DALI's demuxer likely does — FFmpeg may attempt to probe the stream by decoding a few packets using the software decoder. With both hevc and h264 decoders disabled, probing such streams could yield incomplete or inaccurate stream metadata (e.g., missing width/height, frame rate, or pixel format). This is also a hard break for any CPU-only test or CI environment that exercises the video decode path without NVDEC available.

Fix in Claude Code

@JanuszL JanuszL May 18, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DALI side rework will be done in a separate PR to the DLAI repo itself. This is fully intentional.

--disable-decoder=aac \
--disable-decoder=aac_fixed \
--disable-decoder=aac_latm \
--enable-bsf=h264_mp4toannexb,hevc_mp4toannexb,mpeg4_unpack_bframes \
--disable-lzma
# adds | sed 's/\(.*{\)/DALI_\1/' | to the version file generation command - it prepends "DALI_" to the symbol version
Expand Down