[TEST - DO NOT MERGE] CI gating probe: docs only (examples/diffusers/README.md) - #2096
[TEST - DO NOT MERGE] CI gating probe: docs only (examples/diffusers/README.md)#2096kevalmorabia97 wants to merge 2 commits into
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
/ok to test 9d8ae23 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2096 +/- ##
=======================================
Coverage 78.60% 78.60%
=======================================
Files 522 522
Lines 60167 60167
=======================================
Hits 47294 47294
Misses 12873 12873
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/ok to test 6292a40 |
9d8ae23 to
6292a40
Compare
|
/ok to test 6292a40 |
|
/ok to test 05725b8 |
6292a40 to
05725b8
Compare
The ignore never took effect. Two separate causes, both found by a probe PR against merged main whose only change was a README: - files_ignore does not apply to files_yaml groups, so the example lanes filtered nothing. Exclude per group instead. - As an inline negation, `**.md` does not exclude, while `**/*.md` does (micromatch treats the two forms differently, though isMatch accepts both). This also made _pr_gate's ignore inert for its callers, where it only looked correct because docs paths usually fall outside the watch lists. Verified against micromatch 4.0.5, the version the action depends on: README.md, examples/diffusers/README.md and a nested .png now match no lane, while config.py -> onnx, examples/dataset -> torch+trtllm and tests/examples/conftest.py -> common are unchanged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
14f1406 to
f1a3e49
Compare
|
/ok to test f1a3e49 |
Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
05725b8 to
a02c274
Compare
|
/ok to test a02c274 |
|
Verified against #2101: with the fix in place, a docs-only change now runs nothing. All four example lanes skipped, |
|
1 participant
Temporary draft PR verifying the lane gating from #2090 against a real PR. Do not review or merge — this will be closed and its branch deleted once the gate decisions are recorded.
Change: docs only (examples/diffusers/README.md)
Expected: no lanes at all — .md is in files_ignore, so pr-gate short-circuits every workflow