Skip to content

Bump step-security/changed-files to v47 - #2103

Merged
kevalmorabia97 merged 1 commit into
mainfrom
kmorabia/bump-changed-files-v47
Aug 7, 2026
Merged

Bump step-security/changed-files to v47#2103
kevalmorabia97 merged 1 commit into
mainfrom
kmorabia/bump-changed-files-v47

Conversation

@kevalmorabia97

@kevalmorabia97 kevalmorabia97 commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

Type of change: CI/CD maintenance

Last of the Node 20 actions: step-security/changed-files v46.0.5 → v47.0.5, in _pr_gate.yml, example_tests.yml and unit_tests.yml.

Deliberately separate from #2102. Every gate in the repo runs through this action, and the example lanes depend on its files_yaml per-group outputs plus any_modified semantics. v47 has no release notes describing output behavior, and the upstream v47 notes are dependency bumps only — so this is the one bump I could not clear from a changelog. On its own, any gating regression is unambiguous.

What I did verify at v47.0.5:

  • micromatch is still ^4.0.5 — the matcher the lane patterns were validated against
  • files, files_ignore, files_yaml, files_ignore_yaml are all still inputs
  • any_modified, any_changed, changed_keys are all still documented outputs

Testing

Static checks above. The behavior that matters cannot be proven from this PR: it changes workflow files, which are in the common group, so every lane runs regardless of whether gating still works. I plan to confirm with a throwaway probe PR against this branch — a docs-only change must run nothing, and a single-example change must run exactly one lane — the same method that caught the two ignore bugs fixed in #2101.

Before your PR is "Ready for review"

  • Is this change backward compatible?: ✅
  • If you copied code from any other sources or added a new PIP dependency, did you follow guidance in CONTRIBUTING.md: N/A
  • Did you write any new necessary tests?: N/A — CI configuration
  • Did you update Changelog?: N/A
  • Did you get Claude approval on this PR?: ❌ — not yet run

Summary by CodeRabbit

  • Chores
    • Updated pull-request file-change checks to use the latest available file-detection action.
    • Applied the update consistently across example-test and unit-test workflows.
    • Improved consistency and reliability across automated pull-request validation checks without changing application behavior.

@kevalmorabia97
kevalmorabia97 requested a review from a team as a code owner August 7, 2026 09:35
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6b5e977d-a005-4c86-a6fd-92bf697f8bb3

📥 Commits

Reviewing files that changed from the base of the PR and between b39a6d4 and 140ab2e.

📒 Files selected for processing (2)
  • .github/workflows/_pr_gate.yml
  • .github/workflows/example_tests.yml
🚧 Files skipped from review as they are similar to previous changes (2)
  • .github/workflows/_pr_gate.yml
  • .github/workflows/example_tests.yml

📝 Walkthrough

Walkthrough

The pull-request, example-test, and unit-test workflows update step-security/changed-files from v46.0.5 to v47.0.5.

Changes

Workflow action updates

Layer / File(s) Summary
Update changed-files action version
.github/workflows/_pr_gate.yml, .github/workflows/example_tests.yml, .github/workflows/unit_tests.yml
The change-detection steps now use step-security/changed-files@v47.0.5.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: updating step-security/changed-files to v47.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Security Anti-Patterns ✅ Passed The PR changes only three workflow action versions; it adds no modelopt/examples Python code or dependencies and no listed security anti-patterns.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch kmorabia/bump-changed-files-v47

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.08%. Comparing base (3d4d924) to head (140ab2e).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2103      +/-   ##
==========================================
- Coverage   78.60%   78.08%   -0.52%     
==========================================
  Files         522      522              
  Lines       60167    60167              
==========================================
- Hits        47294    46982     -312     
- Misses      12873    13185     +312     
Flag Coverage Δ
examples 42.93% <ø> (+1.06%) ⬆️
gpu 58.65% <ø> (-0.62%) ⬇️
regression 14.90% <ø> (+0.04%) ⬆️
unit 55.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Split from the other Node 20 bumps because the example lane gating depends
on this action's files_yaml group outputs and any_modified semantics, and
v47 ships no release notes covering them. Keeping it alone makes a gating
regression attributable.

Checked at v47.0.5: micromatch is still ^4.0.5 (the matcher the lane
patterns were verified against), files/files_ignore/files_yaml/
files_ignore_yaml are all still inputs, and any_modified/any_changed/
changed_keys are still documented outputs.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
@kevalmorabia97
kevalmorabia97 force-pushed the kmorabia/bump-changed-files-v47 branch from b39a6d4 to 140ab2e Compare August 7, 2026 10:39
@kevalmorabia97
kevalmorabia97 merged commit 02b64bc into main Aug 7, 2026
53 checks passed
@kevalmorabia97
kevalmorabia97 deleted the kmorabia/bump-changed-files-v47 branch August 7, 2026 11:42
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-08-07 11:43 UTC

kevalmorabia97 added a commit that referenced this pull request Aug 7, 2026
### What does this PR do?

Type of change: CI/CD maintenance

#2102 and #2103 bumped every action this repo references *directly*, but
Node 20 annotations still appear — e.g. [this run on
#2103](https://github.com/NVIDIA/Model-Optimizer/actions/runs/31170982088?pr=2103):

> The following actions target Node.js 20 but are being forced to run on
Node.js 24:
`actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea`

We never reference `github-script`. It comes in transitively through
`codecov/codecov-action`:

| codecov-action | bundled github-script | runtime |
|---|---|---|
| `@v5` (= v5.5.5) | `60a0d830…` | **node20** |
| `@v6.0.2` / `@v7.0.0` | `ed597411…` | node24 |

Bumps all four call sites (`unit_tests`, `gpu_tests`,
`regression_tests`, `_example_tests_runner`) to `@v7`.

Checked: v6's notes call out node24 support as the only breaking aspect
— the same pattern as the bumps in #2102 — and our runners report
2.336.0. The inputs used here (`token`, `files`, `flags`,
`fail_ci_if_error`, `verbose`) all still exist in v7. A scan of every
referenced action, direct and one level transitive, now finds no node20
runtimes left.

### Testing

Coverage upload runs in every unit, gpu, regression and example job, so
CI exercises this broadly. Worth checking that coverage still lands in
Codecov rather than only that the step is green — `fail_ci_if_error:
false` means an upload failure would not turn the job red.

### Before your PR is "*Ready for review*"

- Is this change backward compatible?: ✅
- If you copied code from any other sources or added a new PIP
dependency, did you follow guidance in `CONTRIBUTING.md`: N/A
- Did you write any new necessary tests?: N/A — CI configuration
- Did you update
[Changelog](https://github.com/NVIDIA/Model-Optimizer/blob/main/CHANGELOG.rst)?:
N/A
- Did you get Claude approval on this PR?: ❌ — not yet run

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Chores**
* Updated automated test workflows to use the latest coverage reporting
action.
* Improved compatibility and reliability of coverage report uploads
across example, GPU, regression, and unit tests.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant