Give the EAGLE-3 cp_size=2 compile case a longer timeout - #2109
Conversation
|
/ok to test e6c99a7 |
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesEagle test updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2109 +/- ##
==========================================
- Coverage 78.60% 75.60% -3.01%
==========================================
Files 522 522
Lines 60167 60167
==========================================
- Hits 47294 45487 -1807
- Misses 12873 14680 +1807
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
test_llama_eagle3[2-False] timed out at the 300s examples default in the first nightly after #2086 re-enabled the cp_size=2 cases, which the old version guard had skipped since February. Measured on the 2-GPU runner: [2-False] 304s, [1-False] 173s, [2-True] 51s, [1-True] 39s. Only [2-False] exceeds the default, and only by 4s: it pays context parallelism plus torch.compile, which mix_hidden_states=False enables. The marker is scoped to that one case so the 300s cap keeps protecting the rest. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
e6c99a7 to
f1414a2
Compare
|
What does this PR do?
Type of change: Bug fix (CI)
test_llama_eagle3[2-False]timed out at the 300s examples default in the first nightly after #2086 re-enabled thecp_size=2cases. Those cases had never run in CI before — the old guard comparedVersion("2.10.0a0")againstVersion("2.10.0"), which is False on every NGC alpha build, so they had been silently skipped since February.Measured on the 2-GPU runner:
[2-False][1-False][2-True][1-True]Only
[2-False]exceeds the cap, and only barely: it pays context parallelism plustorch.compile, whichmix_hidden_states=Falseenables. It is a margin problem, not a hang. The marker is scoped to that single param so the 300s cap keeps protecting every other example test.Note 360s is roughly 18% headroom over a single sample on a shared runner. If it ever trips again the signal will be a duration just above 360s, which distinguishes normal variance from a real regression.
Testing
Measured by temporarily running the spec-dec lane ungated on the 2-GPU runner in this PR (those overrides have been reverted; the diff is now one file). That run: 16 passed, 2 skipped in 1016s, with
[2-False]at 304.27s.Before your PR is "Ready for review"
CONTRIBUTING.md: N/ASummary by CodeRabbit