Skip to content

Give the EAGLE-3 cp_size=2 compile case a longer timeout - #2109

Merged
kevalmorabia97 merged 1 commit into
mainfrom
kmorabia/fix-eagle-cp-timeout
Aug 7, 2026
Merged

Give the EAGLE-3 cp_size=2 compile case a longer timeout#2109
kevalmorabia97 merged 1 commit into
mainfrom
kmorabia/fix-eagle-cp-timeout

Conversation

@kevalmorabia97

@kevalmorabia97 kevalmorabia97 commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

Type of change: Bug fix (CI)

test_llama_eagle3[2-False] timed out at the 300s examples default in the first nightly after #2086 re-enabled the cp_size=2 cases. Those cases had never run in CI before — the old guard compared Version("2.10.0a0") against Version("2.10.0"), which is False on every NGC alpha build, so they had been silently skipped since February.

Measured on the 2-GPU runner:

case duration
[2-False] 304s — over the 300s default by 4s
[1-False] 173s
[2-True] 51s
[1-True] 39s

Only [2-False] exceeds the cap, and only barely: it pays context parallelism plus torch.compile, which mix_hidden_states=False enables. It is a margin problem, not a hang. The marker is scoped to that single param so the 300s cap keeps protecting every other example test.

Note 360s is roughly 18% headroom over a single sample on a shared runner. If it ever trips again the signal will be a duration just above 360s, which distinguishes normal variance from a real regression.

Testing

Measured by temporarily running the spec-dec lane ungated on the 2-GPU runner in this PR (those overrides have been reverted; the diff is now one file). That run: 16 passed, 2 skipped in 1016s, with [2-False] at 304.27s.

Before your PR is "Ready for review"

  • Is this change backward compatible?: ✅
  • If you copied code from any other sources or added a new PIP dependency, did you follow guidance in CONTRIBUTING.md: N/A
  • Did you write any new necessary tests?: N/A — adjusts an existing test's timeout
  • Did you update Changelog?: N/A
  • Did you get Claude approval on this PR?: ❌ — not yet run

Summary by CodeRabbit

  • Tests
    • Reformatted test parameter definitions for improved readability.
    • Preserved all existing test combinations and timeout settings.

@kevalmorabia97

Copy link
Copy Markdown
Collaborator Author

/ok to test e6c99a7

@copy-pr-bot

copy-pr-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c511ae0a-f427-49af-9217-63c11d9bea41

📥 Commits

Reviewing files that changed from the base of the PR and between 02b64bc and f1414a2.

📒 Files selected for processing (1)
  • tests/examples/speculative_decoding/test_eagle.py

📝 Walkthrough

Walkthrough

The test_llama_eagle3 parameter list now uses multiline formatting. All four parameter combinations and the 360-second timeout remain unchanged.

Changes

Eagle test updates

Layer / File(s) Summary
Parameter list formatting
tests/examples/speculative_decoding/test_eagle.py
The test_llama_eagle3 parameter list was reformatted. Existing cp_size and mix_hidden_states combinations and the timeout marker remain unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: aanoosheh

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the targeted timeout increase for the EAGLE-3 cp_size=2 compile case.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Security Anti-Patterns ✅ Passed The PR only reformats test parameters and adds a scoped pytest timeout; no listed security patterns or dependency changes were added.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch kmorabia/fix-eagle-cp-timeout

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.60%. Comparing base (02b64bc) to head (f1414a2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2109      +/-   ##
==========================================
- Coverage   78.60%   75.60%   -3.01%     
==========================================
  Files         522      522              
  Lines       60167    60167              
==========================================
- Hits        47294    45487    -1807     
- Misses      12873    14680    +1807     
Flag Coverage Δ
examples 21.46% <ø> (-20.41%) ⬇️
unit 55.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

test_llama_eagle3[2-False] timed out at the 300s examples default in the
first nightly after #2086 re-enabled the cp_size=2 cases, which the old
version guard had skipped since February.

Measured on the 2-GPU runner: [2-False] 304s, [1-False] 173s, [2-True] 51s,
[1-True] 39s. Only [2-False] exceeds the default, and only by 4s: it pays
context parallelism plus torch.compile, which mix_hidden_states=False
enables. The marker is scoped to that one case so the 300s cap keeps
protecting the rest.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
@kevalmorabia97
kevalmorabia97 force-pushed the kmorabia/fix-eagle-cp-timeout branch from e6c99a7 to f1414a2 Compare August 7, 2026 12:17
@kevalmorabia97 kevalmorabia97 changed the title [WIP - measuring] Give the EAGLE-3 cp_size=2 tests a longer timeout Give the EAGLE-3 cp_size=2 compile case a longer timeout Aug 7, 2026
@kevalmorabia97
kevalmorabia97 marked this pull request as ready for review August 7, 2026 12:17
@kevalmorabia97
kevalmorabia97 requested a review from a team as a code owner August 7, 2026 12:17
@kevalmorabia97
kevalmorabia97 merged commit 8c576b6 into main Aug 7, 2026
35 of 36 checks passed
@kevalmorabia97
kevalmorabia97 deleted the kmorabia/fix-eagle-cp-timeout branch August 7, 2026 13:01
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-08-07 13:01 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant