Fix resolved configuration edge cases - #2169
Conversation
Bind compatibility rendering to stage-owned profiles and preserve normalized values when resuming older setup state. Signed-off-by: Johannes Rausch <jrausch@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe update mirrors stage batch values into legacy experiment paths, serializes resolved records through ChangesConfiguration compatibility
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/puzzletron_v2 #2169 +/- ##
======================================================
Coverage 53.03% 53.04%
======================================================
Files 710 710
Lines 92198 92198
======================================================
+ Hits 48896 48902 +6
+ Misses 43302 43296 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Johannes Rausch <jrausch@nvidia.com>
|
What does this PR do?
Type of change: Bug fix
This is a focused follow-up to #2163, which consolidated Puzzletron's resolved configuration. It fixes edge cases in the compatibility renderer: stage-owned pruning and replacement-scoring batch sizes now update the shared data sections consumed by existing runtime paths. Resolved field records reuse their normalized serialization, and redundant validation branches are removed.
The PyYAML imports also carry the annotations required by the repository's type-checking configuration.
Testing
Adds focused unit coverage for mirroring stage batch sizes into the shared data configuration. Existing resolved-configuration tests cover snapshot serialization, compatibility rendering, and bundle validation.
Summary by CodeRabbit