docs: clarify streaming lifecycle guidance - #132
Conversation
Signed-off-by: Lawrence Lane <25370251+lbliii@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (13)
🧰 Additional context used📓 Path-based instructions (11)**/*.{md,rst}📄 CodeRabbit inference engine (.agents/skills/contribute-api/SKILL.md)
Files:
**/*📄 CodeRabbit inference engine (.agents/skills/karpathy-guidelines/SKILL.md)
Files:
**/*.{md,mdx,rst}📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-guide.md)
Files:
**/*.{md,rst,txt,adoc}📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-language-mechanics.md)
Files:
skills/**📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.{md,mdx}📄 CodeRabbit inference engine (.agents/skills/review-doc-style/SKILL.md)
Files:
**/*.{rs,py,html,md,mdx,toml,yml,yaml,sh,bash}📄 CodeRabbit inference engine (CONTRIBUTING.md)
Files:
**/{README.md,*.md,*.mdx}📄 CodeRabbit inference engine (CONTRIBUTING.md)
Files:
**/SKILL.md📄 CodeRabbit inference engine (.agents/skills/README.md)
Files:
⚙️ CodeRabbit configuration file
Files:
**/*.md📄 CodeRabbit inference engine (.agents/skills/README.md)
Files:
{*.md,**/*.md,**/*.mdx,**/*.ipynb}⚙️ CodeRabbit configuration file
Files:
🔇 Additional comments (1)
WalkthroughUpdated NeMo Relay streaming documentation to distinguish request-ID correlation for in-process harnesses from turn-scope role and 1-based turn-index correlation for gateway harnesses. Record limits and matched-scope-tree behavior remain documented. No code or API behavior changes. ChangesNeMo Relay streaming documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Signed-off-by: Zhongxuan Wang <daniewang@nvidia.com>
|
/merge |
Overview
Follow up on the
::rdocumentation style review of #112 by clarifying the NeMo Relay streaming lifecycle guidance in the consumer integration skill.Details
Validation
git diff --checkuvx --from rust-just just docs(passes with the existing Fern warning for the generated Python API index and skipped redirects check)Breaking changes
None.
Where should the reviewer start?
Review
skills/integrations/consumer/nemo-fabric-integrate/SKILL.md, especially the NeMo Relay streaming lifecycle bullet.Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Relates to docs: standardize NeMo Fabric naming #112
I confirm this contribution is my own work, or I have the right to submit it under this project's license.
I searched existing issues and open pull requests, and this does not duplicate existing work.
Summary by CodeRabbit