Skip to content

bug: enable Claude E2E test on macOS - #141

Closed
dagardner-nv wants to merge 12 commits into
NVIDIA:release/0.1from
dagardner-nv:david-macos-triage
Closed

bug: enable Claude E2E test on macOS#141
dagardner-nv wants to merge 12 commits into
NVIDIA:release/0.1from
dagardner-nv:david-macos-triage

Conversation

@dagardner-nv

@dagardner-nv dagardner-nv commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Overview

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • Closes #

  • I confirm this contribution is my own work, or I have the right to submit it under this project's license.

  • I searched existing issues and open pull requests, and this does not duplicate existing work.

Summary by CodeRabbit

  • Bug Fixes

    • Improved relay gateway readiness checks by bypassing ambient HTTP proxy settings during /healthz verification.
    • Increased the maximum time allowed for the relay gateway to become healthy (health check timeout extended to 30 seconds).
  • Tests

    • Added a unit test confirming relay gateway health checks ignore ambient proxies.
    • Updated an end-to-end test’s platform gating to skip only on win32 (and adjusted the skip reason/message).
  • Chores

    • Updated Python CI to use a consistent temp directory and upload gateway.log artifacts when available.

Signed-off-by: David Gardner <dagardner@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

Walkthrough

The relay gateway health check now bypasses ambient proxies and waits up to 30 seconds, with unit coverage. Python CI captures gateway logs, and the Claude relay supervision test is skipped only on Windows.

Changes

Relay gateway readiness and validation

Layer / File(s) Summary
Bypass ambient proxies
adapters/common/src/nemo_fabric_adapters/common/relay_gateway.py, tests/adapters/test_adapters_common_relay_gateway.py
The health check uses an empty ProxyHandler opener, extends the readiness timeout to 30 seconds, and tests proxy bypass with a one-second request timeout.
Capture gateway diagnostics
.github/workflows/ci_python.yml
The Python test job sets TMPDIR, enables strict shell behavior, and always uploads available gateway.log artifacts.
Update platform skip condition
tests/e2e/test_claude.py
The test’s platform skip condition now targets only win32, and the skip reason reflects the narrower gating.

Estimated code review effort: 2 (Simple) | ~10 minutes


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error, 1 warning)

Check name Status Explanation Resolution
Title check ❌ Error The title is related to the PR, but it uses the invalid type 'bug' instead of an allowed Conventional Commits type. Use an allowed prefix such as 'fix:' or 'test:' and keep the summary imperative and under 72 characters.
Description check ⚠️ Warning The description is only the template skeleton; none of the required sections are filled in. Add a filled Overview, Where should the reviewer start?, and Related Issues section, plus the required confirmation checkboxes.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

…d-macos-triage

Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
@dagardner-nv dagardner-nv changed the title bug: Fix Hermes Agent E2E test on macOS bug: enable Claude E2E test on macOS Jul 28, 2026
Signed-off-by: David Gardner <dagardner@nvidia.com>
@dagardner-nv

Copy link
Copy Markdown
Collaborator Author

/ok to test 706cdb1

Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant