ci: make Do Not Merge tag actually block merging - #164
Conversation
WalkthroughUpdates the project and adapter release metadata, dependencies, documentation, and integration tests from 0.1.0 to 0.2.0. Also adds a GitHub Actions workflow that fails checks for pull requests carrying the Changes0.2.0 release alignment
Do Not Merge check
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/do-not-merge.yml:
- Around line 6-8: Add a pull-request-keyed concurrency configuration alongside
the workflow trigger, using a stable PR identifier for the group and setting
cancel-in-progress to true. Keep the existing pull_request event types unchanged
so newer label-state runs cancel older runs and determine the final check
status.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: db4b53e4-ea66-4d23-81e4-7b9bd8935edb
📒 Files selected for processing (1)
.github/workflows/do-not-merge.yml
📜 Review details
⏰ Context from checks skipped due to timeout. (4)
- GitHub Check: Test (Python 3.14, linux-arm64)
- GitHub Check: Test (Python 3.11, macos-arm64)
- GitHub Check: Test (Python 3.14, macos-arm64)
- GitHub Check: Test (arm64)
🧰 Additional context used
📓 Path-based instructions (3)
**/.github/workflows/*.{yml,yaml}
📄 CodeRabbit inference engine (.agents/skills/maintain-ci/SKILL.md)
**/.github/workflows/*.{yml,yaml}: Definepermissions:per job that needs token access, using the minimum required scopes; avoid workflow-level permissions unless centralized inheritance is intentionally documented.
Pin every third-party GitHub Action to a full commit SHA and retain a readable version comment after the SHA.
Use action-native or ecosystem-native caching instead of genericactions/cachewhen available.
Tie cache invalidation to lockfiles, dependency manifests, or explicit tool versions; avoid caching generated outputs unless deliberate repository behavior requires it.
Useastral-sh/setup-uvcache support withcache-dependency-globanchored touv.lock.
UseSwatinem/rust-cachewith explicitshared-keyandworkspacesinstead of ad hoc target-directory caching.
Keep deploy and publish permissions isolated to only the jobs that require them; restrictpages: writeandid-token: writeto Pages deployment jobs and their reusable-workflow callers.
Usecontents: readas the minimum permission for checkout-based build, test, documentation, and packaging jobs.
Grantpull-requests: readonly to jobs that perform pull-request metadata lookups.
When usingworkflow_call, inspect both caller and callee, and ensure the caller grants every permission required by the called jobs because the callee cannot elevate permissions.
Keep local workflow commands aligned with equivalentjustfilerecipes, and keep Python, Rust, and documentation jobs aligned with their lockfiles.
Preserve intended concurrency settings, branch filters, and documentation publish guards when modifying workflows.
Before editing workflows, inspect workflow relationships and settings with searches coveringuses:,permissions:,secrets:,concurrency:,cache, andjust.
Files:
.github/workflows/do-not-merge.yml
{docs/package.json,docs/package-lock.json,.github/workflows/*.yml,justfile}
📄 CodeRabbit inference engine (.agents/skills/maintain-packaging/SKILL.md)
Keep documentation tooling, CI workflows, install commands, build/test/clean recipes, and examples consistent with current package names and commands.
Files:
.github/workflows/do-not-merge.yml
{pyproject.toml,python/pyproject.toml,Cargo.toml,docs/package.json,.github/workflows/*.yml,justfile}
📄 CodeRabbit inference engine (.agents/skills/maintain-packaging/SKILL.md)
Reflect public packaging changes in release-facing documentation and ensure CI references the same package names and commands used by local workflows.
Files:
.github/workflows/do-not-merge.yml
🪛 zizmor (1.28.0)
.github/workflows/do-not-merge.yml
[warning] 6-8: insufficient job-level concurrency limits (concurrency-limits): workflow is missing concurrency setting
(concurrency-limits)
🔇 Additional comments (1)
.github/workflows/do-not-merge.yml (1)
1-5: LGTM!Also applies to: 10-21
Signed-off-by: Zhongxuan Wang <daniewang@nvidia.com>
Signed-off-by: Zhongxuan Wang <daniewang@nvidia.com>
Signed-off-by: Zhongxuan Wang <daniewang@nvidia.com>
4245880 to
32c241a
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/python/test_harbor_integration.py`:
- Around line 357-363: Move the pyproject.toml version lookup using
Path.resolve, Path.open, and tomllib.load out of
test_harbor_structured_package_install_is_shell_safe, loading package_version
once at module scope or before the async test begins. Reuse that value when
constructing fabric_package, keeping the existing package-version source and
dependency format unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 466d0190-acc4-4dc9-9e1b-4169e1094c4a
⛔ Files ignored due to path filters (7)
Cargo.lockis excluded by!**/*.lockadapters/claude/uv.lockis excluded by!**/*.lockadapters/codex/uv.lockis excluded by!**/*.lockadapters/common/uv.lockis excluded by!**/*.lockadapters/deepagents/uv.lockis excluded by!**/*.lockadapters/hermes/uv.lockis excluded by!**/*.lockuv.lockis excluded by!**/*.lock
📒 Files selected for processing (14)
.github/workflows/do-not-merge.ymlCargo.tomlREADME.mdadapters/claude/pyproject.tomladapters/codex/pyproject.tomladapters/common/pyproject.tomladapters/deepagents/pyproject.tomladapters/hermes/pyproject.tomldocs/integrations/harness/deepagents.mdxexamples/harbor/README.mdexamples/harbor/swebench/README.mdpyproject.tomltests/integrations/test_harbor_runner.pytests/python/test_harbor_integration.py
📜 Review details
🧰 Additional context used
📓 Path-based instructions (44)
**/*
📄 CodeRabbit inference engine (.agents/skills/karpathy-guidelines/SKILL.md)
**/*: Before implementing, explicitly state assumptions, surface ambiguity and tradeoffs, present multiple interpretations when relevant, and ask for clarification rather than silently deciding or proceeding when requirements are unclear.
Prefer the minimum code needed to solve the requested problem: avoid speculative features, unnecessary abstractions, unrequested flexibility, and handling of impossible scenarios; simplify overcomplicated solutions.
When editing existing code, make surgical changes only: do not modify unrelated code, comments, formatting, or pre-existing dead code; match the existing style, and remove only unused imports, variables, or functions introduced by your changes.
Define verifiable success criteria for each task, such as writing regression tests for bugs and invalid-input tests for validation, then verify the implementation against those criteria. For multi-step work, state a brief plan with a verification check for each step.
**/*: Always spellNVIDIAin all caps; do not useNvidia,nvidia,nVidia,nVIDIA, orNV.
Usean NVIDIAbefore a noun, because the name begins with an “en” sound.
Do not add a registered trademark symbol afterNVIDIAwhen referring to the company; use trademark symbols with product names only when required by the document type or legal guidance.
Verify official capitalization, spacing, hyphenation, and spelling for NVIDIA and third-party product names; do not rewrite official product names for grammar or title-case rules.
Precede NVIDIA product names withNVIDIAon first mention when natural and accurate, and link the first mention when the destination helps the reader.
On first use, include the company name and full model qualifier when it helps identify the model; preserve official capitalization and punctuation, and use shorter family names only after establishing the full name.
For learning-oriented and developer content, do not force trademark symbols unless explicitly required; for press, ...
Files:
adapters/common/pyproject.tomladapters/hermes/pyproject.tomladapters/claude/pyproject.tomlCargo.tomldocs/integrations/harness/deepagents.mdxexamples/harbor/README.mdREADME.mdexamples/harbor/swebench/README.mdadapters/deepagents/pyproject.tomltests/integrations/test_harbor_runner.pyadapters/codex/pyproject.tomlpyproject.tomltests/python/test_harbor_integration.py
**/*.{rs,toml}
📄 CodeRabbit inference engine (.agents/skills/prepare-pr/SKILL.md)
For any Rust change, run
just test-rustandcargo fmt --all -- --check.For Rust core, CLI, or shared runtime semantic changes, run Rust formatting and tests, and add Python tests when behavior is exposed through the SDK.
Files:
adapters/common/pyproject.tomladapters/hermes/pyproject.tomladapters/claude/pyproject.tomlCargo.tomladapters/deepagents/pyproject.tomladapters/codex/pyproject.tomlpyproject.toml
**/{Cargo.toml,Cargo.lock,pyproject.toml,package.json}
📄 CodeRabbit inference engine (.agents/skills/prepare-pr/SKILL.md)
For new or updated dependencies, document the functional need, alternatives considered, and why the selected dependency is the narrowest fit.
Files:
adapters/common/pyproject.tomladapters/hermes/pyproject.tomladapters/claude/pyproject.tomlCargo.tomladapters/deepagents/pyproject.tomladapters/codex/pyproject.tomlpyproject.toml
**/*.{toml,lock}
📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
If a manifest or lockfile changes, run the license-diff script against
origin/main, review transitive license changes, and run theattributions-rustandattributions-pythonpre-commit hooks.
Files:
adapters/common/pyproject.tomladapters/hermes/pyproject.tomladapters/claude/pyproject.tomlCargo.tomladapters/deepagents/pyproject.tomladapters/codex/pyproject.tomlpyproject.toml
**/*.{yml,yaml,toml,lock}
📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
For CI or packaging changes, use
maintain-ciormaintain-packaging, then run recipes and checks whose behavior changed.
Files:
adapters/common/pyproject.tomladapters/hermes/pyproject.tomladapters/claude/pyproject.tomlCargo.tomladapters/deepagents/pyproject.tomladapters/codex/pyproject.tomlpyproject.toml
{pyproject.toml,adapters/**/pyproject.toml}
📄 CodeRabbit inference engine (.agents/skills/update-project-version/SKILL.md)
{pyproject.toml,adapters/**/pyproject.toml}: Update the literalproject.versionin the root setuptools project and every adapterpyproject.toml.
Keep internal exact-version requirements aligned: rootnemo-fabric-* == <version>optional dependencies and each adapter'snemo-fabric-adapters-common == <version>dependency.
Files:
adapters/common/pyproject.tomladapters/hermes/pyproject.tomladapters/claude/pyproject.tomladapters/deepagents/pyproject.tomladapters/codex/pyproject.tomlpyproject.toml
**/*.{rs,py,toml}
📄 CodeRabbit inference engine (.agents/skills/update-project-version/SKILL.md)
When editing version helpers, verify every
nemo-fabric-*workspace package through Cargo metadata and reject a static version inpython/pyproject.toml.
Files:
adapters/common/pyproject.tomladapters/hermes/pyproject.tomladapters/claude/pyproject.tomlCargo.tomladapters/deepagents/pyproject.tomltests/integrations/test_harbor_runner.pyadapters/codex/pyproject.tomlpyproject.tomltests/python/test_harbor_integration.py
**/*.{toml,rs,py}
📄 CodeRabbit inference engine (.agents/skills/update-project-version/SKILL.md)
Avoid blind repository-wide replacement of version-like strings; distinguish package-version references from examples and unrelated dependency versions.
Files:
adapters/common/pyproject.tomladapters/hermes/pyproject.tomladapters/claude/pyproject.tomlCargo.tomladapters/deepagents/pyproject.tomltests/integrations/test_harbor_runner.pyadapters/codex/pyproject.tomlpyproject.tomltests/python/test_harbor_integration.py
**/*.{rs,py,html,md,mdx,toml,yaml,yml,sh,bash}
📄 CodeRabbit inference engine (CONTRIBUTING.md)
All source files must include the specified SPDX copyright and Apache-2.0 license headers using the comment syntax appropriate to the file type.
Files:
adapters/common/pyproject.tomladapters/hermes/pyproject.tomladapters/claude/pyproject.tomlCargo.tomldocs/integrations/harness/deepagents.mdxexamples/harbor/README.mdREADME.mdexamples/harbor/swebench/README.mdadapters/deepagents/pyproject.tomltests/integrations/test_harbor_runner.pyadapters/codex/pyproject.tomlpyproject.tomltests/python/test_harbor_integration.py
adapters/*/{README.md,LICENSE,fabric-adapter.json,pyproject.toml,uv.lock,package.json,package-lock.json,src/**,tests/**}
📄 CodeRabbit inference engine (.agents/skills/contribute-adapter/SKILL.md)
Place each adapter under
adapters/<name>withLICENSE -> ../../LICENSE,README.md,fabric-adapter.json, language-native package and lock files, a source entry point, and focused tests; Python adapters use the specifiedpyproject.toml,uv.lock, source path, and test naming convention.
Files:
adapters/common/pyproject.tomladapters/hermes/pyproject.tomladapters/claude/pyproject.tomladapters/deepagents/pyproject.tomladapters/codex/pyproject.toml
adapters/*/pyproject.toml
📄 CodeRabbit inference engine (.agents/skills/contribute-adapter/SKILL.md)
Keep published Python runtime dependencies razor-thin and adapter-owned; directly imported SDK/client libraries must be declared, while external-process harness dependencies must not be installed or upgraded and test-only dependencies belong in
[dependency-groups].
Files:
adapters/common/pyproject.tomladapters/hermes/pyproject.tomladapters/claude/pyproject.tomladapters/deepagents/pyproject.tomladapters/codex/pyproject.toml
{adapters/**,examples/**}
⚙️ CodeRabbit configuration file
{adapters/**,examples/**}: Review adapter and example changes for command correctness, config/schema consistency, artifact handling, and compatibility with the public NeMo Fabric contracts.
Files:
adapters/common/pyproject.tomladapters/hermes/pyproject.tomladapters/claude/pyproject.tomlexamples/harbor/README.mdexamples/harbor/swebench/README.mdadapters/deepagents/pyproject.tomladapters/codex/pyproject.toml
**/.github/workflows/*.{yml,yaml}
📄 CodeRabbit inference engine (.agents/skills/maintain-ci/SKILL.md)
**/.github/workflows/*.{yml,yaml}: Definepermissions:per job that needs token access, using the minimum required scopes; avoid workflow-level permissions unless centralized inheritance is intentionally documented.
Pin every third-party GitHub Action to a full commit SHA and retain a readable version comment after the SHA.
Use action-native or ecosystem-native caching instead of genericactions/cachewhen available.
Tie cache invalidation to lockfiles, dependency manifests, or explicit tool versions; avoid caching generated outputs unless deliberate repository behavior requires it.
Useastral-sh/setup-uvcache support withcache-dependency-globanchored touv.lock.
UseSwatinem/rust-cachewith explicitshared-keyandworkspacesinstead of ad hoc target-directory caching.
Keep deploy and publish permissions isolated to only the jobs that require them; restrictpages: writeandid-token: writeto Pages deployment jobs and their reusable-workflow callers.
Usecontents: readas the minimum permission for checkout-based build, test, documentation, and packaging jobs.
Grantpull-requests: readonly to jobs that perform pull-request metadata lookups.
When usingworkflow_call, inspect both caller and callee, and ensure the caller grants every permission required by the called jobs because the callee cannot elevate permissions.
Keep local workflow commands aligned with equivalentjustfilerecipes, and keep Python, Rust, and documentation jobs aligned with their lockfiles.
Preserve intended concurrency settings, branch filters, and documentation publish guards when modifying workflows.
Before editing workflows, inspect workflow relationships and settings with searches coveringuses:,permissions:,secrets:,concurrency:,cache, andjust.
Files:
.github/workflows/do-not-merge.yml
{docs/package.json,docs/package-lock.json,.github/workflows/*.yml,justfile}
📄 CodeRabbit inference engine (.agents/skills/maintain-packaging/SKILL.md)
Keep documentation tooling, CI workflows, install commands, build/test/clean recipes, and examples consistent with current package names and commands.
Files:
.github/workflows/do-not-merge.yml
{pyproject.toml,python/pyproject.toml,Cargo.toml,docs/package.json,.github/workflows/*.yml,justfile}
📄 CodeRabbit inference engine (.agents/skills/maintain-packaging/SKILL.md)
Reflect public packaging changes in release-facing documentation and ensure CI references the same package names and commands used by local workflows.
Files:
.github/workflows/do-not-merge.ymlCargo.tomlpyproject.toml
{Cargo.toml,python/pyproject.toml,pyproject.toml}
📄 CodeRabbit inference engine (.agents/skills/maintain-packaging/SKILL.md)
Keep Rust workspace/package metadata and Python/maturin package metadata internally consistent, including package names, versions, import paths, and module names.
Files:
Cargo.tomlpyproject.toml
{Cargo.toml,Cargo.lock,pyproject.toml,uv.lock,python/pyproject.toml}
📄 CodeRabbit inference engine (.agents/skills/maintain-packaging/SKILL.md)
{Cargo.toml,Cargo.lock,pyproject.toml,uv.lock,python/pyproject.toml}: Keep workspace, Python, and lockfile dependency versions aligned where required, and review both direct and transitive dependency changes from resolved lockfiles.
Inspect resolved transitive licenses, explicitly surface UNKNOWN, non-SPDX/custom, proprietary, source-available, copyleft, or network-copyleft terms, and route unresolved licensing questions to dependency approvers with distribution and linkage context.
Document the functional need, alternatives considered, rationale for the selected dependency, and any unresolved licensing question when introducing dependencies.
Files:
Cargo.tomlpyproject.toml
{Cargo.toml,pyproject.toml,python/pyproject.toml}
📄 CodeRabbit inference engine (.agents/skills/maintain-packaging/SKILL.md)
Before adding a dependency, prefer the standard library, an existing dependency, or a small local implementation when appropriate; otherwise select a maintained, narrow-fit dependency with clear SPDX metadata and a permissive license where possible.
Files:
Cargo.tomlpyproject.toml
{Cargo.toml,Cargo.lock,pyproject.toml,uv.lock}
📄 CodeRabbit inference engine (.agents/skills/maintain-packaging/SKILL.md)
After updating manifests or lockfiles, run
uv run --no-project python scripts/licensing/license_diff.py --base-ref origin/mainand review added packages and license changes.
Files:
Cargo.tomlpyproject.toml
Cargo.toml
📄 CodeRabbit inference engine (.agents/skills/update-project-version/SKILL.md)
Cargo.toml: UseCargo.toml[workspace.package].versionas the source of truth for Rust workspace and Python build versioning.
KeepCargo.toml[workspace.dependencies].nemo-fabric-core.versionaligned with the workspace version.
Use valid Cargo SemVer in Cargo metadata and equivalent PEP 440 syntax in explicit Python metadata for prerelease or build-metadata versions.
Files:
Cargo.toml
{README.md,docs/**/*.{md,mdx,yml},examples/**/*.{md,mdx,yml}}
📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)
Keep package names, repository references, and build commands current in documentation and examples.
Files:
docs/integrations/harness/deepagents.mdxexamples/harbor/README.mdREADME.mdexamples/harbor/swebench/README.md
{docs/**/*.{md,mdx,yml},examples/**/*.{md,mdx,yml}}
📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)
Update relevant getting-started, reference, adapter, and example documentation when the corresponding examples or adapters change.
Files:
docs/integrations/harness/deepagents.mdxexamples/harbor/README.mdexamples/harbor/swebench/README.md
**/*.mdx
📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)
In MDX files, use JSX comment delimiters (
{/*and*/}) for top-of-file comments, including SPDX headers; do not use HTML comments.
Files:
docs/integrations/harness/deepagents.mdx
docs/**/*.{md,mdx,yml}
📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)
Run
just docswhen the documentation site changes.Update user-facing Fern documentation, including
docs/index.yml, when public behavior, the package, examples, or supported bindings change.
Files:
docs/integrations/harness/deepagents.mdx
**/*.{md,mdx,rst}
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-guide.md)
**/*.{md,mdx,rst}: For NeMo Fabric documentation, verify technical claims against the current repository, public API, or documented command before reviewing style.
Always spellNVIDIAin all caps; do not useNvidia,nvidia, orNV.
Format commands, code elements, expressions, package names, file names, and paths as inline code.
Use descriptive link text; avoid raw URLs and weak anchors such ashereorread more.
Use title case consistently for technical documentation headings.
Introduce code blocks, lists, tables, and images with complete sentences.
Write procedures as imperative, parallel steps; split long procedures into smaller tasks.
Prefer active voice, present tense, short sentences, contractions, and plain English while preserving necessary technical precision.
Usecanfor possibility and reservemayfor permission.
Useafterfor temporal relationships instead ofonce, and preferrefer tooverseewhen directing readers to another resource.
Avoid culture-specific idioms, unnecessary Latinisms, jokes, and marketing exaggeration in technical documentation.
Spell out months in body text, avoid ordinal dates, and use clear time zones.
Spell out whole numbers from zero through nine unless they are technical values, parameters, versions, or UI values; use numerals for 10 or greater and commas in thousands.
Do not add trademark symbols to learning-oriented documentation unless the source, platform, or legal guidance explicitly requires them.
Do not replace precise technical terms with simpler words when doing so would lose precision.
Do not flag passive voice when the actor is unknown or the action is the important part.
Do not rewrite API names, package names, command flags, or code literals for style.
**/*.{md,mdx,rst}: Use consistent title case for technical-document headings and table headers; avoid quotation marks, ampersands, and exclamation marks in headings, while preserving official product, event, research, and whitepaper title ...
Files:
docs/integrations/harness/deepagents.mdxexamples/harbor/README.mdREADME.mdexamples/harbor/swebench/README.md
**/*.{md,mdx}
📄 CodeRabbit inference engine (CONTRIBUTING.md)
When public behavior, adapters, examples, or workspace structure changes, update the corresponding documentation, including relevant README files and SDK or API references.
**/*.{md,mdx}: Use the full product nameNVIDIA NeMo Fabricon first use, typically in the title and H1; useNeMo Fabricthereafter. Usefabricalone only for the CLI tool and surround it with backticks.
Treat incorrect or stale commands, package names, paths, APIs, support claims, procedures, examples, terminology, or public behavior documentation as blocking issues.
CapitalizeNVIDIAcorrectly and format code, commands, paths, and filenames as inline code where needed.
Use title case for technical-documentation headings.
Introduce code blocks, tables, and lists with complete lead-in sentences; ensure examples match current APIs and build commands.
Use descriptive anchor text, avoid raw URLs and generic labels such ashere, and use repository-relative.mdxpaths for links withindocs/.
Prefer active voice, present tense, short sentences, plain English, consistent terminology, and imperative, parallel, scannable procedures.
Useafterinstead ofoncewhen expressing temporal sequence, and usecanrather thanmaywhen describing possibility rather than permission.
Avoid ambiguous numeric dates and ordinal dates in body text.
For learning-oriented documentation, do not force trademark symbols unless the source document explicitly requires them.
When reporting documentation-review findings, lead withMust fix,Should fix, andNice to havecategories; include file path, line reference, current problem, rationale, and a concrete rewrite or direction.
Files:
docs/integrations/harness/deepagents.mdxexamples/harbor/README.mdREADME.mdexamples/harbor/swebench/README.md
docs/**/*.mdx
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/SKILL.md)
docs/**/*.mdx: Use source-relative links with the target.mdxextension for links between files underdocs/; do not use Fern site-root paths.
Use{/* ... */}delimiters for top-of-file MDX SPDX comments, not HTML comment delimiters.
Files:
docs/integrations/harness/deepagents.mdx
**/*.{md,mdx,yml,py,rs,sh}
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/SKILL.md)
Keep documentation aligned with current NeMo Fabric behavior, repository layout, entry points, commands, package names, APIs, bindings, and support claims.
Files:
docs/integrations/harness/deepagents.mdxexamples/harbor/README.mdREADME.mdexamples/harbor/swebench/README.mdtests/integrations/test_harbor_runner.pytests/python/test_harbor_integration.py
{docs/**,README.md,AGENTS.md}
⚙️ CodeRabbit configuration file
{docs/**,README.md,AGENTS.md}: Review documentation for technical accuracy against the current API, command correctness, and consistency with generated schemas.
For links between files under docs/, require paths relative to the source file with the target file's .mdx extension so they work in both Fern builds and repository browsers. Flag Fern site-root links such as NeMo Fabric overview; use the repository-relative equivalent, such as NeMo Fabric overview.
Files:
docs/integrations/harness/deepagents.mdxREADME.md
{*.md,**/*.md,**/*.mdx,**/*.ipynb}
⚙️ CodeRabbit configuration file
{*.md,**/*.md,**/*.mdx,**/*.ipynb}: Enforce the product name in user-facing prose: use "NVIDIA NeMo Fabric" on first use and "NeMo Fabric" thereafter. Flag standalone capitalized "Fabric" when it refers to the product. Do not flag the lowercasefabricCLI command, package/import/crate names, code identifiers, API symbols, configuration keys, file paths, or unrelated generic uses of the word.
Files:
docs/integrations/harness/deepagents.mdxexamples/harbor/README.mdREADME.mdexamples/harbor/swebench/README.md
**/*.{md,rst}
📄 CodeRabbit inference engine (.agents/skills/contribute-api/SKILL.md)
Update documentation and examples in the same branch as the public API change.
Files:
examples/harbor/README.mdREADME.mdexamples/harbor/swebench/README.md
**/*.{md,rst,txt,adoc}
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-language-mechanics.md)
**/*.{md,rst,txt,adoc}: For technical documentation, use professional, active, conversational, engaging, precise, and plain-English prose. Prefer active voice, present tense, short sentences, and scannable paragraphs. Avoid casual or imprecise language, swearing, threats, insults, jokes, puns, culture-specific idioms, marketing exaggeration, and unsupported third-party comparisons.
Usecanfor possibility and reservemayfor permission; useafterfor temporal order; userefer tofor cross-references; prefer short direct sentences and specific verbs; avoid unnecessarypleasein technical documentation.
Prefer active voice when the actor matters. Passive voice is acceptable when the actor is unknown or irrelevant, when the action or result is the focus, or in programmer documentation.
Use natural contractions in conversational technical prose, but do not force them in formal legal copy, API references, or generated text.
Prefer simpler English over Latinisms: usefor exampleorsuch asinstead ofe.g.,and so oninstead ofetc.,that isinstead ofi.e.,compared toinstead ofvs., andby,through, orusinginstead ofvia. Use industry-standard terms such as in silico, in vitro, and in vivo when appropriate, and italicize them in running text.
Usethatwithout commas for essential clauses, andwhichwith commas for nonessential clauses.
Format dates and times clearly: spell out months in body text; use forms such asJune 12, 2025; avoid numeric or ordinal dates; capitalize days; use 12-hour time when appropriate; include a space beforea.m.orp.m.; useETandPTfor needed time zones; avoid24/7; and preferfrom 12:30 to 1:00 p.m.for prose ranges.
Format numbers consistently: spell out zero through nine in body text, use numerals for 10 or greater and for technical values, use commas in thousands, do not begin a sentence with a numeral, spell out ordinals, and use numerals consistently within a category wh...
Files:
examples/harbor/README.mdREADME.mdexamples/harbor/swebench/README.md
examples/{README.md,**/*}
📄 CodeRabbit inference engine (AGENTS.md)
Update examples documentation and relevant examples when public behavior, the package, or supported bindings change.
Files:
examples/harbor/README.mdexamples/harbor/swebench/README.md
{README.md,docs/index.yml}
📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)
Update
README.mdordocs/index.ymlwhen documentation entry points or example reading paths change.
Files:
README.md
README.md
📄 CodeRabbit inference engine (AGENTS.md)
Update the root
README.mdwhen public behavior, thenemo-fabricpackage (imported asnemo_fabric), examples, or supported bindings change.
Files:
README.md
**/*.{rs,py,pyi,json,yaml,yml}
📄 CodeRabbit inference engine (.agents/skills/contribute-api/SKILL.md)
Determine and update every affected public surface, including the CLI, PyO3 bindings, Python SDK, type stubs, schemas, and adapter contract, so they remain in parity.
Files:
tests/integrations/test_harbor_runner.pytests/python/test_harbor_integration.py
**/*.{rs,py}
📄 CodeRabbit inference engine (.agents/skills/prepare-pr/SKILL.md)
For native binding changes, run
cargo check -p fabric-python --locked.
**/*.{rs,py}: Usesnake_casefor functions and variables; usePascalCasefor Rust types and Python classes.
Run the relevant Rust and Python test suites for every affected language surface; changes to the Rust core or public schemas require both suites.
Files:
tests/integrations/test_harbor_runner.pytests/python/test_harbor_integration.py
**/*.{py,pyi}
📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
If Python code or a Python-facing adapter changes, run
just test-python.
Files:
tests/integrations/test_harbor_runner.pytests/python/test_harbor_integration.py
**/*.{rs,py,pyi}
📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
**/*.{rs,py,pyi}: If public configuration types change, confirm schema snapshot tests injust test-rustpass and review generated schema diffs.
For schema or public contract changes, run both language suites and review changes underschemas/and generated API references.
Files:
tests/integrations/test_harbor_runner.pytests/python/test_harbor_integration.py
**/*.{py,pyi,rs}
📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
For Python SDK or PyO3 binding changes, use
python-tests, run focused pytest tests first, thenjust test-python; rebuild withjust build-pythonwhen native code or packaging changes.
Files:
tests/integrations/test_harbor_runner.pytests/python/test_harbor_integration.py
tests/**/*.py
📄 CodeRabbit inference engine (.agents/skills/python-tests/SKILL.md)
tests/**/*.py: Use Pytest to run Python tests.
Do not add@pytest.mark.asyncioto tests; async tests are automatically detected and run by the async runner.
Do not add-> Nonereturn type annotations to test functions.
When mocking a class, useunittest.mock.MagicMockorunittest.mock.AsyncMock, using thespecargument when necessary, rather than defining a new class.
Prefix mocked class names withmock, notfake.
Prefer pytest fixtures over helper methods.
Do not repeat fixtures; place fixtures needed by multiple test files inconftest.py.
Define fixtures using@pytest.fixture(name="<fixture_name>"[, scope="<scope>"])and a function named<fixture_name>_fixture; specifyscopeonly when it is notfunction.
Preferpytest.mark.parametrizeover separate tests for different input types.
Use@pytest.mark.usefixtureswhen a fixture is needed but its return value is unused or it does not return a value.
Use the autouserestore_environ_fixturefromtests/conftest.pyto restore environment variables; modify variables withos.environand do not usemonkeypatch.setenv.
Avoid defensive programming in tests; access expected data directly so missing data raises a clear failure, such as usingresults["data"]instead ofresults.get("data").
Files:
tests/integrations/test_harbor_runner.pytests/python/test_harbor_integration.py
**/*.py
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Use type annotations for public Python APIs and keep native binding declarations synchronized with their Rust implementations.
Files:
tests/integrations/test_harbor_runner.pytests/python/test_harbor_integration.py
**/*.{rs,py,json}
📄 CodeRabbit inference engine (CONTRIBUTING.md)
When adding functionality, include tests in the corresponding Rust crate or relevant
tests/area; public contract changes must keep checked-in JSON Schema snapshots and native Python binding declarations synchronized.
Files:
tests/integrations/test_harbor_runner.pytests/python/test_harbor_integration.py
{tests/**,python/tests/**}
⚙️ CodeRabbit configuration file
{tests/**,python/tests/**}: Tests should cover the behavior promised by the changed API surface, including error paths, lifecycle cleanup, and SDK/native parity where relevant.
Files:
tests/integrations/test_harbor_runner.pytests/python/test_harbor_integration.py
🪛 Ruff (0.16.0)
tests/python/test_harbor_integration.py
[warning] 357-357: Async functions should not use pathlib.Path methods, use trio.Path or anyio.path
(ASYNC240)
🔇 Additional comments (14)
.github/workflows/do-not-merge.yml (1)
1-25: LGTM!Cargo.toml (1)
17-23: LGTM!pyproject.toml (1)
12-12: LGTM!Also applies to: 28-28, 41-49, 58-58
adapters/claude/pyproject.toml (1)
12-12: LGTM!Also applies to: 28-28
adapters/codex/pyproject.toml (1)
12-12: LGTM!Also applies to: 28-28
docs/integrations/harness/deepagents.mdx (1)
34-40: LGTM!examples/harbor/README.md (1)
68-77: LGTM!examples/harbor/swebench/README.md (1)
25-30: LGTM!adapters/common/pyproject.toml (1)
12-12: LGTM!adapters/deepagents/pyproject.toml (1)
12-12: LGTM!Also applies to: 28-28
adapters/hermes/pyproject.toml (1)
12-12: LGTM!Also applies to: 29-29
README.md (1)
151-153: LGTM!Also applies to: 170-170, 179-179
tests/integrations/test_harbor_runner.py (1)
300-302: LGTM!Also applies to: 323-325, 334-334
tests/python/test_harbor_integration.py (1)
10-10: LGTM!Also applies to: 377-377
There was a problem hiding this comment.
Caution
Inline review comments failed to post. This is likely due to GitHub's internal server error or limits when posting large numbers of comments. If you are seeing this consistently it is likely a permissions issue. Please check "Moderation" -> "Code review limits" under your organization settings.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/python/test_harbor_integration.py`:
- Around line 357-363: Move the pyproject.toml version lookup using
Path.resolve, Path.open, and tomllib.load out of
test_harbor_structured_package_install_is_shell_safe, loading package_version
once at module scope or before the async test begins. Reuse that value when
constructing fabric_package, keeping the existing package-version source and
dependency format unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 466d0190-acc4-4dc9-9e1b-4169e1094c4a
⛔ Files ignored due to path filters (7)
Cargo.lockis excluded by!**/*.lockadapters/claude/uv.lockis excluded by!**/*.lockadapters/codex/uv.lockis excluded by!**/*.lockadapters/common/uv.lockis excluded by!**/*.lockadapters/deepagents/uv.lockis excluded by!**/*.lockadapters/hermes/uv.lockis excluded by!**/*.lockuv.lockis excluded by!**/*.lock
📒 Files selected for processing (14)
.github/workflows/do-not-merge.ymlCargo.tomlREADME.mdadapters/claude/pyproject.tomladapters/codex/pyproject.tomladapters/common/pyproject.tomladapters/deepagents/pyproject.tomladapters/hermes/pyproject.tomldocs/integrations/harness/deepagents.mdxexamples/harbor/README.mdexamples/harbor/swebench/README.mdpyproject.tomltests/integrations/test_harbor_runner.pytests/python/test_harbor_integration.py
📜 Review details
🔇 Additional comments (14)
.github/workflows/do-not-merge.yml (1)
1-25: LGTM!Cargo.toml (1)
17-23: LGTM!pyproject.toml (1)
12-12: LGTM!Also applies to: 28-28, 41-49, 58-58
adapters/claude/pyproject.toml (1)
12-12: LGTM!Also applies to: 28-28
adapters/codex/pyproject.toml (1)
12-12: LGTM!Also applies to: 28-28
docs/integrations/harness/deepagents.mdx (1)
34-40: LGTM!examples/harbor/README.md (1)
68-77: LGTM!examples/harbor/swebench/README.md (1)
25-30: LGTM!adapters/common/pyproject.toml (1)
12-12: LGTM!adapters/deepagents/pyproject.toml (1)
12-12: LGTM!Also applies to: 28-28
adapters/hermes/pyproject.toml (1)
12-12: LGTM!Also applies to: 29-29
README.md (1)
151-153: LGTM!Also applies to: 170-170, 179-179
tests/integrations/test_harbor_runner.py (1)
300-302: LGTM!Also applies to: 323-325, 334-334
tests/python/test_harbor_integration.py (1)
10-10: LGTM!Also applies to: 377-377
🛑 Comments failed to post (1)
tests/python/test_harbor_integration.py (1)
357-363: 🚀 Performance & Scalability | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
python3 - <<'PY' from pathlib import Path p = Path('tests/python/test_harbor_integration.py') for start, end in [(330, 390)]: print(p) with p.open() as f: for i, line in enumerate(f, 1): if start <= i <= end: print(f"{i}: {line.rstrip()}") PYRepository: NVIDIA/NeMo-Fabric
Length of output: 2707
🏁 Script executed:
rg -n "ASYNC240|Path\.resolve\(\)|\.open\(\"rb\"\)|aiofiles|async with .*open|await .*open\(" tests python -g '!**/__pycache__/**'Repository: NVIDIA/NeMo-Fabric
Length of output: 797
Move the package-version lookup out of the async test
Path.resolve()andPath.open("rb")here do synchronous I/O insidetest_harbor_structured_package_install_is_shell_safe, which can block the async runner and triggersASYNC240. Loadpyproject.tomlonce at module scope or before entering the async test.🧰 Tools
🪛 Ruff (0.16.0)
[warning] 357-357: Async functions should not use pathlib.Path methods, use trio.Path or anyio.path
(ASYNC240)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/python/test_harbor_integration.py` around lines 357 - 363, Move the pyproject.toml version lookup using Path.resolve, Path.open, and tomllib.load out of test_harbor_structured_package_install_is_shell_safe, loading package_version once at module scope or before the async test begins. Reuse that value when constructing fabric_package, keeping the existing package-version source and dependency format unchanged.Source: Linters/SAST tools
zhongxuanwang-nv
changed the title
Do Not Merge tag actually block merging
AnuradhaKaruppiah
left a comment
AnuradhaKaruppiah
left a comment
There was a problem hiding this comment.
Thank you for this much needed change!
|
/merge |
2 participants
Overview
Add a minimal required-check surface that blocks a pull request while it has the
DO NOT MERGElabel. The job is skipped before runner allocation when the label is absent and runs only long enough to report a failure when the label is present.Details
After this workflow lands, configure
DO NOT MERGE labelas a required status check for the protected main branch so its failure blocks merging.Validation
just --fmt --check.github/workflows/do-not-merge.ymlactionlintpre-commit hook for GitHub Actions workflowsgit diff --check upstream/main...HEADRust and Python tests were not run because this change only adds a GitHub Actions workflow.
Where should the reviewer start?
Start with
.github/workflows/do-not-merge.yml, especially the job-level label condition that avoids runner allocation when merging is allowed.Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit