chore: forward-merge release/0.1 into main - #170
Closed
AnuradhaKaruppiah wants to merge 4 commits into
Closed
Conversation
#### Overview Replace the deprecated `nvidia/nemotron-3-nano-30b-a3b` model with `nvidia/nemotron-3-nano-omni-30b-a3b-reasoning` across the maintained runtime presets and every dependent repository surface. This keeps the Hermes and Deep Agents NVIDIA API Catalog paths usable without changing their provider, credential, endpoint, or harness configuration. - [x] I confirm this contribution is my own work, or I have the right to submit it under this project's license. - [x] I searched existing issues and open pull requests, and this does not duplicate existing work. #### Details - Update the Hermes and Deep Agents CLI preset defaults. - Keep generated Python and Rust scaffolds aligned with the updated preset. - Update README, Fern documentation, code-review and Harbor examples, and both onboarding notebooks. - Update Deep Agents, Hermes, Harbor, ATOF, and ATIF expectations to assert the replacement model. - Remove all 28 tracked references to the deprecated identifier. There are no breaking API or configuration-shape changes. #### Validation - `cargo fmt --all -- --check` - `just test-rust` — passed - `just test-python` — 574 passed, 15 skipped - `npx --prefix docs --no-install fern check --warnings` — 0 errors; redirect check skipped because Fern authentication was unavailable - Verified `nemo-fabric plan --preset hermes` and `nemo-fabric plan --preset deepagents` resolve the replacement model - Manually ran the Hermes code-review example with Relay and confirmed ATOF/ATIF model metadata - Manually ran the Harbor calculator Hermes Relay job — 1 trial, 0 exceptions, reward 1.0, telemetry validation succeeded - Manually ran the Harbor SWE-bench `django__django-13741` Hermes job — 1 trial, 0 exceptions, reward 1.0 #### Where should the reviewer start? Start in `crates/fabric-cli/src/presets.rs`, where the maintained Hermes and Deep Agents defaults are defined, then review the corresponding model expectations in `crates/fabric-cli/src/scaffold.rs` and `tests/e2e/test_hermes_e2e.py`. #### Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to) - Relates to: none ## Summary by CodeRabbit - **Documentation** - Updated quick-start guides, SDK examples, preset references, notebooks, and sample projects to use `nvidia/nemotron-3-nano-omni-30b-a3b-reasoning`. - Refreshed Hermes and Deep Agents preset documentation and example commands with the new default model. - **Configuration** - Updated default model selections across generated configurations and example agents. - **Tests** - Updated validation and integration coverage to reflect the new model identifier. Authors: - Yuchen Zhang (https://github.com/yczhang-nv) Approvers: - Ajay Thorve (https://github.com/AjayThorve) - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: NVIDIA#166
#### Overview * Incorporate some of the changes from PR NVIDIA#89 * The library has moved/changed a bit since then, as we are no longer promoting the CLI as a new-user tool, and have removed it from our examples #### Where should the reviewer start? * `docs/about-nemo-fabric/overview.mdx` - [x] I confirm this contribution is my own work, or I have the right to submit it under this project's license. - [x] I searched existing issues and open pull requests, and this does not duplicate existing work. ## Summary by CodeRabbit * **Documentation** * Refreshed the NeMo Fabric overview with stronger branded messaging, improved interface selection guidance, a simplified “Core Workflow,” and a “Learn More” resource list. * Renamed the installation guide to “NVIDIA NeMo Fabric Installation” for clearer labeling. * Updated the quickstart to use the current template library version and adjusted spacing around the “Next Steps” section. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) - Lawrence Lane (https://github.com/lbliii) URL: NVIDIA#165
#### Overview * Remove references to alpha and RC tags * Replace buildwithfern.com links with docs.nvidia.com #### Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to) - Closes FABRIC-135 - [x] I confirm this contribution is my own work, or I have the right to submit it under this project's license. - [x] I searched existing issues and open pull requests, and this does not duplicate existing work. ## Summary by CodeRabbit * **Documentation** * Updated NeMo Fabric and NeMo Relay links across installation guides, package pages, project metadata, and examples to point to the official NVIDIA documentation site. * Refreshed installation instructions to reference the stable `0.1.0` package release instead of a pre-release version. * **Tests** * Updated integration expectations to match the stable package version. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Zhongxuan (Daniel) Wang (https://github.com/zhongxuanwang-nv) URL: NVIDIA#163
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (38)
WalkthroughThe change replaces the default Nemotron model identifier, updates related tests and examples, revises the documentation overview and metadata, and migrates repository documentation links to ChangesModel defaults and validation
Documentation structure
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Fern docs preview: https://nvidia-preview-pull-request-170.docs.buildwithfern.com/nemo/fabric |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Manually forward-merges
release/0.1intomainto resolve the conflicts blocking the ops-bot PR #167. The merge preserves branch history and keeps themaindevelopment package version at0.2.0.Details
release/0.1head (11752276b04c409c1a4bbacb2a41ac15f2de239c) into the currentmainhead (cfb87c759305edb46151e63512e9e82a1cee3365) with a two-parent merge commit.examples/harbor/swebench/README.mdby retainingmain'snemo-fabric==0.2.0package reference.tests/integrations/test_harbor_runner.pyby retaining the assertion derived from the project package version.Validation
python -m pytest tests/integrations/test_harbor_runner.py::test_harbor_calculator_documents_explicit_cli_commands— passed.git diff --check upstream/main...HEAD— passed.tests/integrations/test_harbor_runner.py: 14 passed; 5 could not run in the existing environment because optionalopenai_codexand Harbor modules were unavailable.Where should the reviewer start?
Review merge commit
3ed7212a9fcbd6681f62c7c225622589ec06d7cc, especially the conflict resolutions inexamples/harbor/swebench/README.mdandtests/integrations/test_harbor_runner.py.Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit
Documentation
New Features