docs: clarify workflow extension ownership - #179
Merged
rapids-bot[bot] merged 1 commit intoAug 6, 2026
Merged
Conversation
Signed-off-by: Zhongxuan Wang <daniewang@nvidia.com>
WalkthroughThe changes align adapter contribution guidance and integration configuration guidance with schema-controlled workflow extensions. Undeclared fields are rejected, conditional ChangesWorkflow Schema Guidance
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
AjayThorve
approved these changes
Aug 6, 2026
Collaborator
|
/merge |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Clarify that extensions within
FabricConfig.workflowandworkflow.entrypointare adapter-owned when a descriptor validates the workflow. A closedworkflow_schemarejects fields that it does not declare, so those extension points cannot carry caller-owned annotations.Details
workflow_schema.Validation
validate_workflow, which serializes and validates the complete workflow object against the resolved descriptor schema.additionalProperties: false.git diff --checkjust docsand focused Python tests;justanduvare unavailable in this environment. This change does not modify the docs site, generated references, or runtime code.Where should the reviewer start?
Start with
.agents/skills/contribute-adapter/SKILL.md, then reviewskills/integrations/consumer/nemo-fabric-integrate/references/config-mapping.mdfor the caller-facing clarification.Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Relates to: none
I confirm this contribution is my own work, or I have the right to submit it under this project's license.
I searched existing issues and open pull requests, and this does not duplicate existing work.
Summary by CodeRabbit