Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion adapters/codex/src/nemo_fabric_adapters/codex/adapter.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
AsyncCodex,
CodexConfig,
CodexError,
JsonRpcError,
Sandbox,
TransportClosedError,
is_retryable_error,
Expand Down Expand Up @@ -793,11 +794,14 @@ def sdk_failure(error: BaseException) -> dict[str, Any]:
"codex_connection_failed", "Codex SDK runtime connection closed"
)
if isinstance(error, CodexError):
metadata = {"sdk_error": type(error).__name__}
if isinstance(error, JsonRpcError):
metadata["jsonrpc_code"] = error.code
return _failure(
"codex_sdk_failed",
"Codex SDK request failed",
retryable=is_retryable_error(error),
sdk_error=type(error).__name__,
**metadata,
)
if isinstance(error, OSError):
return _failure(
Expand Down
11 changes: 10 additions & 1 deletion tests/adapters/test_codex_adapter.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
import pytest
from nemo_fabric import Fabric
from nemo_fabric_adapters.codex import adapter
from openai_codex import AsyncCodex, AsyncThread, AsyncTurnHandle
from openai_codex import AsyncCodex, AsyncThread, AsyncTurnHandle, JsonRpcError
from openai_codex.types import TurnStatus


Expand Down Expand Up @@ -711,6 +711,15 @@ def test_failed_sdk_turn_is_normalized_and_transport_is_closed(
assert mock_codex.instances[0].closed is True


def test_sdk_failure_preserves_jsonrpc_code():
output = adapter.sdk_failure(JsonRpcError(-32000, "provider failure"))

assert output["error"]["metadata"] == {
"sdk_error": "JsonRpcError",
"jsonrpc_code": -32000,
}
Comment thread
zhongxuanwang-nv marked this conversation as resolved.


def test_incomplete_sdk_turn_is_failed(codex_payload, mock_codex):
result = successful_result(response=None)
mock_codex.next_result = result
Expand Down
Loading