Skip to content

feat: add streaming ATOF exporter #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
omkarmehta06 wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat: add streaming ATOF exporter #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
232c587
Add streaming ATOF exporter
omkarmehta06 May 28, 2026
e0835e5
Fix streaming ATOF backpressure handling
omkarmehta06 May 28, 2026
42ccba9
test: keep ATOF socket sink alive through shutdown
omkarmehta06 May 29, 2026
63eff0d
test: wait for streaming ATOF shutdown EOF
omkarmehta06 May 29, 2026
525019e
test: drain ATOF socket sink until shutdown
omkarmehta06 May 29, 2026
9cf6daf
test: assert ATOF socket sink observes EOF
omkarmehta06 May 29, 2026
f884624
test: keep ATOF socket sinks blocking through shutdown
omkarmehta06 May 29, 2026
d1c35fc
docs: propose local cockpit viewer boundary
omkarmehta06 May 29, 2026
f1d01e0
Wire streaming ATOF through observability plugin
omkarmehta06 May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions crates/cli/src/plugins/editor_model.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ pub(super) struct ComponentEditorState<T> {

#[derive(Debug)]
pub(super) enum EditableComponent {
Observability(ComponentEditorState<ObservabilityConfig>),
Adaptive(ComponentEditorState<AdaptiveConfig>),
NemoGuardrails(ComponentEditorState<NeMoGuardrailsConfig>),
Observability(Box<ComponentEditorState<ObservabilityConfig>>),
Adaptive(Box<ComponentEditorState<AdaptiveConfig>>),
NemoGuardrails(Box<ComponentEditorState<NeMoGuardrailsConfig>>),
Comment on lines +36 to +38
Copy link
Copy Markdown
Member

@willkill07 willkill07 Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should not need to be heap-allocated.

Why are they?

}

impl EditableComponent {
Expand Down Expand Up @@ -148,9 +148,9 @@ pub(super) fn editable_components(
config: &PluginConfig,
) -> Result<Vec<EditableComponent>, CliError> {
Ok(vec![
EditableComponent::Observability(component_observability_state(config)?),
EditableComponent::Adaptive(component_adaptive_state(config)?),
EditableComponent::NemoGuardrails(component_nemo_guardrails_state(config)?),
EditableComponent::Observability(Box::new(component_observability_state(config)?)),
EditableComponent::Adaptive(Box::new(component_adaptive_state(config)?)),
EditableComponent::NemoGuardrails(Box::new(component_nemo_guardrails_state(config)?)),
Comment on lines +151 to +153
Copy link
Copy Markdown
Member

@willkill07 willkill07 Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

Suggested change
EditableComponent::Observability(Box::new(component_observability_state(config)?)),
EditableComponent::Adaptive(Box::new(component_adaptive_state(config)?)),
EditableComponent::NemoGuardrails(Box::new(component_nemo_guardrails_state(config)?)),
EditableComponent::Observability(component_observability_state(config)?),
EditableComponent::Adaptive(component_adaptive_state(config)?),
EditableComponent::NemoGuardrails(component_nemo_guardrails_state(config)?),

])
}

Expand Down
Loading