-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat(e2e): migrate baseline onboarding coverage #3897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jyaunches
merged 3 commits into
NVIDIA:main
from
jyaunches:issue-3809-migrate-baseline-onboarding-install-assertions
May 20, 2026
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
test/e2e/validation_suites/baseline-onboarding/00-cli-and-openshell.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| #!/usr/bin/env bash | ||
| # SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| set -euo pipefail | ||
| SCRIPT_DIR=$(cd -- "$(dirname -- "${BASH_SOURCE[0]}")" && pwd) | ||
| # shellcheck source=../lib/baseline_onboarding.sh | ||
| source "$SCRIPT_DIR/../lib/baseline_onboarding.sh" | ||
| baseline_onboarding_load_context | ||
| baseline_assert_nemoclaw_on_path | ||
| baseline_assert_openshell_on_path | ||
| baseline_assert_nemoclaw_help_exits_zero |
11 changes: 11 additions & 0 deletions
11
test/e2e/validation_suites/baseline-onboarding/01-sandbox-state.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| #!/usr/bin/env bash | ||
| # SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| set -euo pipefail | ||
| SCRIPT_DIR=$(cd -- "$(dirname -- "${BASH_SOURCE[0]}")" && pwd) | ||
| # shellcheck source=../lib/baseline_onboarding.sh | ||
| source "$SCRIPT_DIR/../lib/baseline_onboarding.sh" | ||
| baseline_onboarding_load_context | ||
| baseline_assert_sandbox_list_contains_context_sandbox | ||
| baseline_assert_sandbox_status_exits_zero | ||
| baseline_assert_logs_produce_output |
9 changes: 9 additions & 0 deletions
9
test/e2e/validation_suites/baseline-onboarding/02-route-and-smoke.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| #!/usr/bin/env bash | ||
| # SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| set -euo pipefail | ||
| SCRIPT_DIR=$(cd -- "$(dirname -- "${BASH_SOURCE[0]}")" && pwd) | ||
| # shellcheck source=../lib/baseline_onboarding.sh | ||
| source "$SCRIPT_DIR/../lib/baseline_onboarding.sh" | ||
| baseline_onboarding_load_context | ||
| baseline_assert_inference_route_provider |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| #!/usr/bin/env bash | ||
| # SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| baseline_onboarding_pass() { printf 'PASS: %s %s\n' "$1" "${2:-}"; } | ||
| baseline_onboarding_fail() { | ||
| printf 'FAIL: %s %s\n' "$1" "${2:-}" >&2 | ||
| return 1 | ||
| } | ||
|
|
||
| baseline_onboarding_load_context() { | ||
| local context_file="${E2E_CONTEXT_DIR:?E2E_CONTEXT_DIR is required}/context.env" | ||
| # shellcheck disable=SC1090 | ||
| source "$context_file" | ||
| : "${E2E_SANDBOX_NAME:?E2E_SANDBOX_NAME is required}" | ||
| : "${E2E_PROVIDER:?E2E_PROVIDER is required}" | ||
| : "${E2E_INFERENCE_ROUTE:?E2E_INFERENCE_ROUTE is required}" | ||
| } | ||
|
|
||
| baseline_assert_nemoclaw_on_path() { | ||
| if command -v nemoclaw >/dev/null 2>&1; then | ||
| baseline_onboarding_pass validation.baseline_onboarding.nemoclaw_on_path "nemoclaw found" | ||
| else | ||
| baseline_onboarding_fail validation.baseline_onboarding.nemoclaw_on_path "nemoclaw not on PATH" | ||
| fi | ||
| } | ||
|
|
||
| baseline_assert_openshell_on_path() { | ||
| if command -v openshell >/dev/null 2>&1; then | ||
| baseline_onboarding_pass validation.baseline_onboarding.openshell_on_path "openshell found" | ||
| else | ||
| baseline_onboarding_fail validation.baseline_onboarding.openshell_on_path "openshell not on PATH" | ||
| fi | ||
| } | ||
|
|
||
| baseline_assert_nemoclaw_help_exits_zero() { | ||
| local out | ||
| if out=$(nemoclaw --help 2>&1); then | ||
| baseline_onboarding_pass validation.baseline_onboarding.nemoclaw_help_exits_zero "nemoclaw --help exits 0" | ||
| else | ||
| baseline_onboarding_fail validation.baseline_onboarding.nemoclaw_help_exits_zero "nemoclaw --help failed: ${out:0:200}" | ||
| fi | ||
| } | ||
|
|
||
| baseline_assert_sandbox_list_contains_context_sandbox() { | ||
| local out | ||
| if out=$(nemoclaw list 2>&1) && awk -v n="$E2E_SANDBOX_NAME" '$1 == n { found = 1 } END { exit !found }' <<<"$out"; then | ||
| baseline_onboarding_pass validation.baseline_onboarding.sandbox_listed "$E2E_SANDBOX_NAME listed" | ||
| else | ||
| baseline_onboarding_fail validation.baseline_onboarding.sandbox_listed "sandbox not listed: ${out:0:200}" | ||
| fi | ||
| } | ||
|
|
||
| baseline_assert_sandbox_status_exits_zero() { | ||
| local out | ||
| if out=$(nemoclaw status "$E2E_SANDBOX_NAME" 2>&1); then | ||
| baseline_onboarding_pass validation.baseline_onboarding.sandbox_status "$E2E_SANDBOX_NAME status ok" | ||
| else | ||
| baseline_onboarding_fail validation.baseline_onboarding.sandbox_status "status failed: ${out:0:200}" | ||
| fi | ||
| } | ||
|
|
||
| baseline_assert_logs_produce_output() { | ||
| local out | ||
| if out=$(nemoclaw logs "$E2E_SANDBOX_NAME" 2>&1) && [[ -n "$out" ]]; then | ||
| baseline_onboarding_pass validation.baseline_onboarding.logs_available "logs available" | ||
| else | ||
| baseline_onboarding_fail validation.baseline_onboarding.logs_available "logs unavailable" | ||
| fi | ||
| } | ||
|
|
||
| baseline_assert_inference_route_provider() { | ||
| local expected="${1:-$E2E_PROVIDER}" | ||
| if [[ "${E2E_PROVIDER:-}" == "$expected" ]]; then | ||
| baseline_onboarding_pass validation.baseline_onboarding.inference_route_provider "provider=$expected route=${E2E_INFERENCE_ROUTE:-}" | ||
| else | ||
| baseline_onboarding_fail validation.baseline_onboarding.inference_route_provider "provider mismatch" | ||
| fi | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.